You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/03/24 22:47:53 UTC

[GitHub] [dolphinscheduler] mans2singh opened a new pull request #9176: [dolphinscheduler-api][task-group-controller] Corrected notes for create, update and queryTaskGroupByStatus

mans2singh opened a new pull request #9176:
URL: https://github.com/apache/dolphinscheduler/pull/9176


   
   ## Purpose of the pull request
   
   - The notes in create, update and queryTaskGroupByStatus has spelling mistakes (TAKS, and STSATUS) (`CREATE_TAKS_GROUP_NOTE`, `UPDATE_TAKS_GROUP_NOTE`, `QUERY_TASK_GROUP_LIST_BY_STSATUS_NOTES`).
   
   ## Brief change log
   
   - Update the corresponding notes.
   
   ## Verify this pull request
   
   This pull request is already covered by existing test in the module.  
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [dolphinscheduler] caishunfeng merged pull request #9176: [dolphinscheduler-api][task-group-controller] Corrected notes for create, update and queryTaskGroupByStatus

Posted by GitBox <gi...@apache.org>.
caishunfeng merged pull request #9176:
URL: https://github.com/apache/dolphinscheduler/pull/9176


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [dolphinscheduler] mans2singh commented on pull request #9176: [dolphinscheduler-api][task-group-controller] Corrected notes for create, update and queryTaskGroupByStatus

Posted by GitBox <gi...@apache.org>.
mans2singh commented on pull request #9176:
URL: https://github.com/apache/dolphinscheduler/pull/9176#issuecomment-1085370353


   Thanks @caishunfeng for your time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [dolphinscheduler] codecov-commenter commented on pull request #9176: [dolphinscheduler-api][task-group-controller] Corrected notes for create, update and queryTaskGroupByStatus

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #9176:
URL: https://github.com/apache/dolphinscheduler/pull/9176#issuecomment-1079125594


   # [Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/9176?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#9176](https://codecov.io/gh/apache/dolphinscheduler/pull/9176?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3b1f093) into [dev](https://codecov.io/gh/apache/dolphinscheduler/commit/934d0ad0633e3ec04e54fd6527662f2674194ad3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (934d0ad) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   ```diff
   @@            Coverage Diff            @@
   ##                dev    #9176   +/-   ##
   =========================================
     Coverage     40.28%   40.28%           
   - Complexity     4372     4373    +1     
   =========================================
     Files           814      814           
     Lines         32584    32584           
     Branches       3650     3650           
   =========================================
     Hits          13126    13126           
   - Misses        18227    18228    +1     
   + Partials       1231     1230    -1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dolphinscheduler/pull/9176?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...nscheduler/api/controller/TaskGroupController.java](https://codecov.io/gh/apache/dolphinscheduler/pull/9176/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2NvbnRyb2xsZXIvVGFza0dyb3VwQ29udHJvbGxlci5qYXZh) | `81.81% <ø> (ø)` | |
   | [...r/plugin/task/sqoop/parameter/SqoopParameters.java](https://codecov.io/gh/apache/dolphinscheduler/pull/9176/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci10YXNrLXBsdWdpbi9kb2xwaGluc2NoZWR1bGVyLXRhc2stc3Fvb3Avc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcGx1Z2luL3Rhc2svc3Fvb3AvcGFyYW1ldGVyL1Nxb29wUGFyYW1ldGVycy5qYXZh) | `56.33% <0.00%> (-1.41%)` | :arrow_down: |
   | [...er/master/dispatch/host/assign/RandomSelector.java](https://codecov.io/gh/apache/dolphinscheduler/pull/9176/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1tYXN0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9kaXNwYXRjaC9ob3N0L2Fzc2lnbi9SYW5kb21TZWxlY3Rvci5qYXZh) | `83.33% <0.00%> (+5.55%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/9176?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/9176?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [934d0ad...3b1f093](https://codecov.io/gh/apache/dolphinscheduler/pull/9176?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org