You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by Aman Sinha <as...@maprtech.com> on 2013/12/06 23:37:42 UTC
Review Request 16093: Patch for DRILL-318
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16093/
-----------------------------------------------------------
Review request for drill.
Bugs: DRILL-318
https://issues.apache.org/jira/browse/DRILL-318
Repository: drill-git
Description
-------
Added template-based code generation for aggregate functions: min, max, sum, count, avg. These support several data types both nullable and non-nullable.
Diffs
-----
common/src/main/java/org/apache/drill/common/expression/fn/AggregationFunctions.java 5b46b786e0bad694669099ba59c8a3ce89e13b6f
exec/java-exec/src/main/codegen/config.fmpp cd2b2cce1c7d89b389404e24d9a8110e99388202
exec/java-exec/src/main/codegen/data/AggrTypes1.tdd PRE-CREATION
exec/java-exec/src/main/codegen/data/AggrTypes2.tdd PRE-CREATION
exec/java-exec/src/main/codegen/templates/AggrTypeFunctions1.java PRE-CREATION
exec/java-exec/src/main/codegen/templates/AggrTypeFunctions2.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/agg/impl/CountFunctions.java b0939f1fea7876b7f1ba6c522438b52af31ef6cf
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/agg/impl/SumFunctions.java 57905fed5c7567475c43f3266a050be14b8af9fb
Diff: https://reviews.apache.org/r/16093/diff/
Testing
-------
Thanks,
Aman Sinha
Re: Review Request 16093: Patch for DRILL-318
Posted by Aman Sinha <as...@maprtech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16093/
-----------------------------------------------------------
(Updated Dec. 6, 2013, 11:36 p.m.)
Review request for drill, Jacques Nadeau and Steven Phillips.
Bugs: DRILL-318
https://issues.apache.org/jira/browse/DRILL-318
Repository: drill-git
Description (updated)
-------
Added template-based code generation for aggregate functions: min, max, sum, count, avg. These support following datatypes both nullable and non-nullable: Int, BigInt, float4, float8. For Sum and Count, previously SumFunctions.java and CountFunctions.java existed in the source tree. I have removed these files since these will be auto-generated similar to other aggr functions.
Diffs
-----
common/src/main/java/org/apache/drill/common/expression/fn/AggregationFunctions.java 5b46b786e0bad694669099ba59c8a3ce89e13b6f
exec/java-exec/src/main/codegen/config.fmpp cd2b2cce1c7d89b389404e24d9a8110e99388202
exec/java-exec/src/main/codegen/data/AggrTypes1.tdd PRE-CREATION
exec/java-exec/src/main/codegen/data/AggrTypes2.tdd PRE-CREATION
exec/java-exec/src/main/codegen/templates/AggrTypeFunctions1.java PRE-CREATION
exec/java-exec/src/main/codegen/templates/AggrTypeFunctions2.java PRE-CREATION
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/agg/impl/CountFunctions.java b0939f1fea7876b7f1ba6c522438b52af31ef6cf
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/agg/impl/SumFunctions.java 57905fed5c7567475c43f3266a050be14b8af9fb
Diff: https://reviews.apache.org/r/16093/diff/
Testing (updated)
-------
Manual testing using sqlline using sample parquet tpch data. Will be adding Junit tests later.
Thanks,
Aman Sinha