[GitHub] [incubator-pinot] jackjlli commented on pull request #6139: Remove tyrus dependencies in pinot-tools module

[GitBox <gi...@apache.org>]

jackjlli commented on pull request #6139:
URL: https://github.com/apache/incubator-pinot/pull/6139#issuecomment-708083475


   > It is unclear on why removing tyrus requires changing MeetupStream to be a static file. Could you explain?
   
   Currently Tyrus is only used for streaming data in `RealtimeQuickStart` class.  It depends on an external source for now (i.e. meetup.com). If anything breaks in the upstream, our build/test will inevitably fail (this is what we faced recently).
   Plus, the current logic doesn't validate the actual result from this event because the result isn't deterministic; it just evaluates whether realtime table has consumed some data. Emitting some sample events from a sample file should suffice this requirement. 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org