[GitHub] [trafficcontrol] rob05c opened a new pull request #5887: Fix t3c reval to reload

[GitBox <gi...@apache.org>]

rob05c opened a new pull request #5887:
URL: https://github.com/apache/trafficcontrol/pull/5887


   Reval reload was failing because reval doesn't get and check packages
   from Traffic Ops. Which it doesn't need to, but the func to check
   if a package was installed was only checking the cache populated by
   the TO fetch.
   
   This fixes it to check rpm if the requested package isn't in the
   cache, which then fixes the call to know trafficserver is installed,
   which then fixes the thing that calls that to reload ATS correctly.
   
   Includes an integration test to verify a reval triggers a reload properly from now on.
   No changelog, no docs, no interface change, and bug isn't in a release.
   
   - [x] This PR is not related to any other Issue
   
   ## Which Traffic Control components are affected by this PR?
   - Traffic Ops ORT
   
   ## What is the best way to verify this PR?
   Run t3c/ORT Integration tests. Create a Reval and set the Reval Flag on a server, then run `t3c apply --run-mode=revalidate`, verify it gets the new file and Reloads ATS.
   
   ## If this is a bug fix, what versions of Traffic Control are affected?
   - master
   
   ## The following criteria are ALL met by this PR
   - [x] This PR includes tests OR I have explained why tests are unnecessary
   - [x] This PR includes documentation OR I have explained why documentation is unnecessary
   - [x] This PR includes an update to CHANGELOG.md OR such an update is not necessary
   - [x] This PR includes any and all required license headers
   - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://www.apache.org/security/) for details)
   
   
   ## Additional Information


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficcontrol] zrhoffman merged pull request #5887: Fix t3c reval to reload

[GitBox <gi...@apache.org>]

zrhoffman merged pull request #5887:
URL: https://github.com/apache/trafficcontrol/pull/5887


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org