You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Quanlong Huang (Code Review)" <ge...@cloudera.org> on 2022/03/30 08:16:04 UTC
[native-toolchain-CR] IMPALA-10854: Use ZSTD in toolchain to build ORC
Quanlong Huang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18367
Change subject: IMPALA-10854: Use ZSTD in toolchain to build ORC
......................................................................
IMPALA-10854: Use ZSTD in toolchain to build ORC
The ORC build will download and compile ZSTD if env var ZSTD_HOME is
undefined. We already have ZSTD in the toolchain. This patch let ORC
depends on the ZSTD in our toolchain. Also disables building ORC tests.
Tests:
- Built native-toolchain and verified check/orc-1.7.0-p7.log that zstd
is not downloaded again.
- Compiled Impala with it and ran TPCH tests locally.
Change-Id: Ifa8f0f55254e777b0132480a80737d9169410c73
---
M buildall.sh
M source/orc/build.sh
2 files changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/67/18367/1
--
To view, visit http://gerrit.cloudera.org:8080/18367
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifa8f0f55254e777b0132480a80737d9169410c73
Gerrit-Change-Number: 18367
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
[native-toolchain-CR] IMPALA-10854: Use ZSTD in toolchain to build ORC
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18367 )
Change subject: IMPALA-10854: Use ZSTD in toolchain to build ORC
......................................................................
Patch Set 1:
> Patch Set 1:
>
> We could remove the protobuf related patch when disable building ORC test.
That will bring down the version from 1.7.0-p7 to 1.7.0-p6. I'm afraid it will introduce misunderstaning.. I think we can drop it next time when we bump the base version.
--
To view, visit http://gerrit.cloudera.org:8080/18367
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa8f0f55254e777b0132480a80737d9169410c73
Gerrit-Change-Number: 18367
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Thu, 31 Mar 2022 01:02:37 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-10854: Use ZSTD in toolchain to build ORC
Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/18367 )
Change subject: IMPALA-10854: Use ZSTD in toolchain to build ORC
......................................................................
Patch Set 1:
We could remove the protobuf related patch when disable building ORC test.
--
To view, visit http://gerrit.cloudera.org:8080/18367
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa8f0f55254e777b0132480a80737d9169410c73
Gerrit-Change-Number: 18367
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Wed, 30 Mar 2022 15:43:23 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-10854: Use ZSTD in toolchain to build ORC
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18367 )
Change subject: IMPALA-10854: Use ZSTD in toolchain to build ORC
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18367
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa8f0f55254e777b0132480a80737d9169410c73
Gerrit-Change-Number: 18367
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Mon, 04 Apr 2022 06:57:33 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-10854: Use ZSTD in toolchain to build ORC
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18367 )
Change subject: IMPALA-10854: Use ZSTD in toolchain to build ORC
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/18367
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa8f0f55254e777b0132480a80737d9169410c73
Gerrit-Change-Number: 18367
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Mon, 04 Apr 2022 06:59:35 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-10854: Use ZSTD in toolchain to build ORC
Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/18367 )
Change subject: IMPALA-10854: Use ZSTD in toolchain to build ORC
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/18367
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa8f0f55254e777b0132480a80737d9169410c73
Gerrit-Change-Number: 18367
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Thu, 31 Mar 2022 01:14:30 +0000
Gerrit-HasComments: No
[native-toolchain-CR] IMPALA-10854: Use ZSTD in toolchain to build ORC
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18367 )
Change subject: IMPALA-10854: Use ZSTD in toolchain to build ORC
......................................................................
IMPALA-10854: Use ZSTD in toolchain to build ORC
The ORC build will download and compile ZSTD if env var ZSTD_HOME is
undefined. We already have ZSTD in the toolchain. This patch let ORC
depends on the ZSTD in our toolchain. Also disables building ORC tests.
Tests:
- Built native-toolchain and verified check/orc-1.7.0-p7.log that zstd
is not downloaded again.
- Compiled Impala with it and ran TPCH tests locally.
Change-Id: Ifa8f0f55254e777b0132480a80737d9169410c73
Reviewed-on: http://gerrit.cloudera.org:8080/18367
Reviewed-by: Wenzhe Zhou <wz...@cloudera.com>
Reviewed-by: Csaba Ringhofer <cs...@cloudera.com>
Tested-by: Quanlong Huang <hu...@gmail.com>
---
M buildall.sh
M source/orc/build.sh
2 files changed, 3 insertions(+), 1 deletion(-)
Approvals:
Wenzhe Zhou: Looks good to me, but someone else must approve
Csaba Ringhofer: Looks good to me, approved
Quanlong Huang: Verified
--
To view, visit http://gerrit.cloudera.org:8080/18367
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifa8f0f55254e777b0132480a80737d9169410c73
Gerrit-Change-Number: 18367
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
[native-toolchain-CR] IMPALA-10854: Use ZSTD in toolchain to build ORC
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18367 )
Change subject: IMPALA-10854: Use ZSTD in toolchain to build ORC
......................................................................
Patch Set 1:
Merging this. Thank Wenzhe and Csaba!
--
To view, visit http://gerrit.cloudera.org:8080/18367
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa8f0f55254e777b0132480a80737d9169410c73
Gerrit-Change-Number: 18367
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Mon, 04 Apr 2022 06:59:55 +0000
Gerrit-HasComments: No