[GitHub] [lucene-solr] dsmiley commented on pull request #2306: SOLR-15121: Move XSLT (tr param) to scripting contrib

[GitBox <gi...@apache.org>]

dsmiley commented on pull request #2306:
URL: https://github.com/apache/lucene-solr/pull/2306#issuecomment-775272067


   @epugh I see in your latest change that XMLLoader continues to know about XSLT stylesheets.  Couldn't/shouldn't that go in the XsltRequestHandler that you added?  I suppose you're getting somewhat conflicting feedback between me and @uschindler . My preference is that all XSLT stuff is in this new contrib.  Uwe had suggested some trivial toggle/setting to the existing code.  I think his latest feedback is basically the idea of adding an intercepting spot (in XMLLoader) so that it needn't have the XSLT code there but it could be added in by the contrib, say by subclassing XMLLoader.  @uschindler does this make sense to you?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org