You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by scwf <gi...@git.apache.org> on 2015/09/24 05:41:55 UTC

[GitHub] spark pull request: [SQL] Add toString to DataFrame/Column

Github user scwf commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4436#discussion_r40283225
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala ---
    @@ -67,6 +68,17 @@ abstract class Expression extends TreeNode[Expression] {
       def childrenResolved = !children.exists(!_.resolved)
     
       /**
    +   * Returns a string representation of this expression that does not have developer centric
    +   * debugging information like the expression id.
    +   */
    +  def prettyString: String = {
    +    transform {
    --- End diff --
    
    why use transform here? this will change the expression


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org