[GitHub] [accumulo] milleruntime commented on pull request #1751: WIP Design: Interface for handling tablet state migration

[GitBox <gi...@apache.org>]

milleruntime commented on pull request #1751:
URL: https://github.com/apache/accumulo/pull/1751#issuecomment-716664244


   > Is the following the code you are trying to simplify?
   > 
   > [TabletGroupWatcher link](https://github.com/apache/accumulo/blob/353c611891a8b88b307dcba5e884467d4191b1f2/server/manager/src/main/java/org/apache/accumulo/master/TabletGroupWatcher.java#L252-L343)
   
   Yes that is where I started.
   
   > How much of your goals could accomplished by replacing code blocks w/ functions like below? 
   
   This is certainly an improvement.  We could make this change, regardless of any other refactoring I do.  It makes this code block easier to read at least.
   
   > I think you are also trying to simplify master.getGoalState() and possibly consolidate concerns that currently straddle master.getGoalState() and TabletGroupWatcher? If that is true, then it seems like the following would not accomplish all of your goals.
   
   Correct.
   
   > As for the merge code, that code straddles FATE and the Tablet goal state code in a way that is hard to follow. It may need improvement, but I am uncertain what the improvement is.
   
   I agree.  I was aiming for a design that would allow adding more states to handle this code as well.  


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org