You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/11/18 03:22:24 UTC

[GitHub] [airflow] francotesei opened a new pull request #19669: Added FAB with dependencies.

francotesei opened a new pull request #19669:
URL: https://github.com/apache/airflow/pull/19669


   Added (again) AppBuilder Base class from FAB to Airflow ([here](https://github.com/apache/airflow/pull/19322)). This was reverted [here](https://github.com/apache/airflow/pull/19661), because of missing dependencies.
   Added JS and CSS dependencies & new templates: baselayout.html & init.html.
   related: #19647
   closes: #19647
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] francotesei closed pull request #19669: Added FAB with dependencies.

Posted by GitBox <gi...@apache.org>.
francotesei closed pull request #19669:
URL: https://github.com/apache/airflow/pull/19669


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] francotesei commented on pull request #19669: Added FAB with dependencies.

Posted by GitBox <gi...@apache.org>.
francotesei commented on pull request #19669:
URL: https://github.com/apache/airflow/pull/19669#issuecomment-972532445


   Thank you for your reply guys! I totally agree with you.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] jhtimmins commented on pull request #19669: Added FAB with dependencies.

Posted by GitBox <gi...@apache.org>.
jhtimmins commented on pull request #19669:
URL: https://github.com/apache/airflow/pull/19669#issuecomment-972527264


   @francotesei Thanks for adding this, but I agree with Brent that we should copy as little from FAB as possible.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #19669: Added FAB with dependencies.

Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #19669:
URL: https://github.com/apache/airflow/pull/19669#issuecomment-972483880


   Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
   Here are some useful points:
   - Pay attention to the quality of your code (flake8, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
   - In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
   - Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, itโ€™s a heavy docker but it ships with a working Airflow and a lot of integrations.
   - Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
   - Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
   - Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
   Apache Airflow is a community-driven project and together we are making it better ๐Ÿš€.
   In case of doubts contact the developers at:
   Mailing List: dev@airflow.apache.org
   Slack: https://s.apache.org/airflow-slack
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] bbovenzi commented on pull request #19669: Added FAB with dependencies.

Posted by GitBox <gi...@apache.org>.
bbovenzi commented on pull request #19669:
URL: https://github.com/apache/airflow/pull/19669#issuecomment-972521898


   Great job on your first PR. I think we'd want to go with the simpler fix in #19667. But I'll let @jhtimmins chime in.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org