You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2022/01/18 01:25:54 UTC

[GitHub] [orc] zhanglistar commented on a change in pull request #1017: ORC-1090: Disable Clang 13.0-specific compilation warnings

zhanglistar commented on a change in pull request #1017:
URL: https://github.com/apache/orc/pull/1017#discussion_r786357933



##########
File path: CMakeLists.txt
##########
@@ -97,6 +97,9 @@ if (CMAKE_CXX_COMPILER_ID STREQUAL "Clang")
   set (WARN_FLAGS "${WARN_FLAGS} -Wno-missing-noreturn -Wno-unknown-pragmas")
   set (WARN_FLAGS "${WARN_FLAGS} -Wno-gnu-zero-variadic-macro-arguments")
   set (WARN_FLAGS "${WARN_FLAGS} -Wconversion")
+  if (CMAKE_CXX_COMPILER_VERSION VERSION_GREATER_EQUAL "13.0")

Review comment:
       > Got it. So, `VERSION_GREATER` -> `VERSION_GREATER_EQUAL` is the change we needed?
   
   True, sorry for the careless mistake.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org