You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by raj-bains <gi...@git.apache.org> on 2015/09/03 09:00:51 UTC
[GitHub] incubator-zeppelin pull request: Add File Interpreter, HDFS Interp...
GitHub user raj-bains opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/276
Add File Interpreter, HDFS Interpreter and Tests
This is the first version of File Interpreter that adds basic ls, cd and pwd functionality against WebHDFS. It addresses ZEPPELIN-198
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/raj-bains/incubator-zeppelin master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/276.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #276
----
commit 865e6ab5970d79613f19a0afadb0c953efc2730b
Author: Raj Bains <ra...@rajs-macbook-pro.local>
Date: 2015-09-03T06:50:56Z
Add File Interpreter, HDFS Interpreter and Tests
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Add File Interpreter, HDFS Interp...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/276#issuecomment-186915981
Ping. Would anyone else like to pick this up if we don't hear back from @raj-bains ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Add File Interpreter, HDFS Interp...
Posted by raj-bains <gi...@git.apache.org>.
Github user raj-bains commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/276#issuecomment-139374312
The request is ready to merge. Made changes based on the comments including adding documentation.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Add File Interpreter, HDFS Interp...
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/276#issuecomment-137605638
Most probably you also want to update ` conf/zeppelin-site.xml.template` property `zeppelin.interpreters` with name of the new interpreter class
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Add File Interpreter, HDFS Interp...
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/276#issuecomment-189099153
@runyontr thanks for standing up!
> Given that I can fix the list above, how do I update this pull request with my repository?
It's not really possible, so what you may do instead is - submit a new PR following [CONTRIBUTING guidelines](https://github.com/apache/incubator-zeppelin/blob/master/CONTRIBUTING.md) , mentioning this work and linking new PR from here as well i.e by using Github #NNN mentions.
If you could use ZEPPELIN-198 issue name in your commit messages - it will be linked to the JIRA ticket as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Add File Interpreter, HDFS Interp...
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/276#issuecomment-168963864
@raj-bains could you please elaborate on status of this PR - do you want to update\add doc\merge it or close it unresolved?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Add File Interpreter, HDFS Interp...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/276#issuecomment-178406139
@raj-bains any update?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Add File Interpreter, HDFS Interp...
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/276#issuecomment-137373722
Thank you for great contribution!
Can you please also provide the documentation for new interpreter (needs to be in a separate PR to gh-pages branch)?
I.e right now it looks like only a limited subset of commands is supported, so it's a good idea mention things like that.
We keep track of list of interpreters here https://github.com/apache/incubator-zeppelin/blob/gh-pages/docs/index.md and here https://github.com/apache/incubator-zeppelin/tree/gh-pages/docs/interpreter a new 'page' can be added.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Add File Interpreter, HDFS Interp...
Posted by runyontr <gi...@git.apache.org>.
Github user runyontr commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/276#issuecomment-189093591
@felixcheung I'll be happy to take this up. From what I can see there is the following left:
- Change string creation to use StringBuilder
- Throw exception up the chain in the isDirectory()
- Update `conf/zeppelin-site.xml.template` with HdfsInterpretor
One I've seen is that the alignment of columns when using `%hdfs ls -l ` when column sizes are drastically different cause a mis alignment in its display.
I had to change the POM file to get the interpreter for runtime execution as well, I'll include that change as well.
What other items would you like me to accomplish
What I've done is forked the apache/incubator-zeppelin git repo and merged raj-bains/incubator-zeppelin (fixed merge conflicts). Given that I can fix the list above, how do I update this pull request with my repository?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Add File Interpreter, HDFS Interp...
Posted by raj-bains <gi...@git.apache.org>.
Github user raj-bains commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/276#issuecomment-170313023
I'm on vacation for 10 days, then I'll update the patch and check this in
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---