[jira] [Commented] (CASSANDRA-7338) CFS.getRangeSlice should update latency metrics

["Benedict (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-7338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14015365#comment-14015365 ] 

Benedict commented on CASSANDRA-7338:
-------------------------------------

These are not equivalent operations? I'm not convinced we should be mixing statistics for them, as the currently measured requests should all be comparable in latency (give or take), whereas a range scan is necessarily a much more (and arbitrarily) expensive operation. They're tracked at the ClientRequestMetrics level in StorageProxy under rangeMetrics

> CFS.getRangeSlice should update latency metrics
> -----------------------------------------------
>
>                 Key: CASSANDRA-7338
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-7338
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Sam Tunnicliffe
>            Assignee: Sam Tunnicliffe
>            Priority: Trivial
>             Fix For: 2.0.9
>
>         Attachments: CASSANDRA-7338.txt
>
>
> CFS.getRangeSlice doesn't update the CF readLatency metric in the same way as CFS.getColumnFamily does. 
> I may be missing something, but I couldn't see a good reason why this wasn't already the case as without it, "SELECT * FROM t WHERE x=y" results in the read metrics being incremented, but "SELECT * FROM t" doesn't.



--
This message was sent by Atlassian JIRA
(v6.2#6252)