[GitHub] [beam] pabloem commented on a change in pull request #15322: [BEAM-12742] Samza Runner does not properly delete modified timer

[GitBox <gi...@apache.org>]

pabloem commented on a change in pull request #15322:
URL: https://github.com/apache/beam/pull/15322#discussion_r687986145



##########
File path: sdks/java/core/src/test/java/org/apache/beam/sdk/io/WriteFilesTest.java
##########
@@ -329,7 +329,11 @@ public void testWithRunnerDeterminedShardingUnbounded() throws IOException {
   }
 
   @Test
-  @Category({NeedsRunner.class, UsesUnboundedPCollections.class, UsesTestStream.class})
+  @Category({
+    NeedsRunner.class,
+    UsesUnboundedPCollections.class,
+    UsesTestStreamWithProcessingTime.class

Review comment:
       maybe keep the `UsesTestStream.class` category as well?

##########
File path: sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/ParDoTest.java
##########
@@ -4670,7 +4670,7 @@ public void onTimer(
     }
 
     @Test
-    @Category(NeedsRunner.class)
+    @Category({NeedsRunner.class, UsesTimersInParDo.class, UsesTestStream.class})

Review comment:
       Thanks a lot for adding all of these categories. It will be helpful. Maybe add `UsesTestStream.class` to all of those that also have `UsesTestStreamWithProcessingTime.class`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org