You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Sergey Shelukhin <se...@hortonworks.com> on 2015/11/16 21:29:38 UTC
Re: Review Request 40365: HIVE-11358 Move LlapConfiguration into
HiveConf and document the settings
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40365/
-----------------------------------------------------------
(Updated Nov. 16, 2015, 8:29 p.m.)
Review request for hive, Lefty Leverenz and Siddharth Seth.
Summary (updated)
-----------------
HIVE-11358 Move LlapConfiguration into HiveConf and document the settings
Repository: hive-git
Description
-------
see JIRA
Diffs
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 01cd731
llap-client/src/java/org/apache/hadoop/hive/llap/configuration/LlapConfiguration.java bd09024
llap-client/src/java/org/apache/hadoop/hive/llap/registry/impl/LlapFixedRegistryImpl.java 34e0682
llap-client/src/java/org/apache/hadoop/hive/llap/registry/impl/LlapRegistryService.java a8e1465
llap-client/src/java/org/apache/hadoop/hive/llap/registry/impl/LlapYarnRegistryImpl.java d474b6f
llap-server/src/java/org/apache/hadoop/hive/llap/cli/LlapServiceDriver.java 317fa20
llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/AMReporter.java 6d54fd4
llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/ContainerRunnerImpl.java 4b28b53
llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/LlapDaemon.java 98b1ccd
llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/QueryFileCleaner.java bc18a77
llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/QueryTracker.java 2db2833
llap-server/src/java/org/apache/hadoop/hive/llap/daemon/services/impl/LlapWebServices.java 9520413
llap-server/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskCommunicator.java d327fc0
llap-server/src/java/org/apache/hadoop/hive/llap/tezplugins/TaskCommunicator.java 33e998c
llap-server/src/java/org/apache/tez/dag/app/rm/LlapTaskSchedulerService.java e920f86
llap-server/src/test/org/apache/hadoop/hive/llap/daemon/MiniLlapCluster.java 4525ab9
llap-server/src/test/org/apache/hadoop/hive/llap/daemon/impl/TestLlapDaemonProtocolServerImpl.java 8d45c95
llap-server/src/test/org/apache/tez/dag/app/rm/TestLlapTaskSchedulerService.java 23724a4
Diff: https://reviews.apache.org/r/40365/diff/
Testing
-------
Thanks,
Sergey Shelukhin
Re: Review Request 40365: HIVE-11358 Move LlapConfiguration into
HiveConf and document the settings
Posted by Lefty Leverenz <le...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40365/#review107484
-----------------------------------------------------------
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java (lines 2366 - 2369)
<https://reviews.apache.org/r/40365/#comment166604>
which parameter sets the task timeout interval?
- Lefty Leverenz
On Nov. 16, 2015, 8:59 p.m., Sergey Shelukhin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40365/
> -----------------------------------------------------------
>
> (Updated Nov. 16, 2015, 8:59 p.m.)
>
>
> Review request for hive, Lefty Leverenz and Siddharth Seth.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> see JIRA
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 01cd731
> llap-client/src/java/org/apache/hadoop/hive/llap/configuration/LlapConfiguration.java bd09024
> llap-client/src/java/org/apache/hadoop/hive/llap/registry/impl/LlapFixedRegistryImpl.java 34e0682
> llap-client/src/java/org/apache/hadoop/hive/llap/registry/impl/LlapRegistryService.java a8e1465
> llap-client/src/java/org/apache/hadoop/hive/llap/registry/impl/LlapYarnRegistryImpl.java d474b6f
> llap-server/src/java/org/apache/hadoop/hive/llap/cli/LlapServiceDriver.java 317fa20
> llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/AMReporter.java 6d54fd4
> llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/ContainerRunnerImpl.java 4b28b53
> llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/LlapDaemon.java 98b1ccd
> llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/QueryFileCleaner.java bc18a77
> llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/QueryTracker.java 2db2833
> llap-server/src/java/org/apache/hadoop/hive/llap/daemon/services/impl/LlapWebServices.java 9520413
> llap-server/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskCommunicator.java d327fc0
> llap-server/src/java/org/apache/hadoop/hive/llap/tezplugins/TaskCommunicator.java 33e998c
> llap-server/src/java/org/apache/tez/dag/app/rm/LlapTaskSchedulerService.java e920f86
> llap-server/src/test/org/apache/hadoop/hive/llap/daemon/MiniLlapCluster.java 4525ab9
> llap-server/src/test/org/apache/hadoop/hive/llap/daemon/impl/TestLlapDaemonProtocolServerImpl.java 8d45c95
> llap-server/src/test/org/apache/tez/dag/app/rm/TestLlapTaskSchedulerService.java 23724a4
>
> Diff: https://reviews.apache.org/r/40365/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergey Shelukhin
>
>
Re: Review Request 40365: HIVE-11358 Move LlapConfiguration into
HiveConf and document the settings
Posted by Lefty Leverenz <le...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40365/#review107478
-----------------------------------------------------------
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java (lines 2358 - 2359)
<https://reviews.apache.org/r/40365/#comment166584>
spell out "directories" (2 places)
"Need to be set" -> "Needs to be set"
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java (line 2363)
<https://reviews.apache.org/r/40365/#comment166585>
Reminder: TODO doc.
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java (line 2365)
<https://reviews.apache.org/r/40365/#comment166586>
Reminder: TODO doc.
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java (lines 2366 - 2369)
<https://reviews.apache.org/r/40365/#comment166587>
This isn't the latest patch. I'll give review comments based on the 02.patch (Nov. 18):
"as high possible" -> "as high as possible"
give a brief description before "This needs to be ...", specifying that the default units are milliseconds
nit: add a period at end of description (for consistency with other descriptions)
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java (line 2373)
<https://reviews.apache.org/r/40365/#comment166588>
nit: add a period at end of description (for consistency)
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java (lines 2375 - 2378)
<https://reviews.apache.org/r/40365/#comment166589>
specify that the default time unit is milliseconds
nit: add period at end of description
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java (lines 2384 - 2385)
<https://reviews.apache.org/r/40365/#comment166590>
specify that the default unit is megabytes
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java (line 2388)
<https://reviews.apache.org/r/40365/#comment166591>
could spell out "virtual CPUs" but it's easy to find by googling, so not necessary
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java (lines 2392 - 2393)
<https://reviews.apache.org/r/40365/#comment166592>
specify that the default time unit is seconds (even though it's obvious from the parameter name)
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java (lines 2404 - 2407)
<https://reviews.apache.org/r/40365/#comment166593>
specify that the default time unit is milliseconds
nit: period at end of description
does exponential back-off need explanation?
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java (lines 2409 - 2412)
<https://reviews.apache.org/r/40365/#comment166594>
(same comments as previous parameter)
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java (lines 2414 - 2417)
<https://reviews.apache.org/r/40365/#comment166595>
do backoff and blacklist need explanation?
better to spell out minimum and maximum
should "Blacklists timeouts" be "Blacklist timeouts"?
nit: period at end of description
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java (lines 2421 - 2423)
<https://reviews.apache.org/r/40365/#comment166596>
need a period after "-1 indicates unlimited capacity"
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java (lines 2426 - 2429)
<https://reviews.apache.org/r/40365/#comment166597>
just curious: why is the parameter name "comparator" instead of "scheduler" (as in LLAP_DAEMON_WAIT_QUEUE_SCHEDULER_CLASS_NAME)?
... or vice versa ... maybe it's short for "scheduler comparator" and "class name" refers to the comparator, not the scheduler
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java (line 2435)
<https://reviews.apache.org/r/40365/#comment166598>
nit: period at end of description
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java (line 2439)
<https://reviews.apache.org/r/40365/#comment166599>
"a LLAP daemon" -> "an LLAP daemon"
specify that the default time unit is milliseconds
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java (lines 2441 - 2443)
<https://reviews.apache.org/r/40365/#comment166600>
should "waiting for a connection failure" be "waiting for a connection after a failure"?
specify that the default time unit is milliseconds
- Lefty Leverenz
On Nov. 16, 2015, 8:59 p.m., Sergey Shelukhin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40365/
> -----------------------------------------------------------
>
> (Updated Nov. 16, 2015, 8:59 p.m.)
>
>
> Review request for hive, Lefty Leverenz and Siddharth Seth.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> see JIRA
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 01cd731
> llap-client/src/java/org/apache/hadoop/hive/llap/configuration/LlapConfiguration.java bd09024
> llap-client/src/java/org/apache/hadoop/hive/llap/registry/impl/LlapFixedRegistryImpl.java 34e0682
> llap-client/src/java/org/apache/hadoop/hive/llap/registry/impl/LlapRegistryService.java a8e1465
> llap-client/src/java/org/apache/hadoop/hive/llap/registry/impl/LlapYarnRegistryImpl.java d474b6f
> llap-server/src/java/org/apache/hadoop/hive/llap/cli/LlapServiceDriver.java 317fa20
> llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/AMReporter.java 6d54fd4
> llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/ContainerRunnerImpl.java 4b28b53
> llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/LlapDaemon.java 98b1ccd
> llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/QueryFileCleaner.java bc18a77
> llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/QueryTracker.java 2db2833
> llap-server/src/java/org/apache/hadoop/hive/llap/daemon/services/impl/LlapWebServices.java 9520413
> llap-server/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskCommunicator.java d327fc0
> llap-server/src/java/org/apache/hadoop/hive/llap/tezplugins/TaskCommunicator.java 33e998c
> llap-server/src/java/org/apache/tez/dag/app/rm/LlapTaskSchedulerService.java e920f86
> llap-server/src/test/org/apache/hadoop/hive/llap/daemon/MiniLlapCluster.java 4525ab9
> llap-server/src/test/org/apache/hadoop/hive/llap/daemon/impl/TestLlapDaemonProtocolServerImpl.java 8d45c95
> llap-server/src/test/org/apache/tez/dag/app/rm/TestLlapTaskSchedulerService.java 23724a4
>
> Diff: https://reviews.apache.org/r/40365/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergey Shelukhin
>
>
Re: Review Request 40365: HIVE-11358 Move LlapConfiguration into
HiveConf and document the settings
Posted by Sergey Shelukhin <se...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40365/
-----------------------------------------------------------
(Updated Dec. 2, 2015, 3:41 a.m.)
Review request for hive, Lefty Leverenz and Siddharth Seth.
Repository: hive-git
Description
-------
see JIRA
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 9e805bd
data/conf/llap/llap-daemon-site.xml f2851a7
llap-client/src/java/org/apache/hadoop/hive/llap/configuration/LlapConfiguration.java bd09024
llap-client/src/java/org/apache/hadoop/hive/llap/registry/impl/LlapFixedRegistryImpl.java 34e0682
llap-client/src/java/org/apache/hadoop/hive/llap/registry/impl/LlapRegistryService.java a8e1465
llap-client/src/java/org/apache/hadoop/hive/llap/registry/impl/LlapYarnRegistryImpl.java d474b6f
llap-server/src/java/org/apache/hadoop/hive/llap/cli/LlapServiceDriver.java 317fa20
llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/AMReporter.java 6d54fd4
llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/ContainerRunnerImpl.java 4b28b53
llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/LlapDaemon.java 98b1ccd
llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/QueryFileCleaner.java bc18a77
llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/QueryTracker.java 2db2833
llap-server/src/java/org/apache/hadoop/hive/llap/daemon/services/impl/LlapWebServices.java 9520413
llap-server/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskCommunicator.java d327fc0
llap-server/src/java/org/apache/hadoop/hive/llap/tezplugins/TaskCommunicator.java 33e998c
llap-server/src/java/org/apache/tez/dag/app/rm/LlapTaskSchedulerService.java e920f86
llap-server/src/test/org/apache/hadoop/hive/llap/daemon/MiniLlapCluster.java 4525ab9
llap-server/src/test/org/apache/hadoop/hive/llap/daemon/impl/TestLlapDaemonProtocolServerImpl.java 8d45c95
llap-server/src/test/org/apache/tez/dag/app/rm/TestLlapTaskSchedulerService.java 23724a4
Diff: https://reviews.apache.org/r/40365/diff/
Testing
-------
Thanks,
Sergey Shelukhin
Re: Review Request 40365: HIVE-11358 Move LlapConfiguration into
HiveConf and document the settings
Posted by Lefty Leverenz <le...@gmail.com>.
> On Dec. 1, 2015, 8:34 a.m., Lefty Leverenz wrote:
> > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java, lines 2460-2470
> > <https://reviews.apache.org/r/40365/diff/3-4/?file=1127596#file1127596line2460>
> >
> > [..].connection.timeout.ms: Is "before" correct in "before a failure" or should it be "Timeout (in milliseconds) after a connection failure ..."?
> >
> > Hm, I must be confused because the next parameter seems to cover that case -- [..].sleep.between.retries.
>
> Lefty Leverenz wrote:
> I still don't understand what the task communicator connection timeout is (or how you'd have a timeout _before_ a failure), but if you're satisfied with the current description then it's okay with me.
Sergey explained in the JIRA comments: "One is the standard connection timeout before we give up and there's a failure, the other is a wait interval before retrying." Now I understand.
- Lefty
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40365/#review108464
-----------------------------------------------------------
On Dec. 2, 2015, 3:41 a.m., Sergey Shelukhin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40365/
> -----------------------------------------------------------
>
> (Updated Dec. 2, 2015, 3:41 a.m.)
>
>
> Review request for hive, Lefty Leverenz and Siddharth Seth.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> see JIRA
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 9e805bd
> data/conf/llap/llap-daemon-site.xml f2851a7
> llap-client/src/java/org/apache/hadoop/hive/llap/configuration/LlapConfiguration.java bd09024
> llap-client/src/java/org/apache/hadoop/hive/llap/registry/impl/LlapFixedRegistryImpl.java 34e0682
> llap-client/src/java/org/apache/hadoop/hive/llap/registry/impl/LlapRegistryService.java a8e1465
> llap-client/src/java/org/apache/hadoop/hive/llap/registry/impl/LlapYarnRegistryImpl.java d474b6f
> llap-server/src/java/org/apache/hadoop/hive/llap/cli/LlapServiceDriver.java 317fa20
> llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/AMReporter.java 6d54fd4
> llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/ContainerRunnerImpl.java 4b28b53
> llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/LlapDaemon.java 98b1ccd
> llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/QueryFileCleaner.java bc18a77
> llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/QueryTracker.java 2db2833
> llap-server/src/java/org/apache/hadoop/hive/llap/daemon/services/impl/LlapWebServices.java 9520413
> llap-server/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskCommunicator.java d327fc0
> llap-server/src/java/org/apache/hadoop/hive/llap/tezplugins/TaskCommunicator.java 33e998c
> llap-server/src/java/org/apache/tez/dag/app/rm/LlapTaskSchedulerService.java e920f86
> llap-server/src/test/org/apache/hadoop/hive/llap/daemon/MiniLlapCluster.java 4525ab9
> llap-server/src/test/org/apache/hadoop/hive/llap/daemon/impl/TestLlapDaemonProtocolServerImpl.java 8d45c95
> llap-server/src/test/org/apache/tez/dag/app/rm/TestLlapTaskSchedulerService.java 23724a4
>
> Diff: https://reviews.apache.org/r/40365/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergey Shelukhin
>
>
Re: Review Request 40365: HIVE-11358 Move LlapConfiguration into
HiveConf and document the settings
Posted by Lefty Leverenz <le...@gmail.com>.
> On Dec. 1, 2015, 8:34 a.m., Lefty Leverenz wrote:
> > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java, lines 2460-2470
> > <https://reviews.apache.org/r/40365/diff/3-4/?file=1127596#file1127596line2460>
> >
> > [..].connection.timeout.ms: Is "before" correct in "before a failure" or should it be "Timeout (in milliseconds) after a connection failure ..."?
> >
> > Hm, I must be confused because the next parameter seems to cover that case -- [..].sleep.between.retries.
I still don't understand what the task communicator connection timeout is (or how you'd have a timeout _before_ a failure), but if you're satisfied with the current description then it's okay with me.
- Lefty
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40365/#review108464
-----------------------------------------------------------
On Dec. 2, 2015, 3:41 a.m., Sergey Shelukhin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40365/
> -----------------------------------------------------------
>
> (Updated Dec. 2, 2015, 3:41 a.m.)
>
>
> Review request for hive, Lefty Leverenz and Siddharth Seth.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> see JIRA
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 9e805bd
> data/conf/llap/llap-daemon-site.xml f2851a7
> llap-client/src/java/org/apache/hadoop/hive/llap/configuration/LlapConfiguration.java bd09024
> llap-client/src/java/org/apache/hadoop/hive/llap/registry/impl/LlapFixedRegistryImpl.java 34e0682
> llap-client/src/java/org/apache/hadoop/hive/llap/registry/impl/LlapRegistryService.java a8e1465
> llap-client/src/java/org/apache/hadoop/hive/llap/registry/impl/LlapYarnRegistryImpl.java d474b6f
> llap-server/src/java/org/apache/hadoop/hive/llap/cli/LlapServiceDriver.java 317fa20
> llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/AMReporter.java 6d54fd4
> llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/ContainerRunnerImpl.java 4b28b53
> llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/LlapDaemon.java 98b1ccd
> llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/QueryFileCleaner.java bc18a77
> llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/QueryTracker.java 2db2833
> llap-server/src/java/org/apache/hadoop/hive/llap/daemon/services/impl/LlapWebServices.java 9520413
> llap-server/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskCommunicator.java d327fc0
> llap-server/src/java/org/apache/hadoop/hive/llap/tezplugins/TaskCommunicator.java 33e998c
> llap-server/src/java/org/apache/tez/dag/app/rm/LlapTaskSchedulerService.java e920f86
> llap-server/src/test/org/apache/hadoop/hive/llap/daemon/MiniLlapCluster.java 4525ab9
> llap-server/src/test/org/apache/hadoop/hive/llap/daemon/impl/TestLlapDaemonProtocolServerImpl.java 8d45c95
> llap-server/src/test/org/apache/tez/dag/app/rm/TestLlapTaskSchedulerService.java 23724a4
>
> Diff: https://reviews.apache.org/r/40365/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergey Shelukhin
>
>
Re: Review Request 40365: HIVE-11358 Move LlapConfiguration into
HiveConf and document the settings
Posted by Lefty Leverenz <le...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40365/#review108464
-----------------------------------------------------------
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java (lines 2442 - 2446)
<https://reviews.apache.org/r/40365/#comment167922>
">0" got dropped -- add it before "indicates a specific bound."
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java (lines 2460 - 2470)
<https://reviews.apache.org/r/40365/#comment167924>
[..].connection.timeout.ms: Is "before" correct in "before a failure" or should it be "Timeout (in milliseconds) after a connection failure ..."?
Hm, I must be confused because the next parameter seems to cover that case -- [..].sleep.between.retries.
- Lefty Leverenz
On Nov. 23, 2015, 9:41 p.m., Sergey Shelukhin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40365/
> -----------------------------------------------------------
>
> (Updated Nov. 23, 2015, 9:41 p.m.)
>
>
> Review request for hive, Lefty Leverenz and Siddharth Seth.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> see JIRA
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java f48403b
> data/conf/llap/llap-daemon-site.xml f2851a7
> llap-client/src/java/org/apache/hadoop/hive/llap/configuration/LlapConfiguration.java bd09024
> llap-client/src/java/org/apache/hadoop/hive/llap/registry/impl/LlapFixedRegistryImpl.java 34e0682
> llap-client/src/java/org/apache/hadoop/hive/llap/registry/impl/LlapRegistryService.java a8e1465
> llap-client/src/java/org/apache/hadoop/hive/llap/registry/impl/LlapYarnRegistryImpl.java d474b6f
> llap-server/src/java/org/apache/hadoop/hive/llap/cli/LlapServiceDriver.java 317fa20
> llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/AMReporter.java 6d54fd4
> llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/ContainerRunnerImpl.java 4b28b53
> llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/LlapDaemon.java 98b1ccd
> llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/QueryFileCleaner.java bc18a77
> llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/QueryTracker.java 2db2833
> llap-server/src/java/org/apache/hadoop/hive/llap/daemon/services/impl/LlapWebServices.java 9520413
> llap-server/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskCommunicator.java d327fc0
> llap-server/src/java/org/apache/hadoop/hive/llap/tezplugins/TaskCommunicator.java 33e998c
> llap-server/src/java/org/apache/tez/dag/app/rm/LlapTaskSchedulerService.java e920f86
> llap-server/src/test/org/apache/hadoop/hive/llap/daemon/MiniLlapCluster.java 4525ab9
> llap-server/src/test/org/apache/hadoop/hive/llap/daemon/impl/TestLlapDaemonProtocolServerImpl.java 8d45c95
> llap-server/src/test/org/apache/tez/dag/app/rm/TestLlapTaskSchedulerService.java 23724a4
>
> Diff: https://reviews.apache.org/r/40365/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergey Shelukhin
>
>
Re: Review Request 40365: HIVE-11358 Move LlapConfiguration into
HiveConf and document the settings
Posted by Sergey Shelukhin <se...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40365/
-----------------------------------------------------------
(Updated Nov. 23, 2015, 9:41 p.m.)
Review request for hive, Lefty Leverenz and Siddharth Seth.
Repository: hive-git
Description
-------
see JIRA
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java f48403b
data/conf/llap/llap-daemon-site.xml f2851a7
llap-client/src/java/org/apache/hadoop/hive/llap/configuration/LlapConfiguration.java bd09024
llap-client/src/java/org/apache/hadoop/hive/llap/registry/impl/LlapFixedRegistryImpl.java 34e0682
llap-client/src/java/org/apache/hadoop/hive/llap/registry/impl/LlapRegistryService.java a8e1465
llap-client/src/java/org/apache/hadoop/hive/llap/registry/impl/LlapYarnRegistryImpl.java d474b6f
llap-server/src/java/org/apache/hadoop/hive/llap/cli/LlapServiceDriver.java 317fa20
llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/AMReporter.java 6d54fd4
llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/ContainerRunnerImpl.java 4b28b53
llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/LlapDaemon.java 98b1ccd
llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/QueryFileCleaner.java bc18a77
llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/QueryTracker.java 2db2833
llap-server/src/java/org/apache/hadoop/hive/llap/daemon/services/impl/LlapWebServices.java 9520413
llap-server/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskCommunicator.java d327fc0
llap-server/src/java/org/apache/hadoop/hive/llap/tezplugins/TaskCommunicator.java 33e998c
llap-server/src/java/org/apache/tez/dag/app/rm/LlapTaskSchedulerService.java e920f86
llap-server/src/test/org/apache/hadoop/hive/llap/daemon/MiniLlapCluster.java 4525ab9
llap-server/src/test/org/apache/hadoop/hive/llap/daemon/impl/TestLlapDaemonProtocolServerImpl.java 8d45c95
llap-server/src/test/org/apache/tez/dag/app/rm/TestLlapTaskSchedulerService.java 23724a4
Diff: https://reviews.apache.org/r/40365/diff/
Testing
-------
Thanks,
Sergey Shelukhin
Re: Review Request 40365: HIVE-11358 Move LlapConfiguration into
HiveConf and document the settings
Posted by Sergey Shelukhin <se...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40365/
-----------------------------------------------------------
(Updated Nov. 16, 2015, 8:59 p.m.)
Review request for hive, Lefty Leverenz and Siddharth Seth.
Repository: hive-git
Description
-------
see JIRA
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 01cd731
llap-client/src/java/org/apache/hadoop/hive/llap/configuration/LlapConfiguration.java bd09024
llap-client/src/java/org/apache/hadoop/hive/llap/registry/impl/LlapFixedRegistryImpl.java 34e0682
llap-client/src/java/org/apache/hadoop/hive/llap/registry/impl/LlapRegistryService.java a8e1465
llap-client/src/java/org/apache/hadoop/hive/llap/registry/impl/LlapYarnRegistryImpl.java d474b6f
llap-server/src/java/org/apache/hadoop/hive/llap/cli/LlapServiceDriver.java 317fa20
llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/AMReporter.java 6d54fd4
llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/ContainerRunnerImpl.java 4b28b53
llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/LlapDaemon.java 98b1ccd
llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/QueryFileCleaner.java bc18a77
llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/QueryTracker.java 2db2833
llap-server/src/java/org/apache/hadoop/hive/llap/daemon/services/impl/LlapWebServices.java 9520413
llap-server/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskCommunicator.java d327fc0
llap-server/src/java/org/apache/hadoop/hive/llap/tezplugins/TaskCommunicator.java 33e998c
llap-server/src/java/org/apache/tez/dag/app/rm/LlapTaskSchedulerService.java e920f86
llap-server/src/test/org/apache/hadoop/hive/llap/daemon/MiniLlapCluster.java 4525ab9
llap-server/src/test/org/apache/hadoop/hive/llap/daemon/impl/TestLlapDaemonProtocolServerImpl.java 8d45c95
llap-server/src/test/org/apache/tez/dag/app/rm/TestLlapTaskSchedulerService.java 23724a4
Diff: https://reviews.apache.org/r/40365/diff/
Testing
-------
Thanks,
Sergey Shelukhin
Re: Review Request 40365: HIVE-11358 Move LlapConfiguration into
HiveConf and document the settings
Posted by Sergey Shelukhin <se...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40365/
-----------------------------------------------------------
(Updated Nov. 16, 2015, 8:30 p.m.)
Review request for hive, Lefty Leverenz and Siddharth Seth.
Repository: hive-git
Description
-------
see JIRA
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 01cd731
llap-client/src/java/org/apache/hadoop/hive/llap/configuration/LlapConfiguration.java bd09024
llap-client/src/java/org/apache/hadoop/hive/llap/registry/impl/LlapFixedRegistryImpl.java 34e0682
llap-client/src/java/org/apache/hadoop/hive/llap/registry/impl/LlapRegistryService.java a8e1465
llap-client/src/java/org/apache/hadoop/hive/llap/registry/impl/LlapYarnRegistryImpl.java d474b6f
llap-server/src/java/org/apache/hadoop/hive/llap/cli/LlapServiceDriver.java 317fa20
llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/AMReporter.java 6d54fd4
llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/ContainerRunnerImpl.java 4b28b53
llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/LlapDaemon.java 98b1ccd
llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/QueryFileCleaner.java bc18a77
llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/QueryTracker.java 2db2833
llap-server/src/java/org/apache/hadoop/hive/llap/daemon/services/impl/LlapWebServices.java 9520413
llap-server/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskCommunicator.java d327fc0
llap-server/src/java/org/apache/hadoop/hive/llap/tezplugins/TaskCommunicator.java 33e998c
llap-server/src/java/org/apache/tez/dag/app/rm/LlapTaskSchedulerService.java e920f86
llap-server/src/test/org/apache/hadoop/hive/llap/daemon/MiniLlapCluster.java 4525ab9
llap-server/src/test/org/apache/hadoop/hive/llap/daemon/impl/TestLlapDaemonProtocolServerImpl.java 8d45c95
llap-server/src/test/org/apache/tez/dag/app/rm/TestLlapTaskSchedulerService.java 23724a4
Diff: https://reviews.apache.org/r/40365/diff/
Testing
-------
Thanks,
Sergey Shelukhin