[GitHub] [iceberg] rdblue commented on a diff in pull request #5407: Core: Add RESTScanReporter to send scan report to REST endpoint

[GitBox <gi...@apache.org>]

rdblue commented on code in PR #5407:
URL: https://github.com/apache/iceberg/pull/5407#discussion_r965294177


##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -770,6 +770,30 @@ paths:
         5XX:
           $ref: '#/components/responses/ServerErrorResponse'
 
+  /v1/{prefix}/namespaces/{namespace}/tables/{table}/metrics/scan:
+    parameters:
+      - $ref: '#/components/parameters/prefix'
+      - $ref: '#/components/parameters/namespace'
+      - $ref: '#/components/parameters/table'
+
+    post:
+      tags:
+        - Catalog API
+      summary: Send a scan report to this endpoint to be processed by the backend
+      description:
+        Send a scan report to this endpoint to be processed by the backend
+      operationId: sendScanReport
+      requestBody:
+        description: The request containing the scan report to be sent
+        content:
+          application/json:
+            schema:
+              $ref: '#/components/schemas/ScanReportRequest'
+        required: true
+      responses:
+        200:

Review Comment:
   I think we still need the 5xx and other responses. I just meant that it is debatable whether the metrics endpoint should ever return a failure that the user was not authenticated. It's unlikely that the caller would do anything about it, right?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org