You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by "hungphan227 (via GitHub)" <gi...@apache.org> on 2023/08/17 10:10:59 UTC
[GitHub] [james-project] hungphan227 opened a new pull request, #1686: DRAFT JAMES-4839 jmap quota for uploads implement a web admin api to update limit of uploads
hungphan227 opened a new pull request, #1686:
URL: https://github.com/apache/james-project/pull/1686
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on a diff in pull request #1686: DRAFT JAMES-4839 jmap quota for uploads implement a web admin api to update limit of uploads
Posted by "chibenwa (via GitHub)" <gi...@apache.org>.
chibenwa commented on code in PR #1686:
URL: https://github.com/apache/james-project/pull/1686#discussion_r1297125326
##########
server/container/guice/protocols/webadmin-mailbox/src/main/java/org/apache/james/modules/server/MailboxRoutesModule.java:
##########
@@ -53,6 +54,7 @@ protected void configure() {
routesMultibinder.addBinding().to(EventDeadLettersRoutes.class);
routesMultibinder.addBinding().to(GlobalQuotaRoutes.class);
routesMultibinder.addBinding().to(UserQuotaRoutes.class);
+ routesMultibinder.addBinding().to(QuotaRoutes.class);
Review Comment:
SHould be located in JMAP guice module.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] hungphan227 closed pull request #1686: DRAFT JAMES-4839 jmap quota for uploads implement a web admin api to update limit of uploads
Posted by "hungphan227 (via GitHub)" <gi...@apache.org>.
hungphan227 closed pull request #1686: DRAFT JAMES-4839 jmap quota for uploads implement a web admin api to update limit of uploads
URL: https://github.com/apache/james-project/pull/1686
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on pull request #1686: DRAFT JAMES-4839 jmap quota for uploads implement a web admin api to update limit of uploads
Posted by "chibenwa (via GitHub)" <gi...@apache.org>.
chibenwa commented on PR #1686:
URL: https://github.com/apache/james-project/pull/1686#issuecomment-1682246164
Ticket number in PR titl and from commits is taken from the ASF JIRA, NOT from github issues.
MUST BE [JAMES-3925](https://issues.apache.org/jira/browse/JAMES-3925)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on a diff in pull request #1686: DRAFT JAMES-4839 jmap quota for uploads implement a web admin api to update limit of uploads
Posted by "chibenwa (via GitHub)" <gi...@apache.org>.
chibenwa commented on code in PR #1686:
URL: https://github.com/apache/james-project/pull/1686#discussion_r1297125878
##########
server/protocols/webadmin/webadmin-mailbox/src/main/java/org/apache/james/webadmin/routes/QuotaRoutes.java:
##########
@@ -0,0 +1,130 @@
+/****************************************************************
+ * Licensed to the Apache Software Foundation (ASF) under one *
+ * or more contributor license agreements. See the NOTICE file *
+ * distributed with this work for additional information *
+ * regarding copyright ownership. The ASF licenses this file *
+ * to you under the Apache License, Version 2.0 (the *
+ * "License"); you may not use this file except in compliance *
+ * with the License. You may obtain a copy of the License at *
+ * *
+ * http://www.apache.org/licenses/LICENSE-2.0 *
+ * *
+ * Unless required by applicable law or agreed to in writing, *
+ * software distributed under the License is distributed on an *
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY *
+ * KIND, either express or implied. See the License for the *
+ * specific language governing permissions and limitations *
+ * under the License. *
+ ****************************************************************/
+
+package org.apache.james.webadmin.routes;
+
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.stream.Collectors;
+
+import javax.inject.Inject;
+
+import org.apache.james.core.quota.QuotaComponent;
+import org.apache.james.core.quota.QuotaLimit;
+import org.apache.james.core.quota.QuotaScope;
+import org.apache.james.core.quota.QuotaType;
+import org.apache.james.webadmin.Routes;
+import org.apache.james.webadmin.service.QuotaService;
+import org.apache.james.webadmin.utils.ErrorResponder;
+import org.apache.james.webadmin.utils.JsonTransformer;
+import org.apache.james.webadmin.utils.Responses;
+import org.eclipse.jetty.http.HttpStatus;
+
+import com.fasterxml.jackson.core.type.TypeReference;
+import com.fasterxml.jackson.databind.JsonMappingException;
+import com.fasterxml.jackson.databind.ObjectMapper;
+import com.fasterxml.jackson.datatype.guava.GuavaModule;
+import com.fasterxml.jackson.datatype.jdk8.Jdk8Module;
+
+import spark.Service;
+
+public class QuotaRoutes implements Routes {
Review Comment:
Should be named "JMAP QuotaRoutes" and should be located in webadmin-jmap
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org