You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/12/06 15:01:38 UTC
[GitHub] [cloudstack] nvazquez opened a new pull request #5752: [VMware] Fix service offerings listing on appliances deployment options
nvazquez opened a new pull request #5752:
URL: https://github.com/apache/cloudstack/pull/5752
### Description
This PR fixes the listing of service offerings on VMware deployment options
<img width="952" alt="Screen Shot 2021-12-06 at 12 00 07" src="https://user-images.githubusercontent.com/5295080/144868897-fcb689d8-f94b-4e83-8a84-053496acc526.png">
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5752: [VMware] Fix service offerings listing on appliances deployment options
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5752:
URL: https://github.com/apache/cloudstack/pull/5752#issuecomment-987839527
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1852
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5752: [VMware] Fix service offerings listing on appliances deployment options
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5752:
URL: https://github.com/apache/cloudstack/pull/5752#issuecomment-987596118
Packaging result: :heavy_multiplication_x: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1847
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5752: [VMware] Fix service offerings listing on appliances deployment options
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5752:
URL: https://github.com/apache/cloudstack/pull/5752#issuecomment-988879807
<b>Trillian test result (tid-2637)</b>
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 34127 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5752-t2637-vmware-67u3.zip
Smoke tests completed. 91 look OK, 0 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5752: [VMware] Fix service offerings listing on appliances deployment options
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5752:
URL: https://github.com/apache/cloudstack/pull/5752#issuecomment-987794885
@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5752: [VMware] Fix service offerings listing on appliances deployment options
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5752:
URL: https://github.com/apache/cloudstack/pull/5752#issuecomment-988500153
@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #5752: [VMware] Fix service offerings listing on appliances deployment options
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #5752:
URL: https://github.com/apache/cloudstack/pull/5752#discussion_r768343767
##########
File path: ui/src/views/compute/wizard/ComputeOfferingSelection.vue
##########
@@ -157,11 +157,11 @@ export default {
(item.iscustomized === true && maxCpuNumber < this.minimumCpunumber))) {
disabled = true
}
- if (disabled === false && this.minimumCpuspeed > 0 && maxCpuSpeed && maxCpuSpeed !== this.minimumCpuspeed) {
+ if (disabled === false && this.minimumCpuspeed > 0 && maxCpuSpeed && maxCpuSpeed < this.minimumCpuspeed) {
disabled = true
}
if (disabled === false && maxMemory && this.minimumMemory > 0 &&
- ((item.iscustomized === false && maxMemory !== this.minimumMemory) ||
+ ((item.iscustomized === false && maxMemory < this.minimumMemory) ||
(item.iscustomized === true && maxMemory < this.minimumMemory))) {
Review comment:
> so,
>
> ?
+1, `maxMemory < this.minimumMemory` should be fine. @nvazquez can you check and update.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5752: [VMware] Fix service offerings listing on appliances deployment options
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5752:
URL: https://github.com/apache/cloudstack/pull/5752#issuecomment-987794573
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5752: [VMware] Fix service offerings listing on appliances deployment options
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5752:
URL: https://github.com/apache/cloudstack/pull/5752#issuecomment-988499964
@blueorangutan test centos7 vmware-67u3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5752: [VMware] Fix service offerings listing on appliances deployment options
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5752:
URL: https://github.com/apache/cloudstack/pull/5752#issuecomment-987558173
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #5752: [VMware] Fix service offerings listing on appliances deployment options
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on a change in pull request #5752:
URL: https://github.com/apache/cloudstack/pull/5752#discussion_r765527143
##########
File path: ui/src/views/compute/wizard/ComputeOfferingSelection.vue
##########
@@ -157,11 +157,11 @@ export default {
(item.iscustomized === true && maxCpuNumber < this.minimumCpunumber))) {
disabled = true
}
- if (disabled === false && this.minimumCpuspeed > 0 && maxCpuSpeed && maxCpuSpeed !== this.minimumCpuspeed) {
+ if (disabled === false && this.minimumCpuspeed > 0 && maxCpuSpeed && maxCpuSpeed < this.minimumCpuspeed) {
disabled = true
}
if (disabled === false && maxMemory && this.minimumMemory > 0 &&
- ((item.iscustomized === false && maxMemory !== this.minimumMemory) ||
+ ((item.iscustomized === false && maxMemory < this.minimumMemory) ||
(item.iscustomized === true && maxMemory < this.minimumMemory))) {
Review comment:
so,
```suggestion
(maxMemory < this.minimumMemory) // && (item.iscustomized === false || item.iscustomised == true)
```
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud merged pull request #5752: [VMware] Fix service offerings listing on appliances deployment options
Posted by GitBox <gi...@apache.org>.
rohityadavcloud merged pull request #5752:
URL: https://github.com/apache/cloudstack/pull/5752
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #5752: [VMware] Fix service offerings listing on appliances deployment options
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5752:
URL: https://github.com/apache/cloudstack/pull/5752#issuecomment-987617455
@nvazquez can you please elaborate what behaviour this PR fixes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5752: [VMware] Fix service offerings listing on appliances deployment options
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5752:
URL: https://github.com/apache/cloudstack/pull/5752#issuecomment-987663424
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5752: [VMware] Fix service offerings listing on appliances deployment options
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5752:
URL: https://github.com/apache/cloudstack/pull/5752#issuecomment-987745372
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 1850
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5752: [VMware] Fix service offerings listing on appliances deployment options
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5752:
URL: https://github.com/apache/cloudstack/pull/5752#issuecomment-987663781
@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5752: [VMware] Fix service offerings listing on appliances deployment options
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5752:
URL: https://github.com/apache/cloudstack/pull/5752#issuecomment-987558555
@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5752: [VMware] Fix service offerings listing on appliances deployment options
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5752:
URL: https://github.com/apache/cloudstack/pull/5752#issuecomment-988469928
@blueorangutan test centos7 vmware-67u3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org