You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/12/17 07:46:15 UTC
[GitHub] [incubator-superset] mistercrunch commented on a change in pull
request #8850: Version number and SHA added to user menu
mistercrunch commented on a change in pull request #8850: Version number and SHA added to user menu
URL: https://github.com/apache/incubator-superset/pull/8850#discussion_r358640574
##########
File path: superset/config.py
##########
@@ -55,7 +55,7 @@
# ---------------------------------------------------------
PACKAGE_DIR = os.path.join(BASE_DIR, "static", "assets")
VERSION_INFO_FILE = os.path.join(PACKAGE_DIR, "version_info.json")
-PACKAGE_JSON_FILE = os.path.join(BASE_DIR, "assets" "package.json")
+PACKAGE_JSON_FILE = os.path.join(BASE_DIR, "assets", "package.json")
Review comment:
Oh wow. Seems like this was probably an issue before. The infamous auto/implicit concat. I'm guessing we probably have packages with a weird `assetspackage.json` filename. Still works but would looks odd.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org