You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/09/26 04:10:40 UTC

[GitHub] [iotdb] ericpai commented on a change in pull request #4034: Cache paths list in batched insert plan

ericpai commented on a change in pull request #4034:
URL: https://github.com/apache/iotdb/pull/4034#discussion_r716136804



##########
File path: cluster/src/main/java/org/apache/iotdb/cluster/metadata/CMManager.java
##########
@@ -563,10 +569,11 @@ public void createSchema(PhysicalPlan plan) throws MetadataException, CheckConsi
 
   private List<PartialPath> getValidStorageGroups(PhysicalPlan plan) {
     List<PartialPath> paths = new ArrayList<>();
-    for (int i = 0; i < plan.getPaths().size(); i++) {
+    List<PartialPath> originalPaths = plan.getPaths();
+    for (int i = 0; i < originalPaths.size(); i++) {

Review comment:
       Here I have some questions about this method. The key of getResults()  is the index of the insertRowPlan, not the path. Is this statement  a bug?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org