You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Sarath Subramanian <sa...@apache.org> on 2019/06/12 08:14:24 UTC
Review Request 70840: ATLAS-3276: Fix stale transactions in atlas due
to ATLAS-3246 (Free-text search)
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70840/
-----------------------------------------------------------
Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, and Madhan Neethiraj.
Bugs: ATLAS-3276
https://issues.apache.org/jira/browse/ATLAS-3276
Repository: atlas
Description
-------
Fix stale transactions in atlas due to ATLAS-3246
Diffs
-----
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphIndexClient.java 4b441bf6d
repository/src/main/java/org/apache/atlas/services/MetricsService.java 8fb68e926
repository/src/main/java/org/apache/atlas/util/AtlasMetricsUtil.java 0c86aff2c
Diff: https://reviews.apache.org/r/70840/diff/1/
Testing
-------
No longer see stale transaction alerts in atlas logs.
Precommit: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1199/console
Thanks,
Sarath Subramanian
Re: Review Request 70840: ATLAS-3276: Fix stale transactions in atlas
due to ATLAS-3246 (Free-text search)
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70840/#review215835
-----------------------------------------------------------
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphIndexClient.java
Lines 181 (patched)
<https://reviews.apache.org/r/70840/#comment302772>
Consider using a try/finally.
repository/src/main/java/org/apache/atlas/services/MetricsService.java
Lines 149 (patched)
<https://reviews.apache.org/r/70840/#comment302771>
Is this commit() needed here, as the caller, getMetrics(), is annotated with @GraphTransaction?
repository/src/main/java/org/apache/atlas/util/AtlasMetricsUtil.java
Lines 163 (patched)
<https://reviews.apache.org/r/70840/#comment302770>
is @GraphTransaction annotation needed here, as commit() is explicitly called in #171 and #177?
repository/src/main/java/org/apache/atlas/util/AtlasMetricsUtil.java
Lines 185 (patched)
<https://reviews.apache.org/r/70840/#comment302769>
is @GraphTransaction annotation needed here, as commit() is explicitly called in #195 and #201?
- Madhan Neethiraj
On June 12, 2019, 8:14 a.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70840/
> -----------------------------------------------------------
>
> (Updated June 12, 2019, 8:14 a.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, and Madhan Neethiraj.
>
>
> Bugs: ATLAS-3276
> https://issues.apache.org/jira/browse/ATLAS-3276
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Fix stale transactions in atlas due to ATLAS-3246
>
>
> Diffs
> -----
>
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphIndexClient.java 4b441bf6d
> repository/src/main/java/org/apache/atlas/services/MetricsService.java 8fb68e926
> repository/src/main/java/org/apache/atlas/util/AtlasMetricsUtil.java 0c86aff2c
>
>
> Diff: https://reviews.apache.org/r/70840/diff/1/
>
>
> Testing
> -------
>
> No longer see stale transaction alerts in atlas logs.
>
> Precommit: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1199/console
>
>
> Thanks,
>
> Sarath Subramanian
>
>
Re: Review Request 70840: ATLAS-3276: Fix stale transactions in atlas
due to ATLAS-3246 (Free-text search)
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70840/#review215889
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On June 12, 2019, 9:04 p.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70840/
> -----------------------------------------------------------
>
> (Updated June 12, 2019, 9:04 p.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, and Madhan Neethiraj.
>
>
> Bugs: ATLAS-3276
> https://issues.apache.org/jira/browse/ATLAS-3276
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Fix stale transactions in atlas due to ATLAS-3246
>
>
> Diffs
> -----
>
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphIndexClient.java 4dd641da7
> repository/src/main/java/org/apache/atlas/services/MetricsService.java 8fb68e926
> repository/src/main/java/org/apache/atlas/util/AtlasMetricsUtil.java 0c86aff2c
>
>
> Diff: https://reviews.apache.org/r/70840/diff/3/
>
>
> Testing
> -------
>
> No longer see stale transaction alerts in atlas logs.
>
> Precommit: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1199/console
>
>
> Thanks,
>
> Sarath Subramanian
>
>
Re: Review Request 70840: ATLAS-3276: Fix stale transactions in atlas
due to ATLAS-3246 (Free-text search)
Posted by Sridhar K <Sr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70840/#review215902
-----------------------------------------------------------
Ship it!
Ship It!
- Sridhar K
On June 13, 2019, 9:08 p.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70840/
> -----------------------------------------------------------
>
> (Updated June 13, 2019, 9:08 p.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, and Madhan Neethiraj.
>
>
> Bugs: ATLAS-3276
> https://issues.apache.org/jira/browse/ATLAS-3276
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Fix stale transactions in atlas due to ATLAS-3246
>
>
> Diffs
> -----
>
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphIndexClient.java 4dd641da7
> repository/src/main/java/org/apache/atlas/services/MetricsService.java 8fb68e926
> repository/src/main/java/org/apache/atlas/util/AtlasMetricsUtil.java 0c86aff2c
>
>
> Diff: https://reviews.apache.org/r/70840/diff/5/
>
>
> Testing
> -------
>
> No longer see stale transaction alerts in atlas logs.
>
> Precommit: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1199/console
>
>
> Thanks,
>
> Sarath Subramanian
>
>
Re: Review Request 70840: ATLAS-3276: Fix stale transactions in atlas
due to ATLAS-3246 (Free-text search)
Posted by Sridhar K <Sr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70840/#review215901
-----------------------------------------------------------
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphIndexClient.java
Lines 289 (patched)
<https://reviews.apache.org/r/70840/#comment302839>
Management could be null.
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphIndexClient.java
Lines 299 (patched)
<https://reviews.apache.org/r/70840/#comment302840>
management could be null.
- Sridhar K
On June 13, 2019, 9:08 p.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70840/
> -----------------------------------------------------------
>
> (Updated June 13, 2019, 9:08 p.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, and Madhan Neethiraj.
>
>
> Bugs: ATLAS-3276
> https://issues.apache.org/jira/browse/ATLAS-3276
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Fix stale transactions in atlas due to ATLAS-3246
>
>
> Diffs
> -----
>
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphIndexClient.java 4dd641da7
> repository/src/main/java/org/apache/atlas/services/MetricsService.java 8fb68e926
> repository/src/main/java/org/apache/atlas/util/AtlasMetricsUtil.java 0c86aff2c
>
>
> Diff: https://reviews.apache.org/r/70840/diff/5/
>
>
> Testing
> -------
>
> No longer see stale transaction alerts in atlas logs.
>
> Precommit: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1199/console
>
>
> Thanks,
>
> Sarath Subramanian
>
>
Re: Review Request 70840: ATLAS-3276: Fix stale transactions in atlas
due to ATLAS-3246 (Free-text search)
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70840/
-----------------------------------------------------------
(Updated June 13, 2019, 2:08 p.m.)
Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, and Madhan Neethiraj.
Changes
-------
addressed review comments.
Bugs: ATLAS-3276
https://issues.apache.org/jira/browse/ATLAS-3276
Repository: atlas
Description
-------
Fix stale transactions in atlas due to ATLAS-3246
Diffs (updated)
-----
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphIndexClient.java 4dd641da7
repository/src/main/java/org/apache/atlas/services/MetricsService.java 8fb68e926
repository/src/main/java/org/apache/atlas/util/AtlasMetricsUtil.java 0c86aff2c
Diff: https://reviews.apache.org/r/70840/diff/4/
Changes: https://reviews.apache.org/r/70840/diff/3-4/
Testing
-------
No longer see stale transaction alerts in atlas logs.
Precommit: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1199/console
Thanks,
Sarath Subramanian
Re: Review Request 70840: ATLAS-3276: Fix stale transactions in atlas
due to ATLAS-3246 (Free-text search)
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70840/#review215886
-----------------------------------------------------------
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphIndexClient.java
Lines 409 (patched)
<https://reviews.apache.org/r/70840/#comment302825>
Shouldn't commit be done only after performRequestHandlerAction() is called?. Same for line #391 as well.
Please review.
repository/src/main/java/org/apache/atlas/util/AtlasMetricsUtil.java
Lines 198 (patched)
<https://reviews.apache.org/r/70840/#comment302823>
Shouldn't graphRollback() be called on exception?
Same for line #198 as well.
- Madhan Neethiraj
On June 12, 2019, 9:04 p.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70840/
> -----------------------------------------------------------
>
> (Updated June 12, 2019, 9:04 p.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, and Madhan Neethiraj.
>
>
> Bugs: ATLAS-3276
> https://issues.apache.org/jira/browse/ATLAS-3276
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Fix stale transactions in atlas due to ATLAS-3246
>
>
> Diffs
> -----
>
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphIndexClient.java 4dd641da7
> repository/src/main/java/org/apache/atlas/services/MetricsService.java 8fb68e926
> repository/src/main/java/org/apache/atlas/util/AtlasMetricsUtil.java 0c86aff2c
>
>
> Diff: https://reviews.apache.org/r/70840/diff/3/
>
>
> Testing
> -------
>
> No longer see stale transaction alerts in atlas logs.
>
> Precommit: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1199/console
>
>
> Thanks,
>
> Sarath Subramanian
>
>
Re: Review Request 70840: ATLAS-3276: Fix stale transactions in atlas
due to ATLAS-3246 (Free-text search)
Posted by Sarath Subramanian <sa...@apache.org>.
> On June 12, 2019, 2:27 p.m., Sridhar K wrote:
> > repository/src/main/java/org/apache/atlas/util/AtlasMetricsUtil.java
> > Line 167 (original), 167 (patched)
> > <https://reviews.apache.org/r/70840/diff/3/?file=2149257#file2149257line167>
> >
> > The API does not match the normal tx api....
> >
> > normally, you would have
> >
> > open tx,
> > do some action,
> > commit or rollback tx.
> >
> > I don't see open in the code....Am I missing some thing?
Transactions are automatically created with the first operation on the graph and closed explicitly using commit() or rollback() - https://docs.janusgraph.org/latest/tx.html
- Sarath
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70840/#review215862
-----------------------------------------------------------
On June 12, 2019, 2:04 p.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70840/
> -----------------------------------------------------------
>
> (Updated June 12, 2019, 2:04 p.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, and Madhan Neethiraj.
>
>
> Bugs: ATLAS-3276
> https://issues.apache.org/jira/browse/ATLAS-3276
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Fix stale transactions in atlas due to ATLAS-3246
>
>
> Diffs
> -----
>
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphIndexClient.java 4dd641da7
> repository/src/main/java/org/apache/atlas/services/MetricsService.java 8fb68e926
> repository/src/main/java/org/apache/atlas/util/AtlasMetricsUtil.java 0c86aff2c
>
>
> Diff: https://reviews.apache.org/r/70840/diff/3/
>
>
> Testing
> -------
>
> No longer see stale transaction alerts in atlas logs.
>
> Precommit: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1199/console
>
>
> Thanks,
>
> Sarath Subramanian
>
>
Re: Review Request 70840: ATLAS-3276: Fix stale transactions in atlas
due to ATLAS-3246 (Free-text search)
Posted by Sridhar K <Sr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70840/#review215862
-----------------------------------------------------------
repository/src/main/java/org/apache/atlas/util/AtlasMetricsUtil.java
Line 167 (original), 167 (patched)
<https://reviews.apache.org/r/70840/#comment302804>
The API does not match the normal tx api....
normally, you would have
open tx,
do some action,
commit or rollback tx.
I don't see open in the code....Am I missing some thing?
- Sridhar K
On June 12, 2019, 9:04 p.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70840/
> -----------------------------------------------------------
>
> (Updated June 12, 2019, 9:04 p.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, and Madhan Neethiraj.
>
>
> Bugs: ATLAS-3276
> https://issues.apache.org/jira/browse/ATLAS-3276
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Fix stale transactions in atlas due to ATLAS-3246
>
>
> Diffs
> -----
>
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphIndexClient.java 4dd641da7
> repository/src/main/java/org/apache/atlas/services/MetricsService.java 8fb68e926
> repository/src/main/java/org/apache/atlas/util/AtlasMetricsUtil.java 0c86aff2c
>
>
> Diff: https://reviews.apache.org/r/70840/diff/3/
>
>
> Testing
> -------
>
> No longer see stale transaction alerts in atlas logs.
>
> Precommit: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1199/console
>
>
> Thanks,
>
> Sarath Subramanian
>
>
Re: Review Request 70840: ATLAS-3276: Fix stale transactions in atlas
due to ATLAS-3246 (Free-text search)
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70840/
-----------------------------------------------------------
(Updated June 12, 2019, 2:04 p.m.)
Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, and Madhan Neethiraj.
Bugs: ATLAS-3276
https://issues.apache.org/jira/browse/ATLAS-3276
Repository: atlas
Description
-------
Fix stale transactions in atlas due to ATLAS-3246
Diffs (updated)
-----
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphIndexClient.java 4dd641da7
repository/src/main/java/org/apache/atlas/services/MetricsService.java 8fb68e926
repository/src/main/java/org/apache/atlas/util/AtlasMetricsUtil.java 0c86aff2c
Diff: https://reviews.apache.org/r/70840/diff/3/
Changes: https://reviews.apache.org/r/70840/diff/2-3/
Testing
-------
No longer see stale transaction alerts in atlas logs.
Precommit: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1199/console
Thanks,
Sarath Subramanian
Re: Review Request 70840: ATLAS-3276: Fix stale transactions in atlas
due to ATLAS-3246 (Free-text search)
Posted by Sarath Subramanian <sa...@apache.org>.
> On June 12, 2019, 1:13 p.m., Madhan Neethiraj wrote:
> > graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphIndexClient.java
> > Line 382 (original), 388 (patched)
> > <https://reviews.apache.org/r/70840/diff/2/?file=2149252#file2149252line389>
> >
> > Consider using try/finally here as well - similar to #195.
> >
> > Same for line #372 as well.
did not want to use try/finally here, since try block might not have multiple exits/exceptions. but added anyways.
- Sarath
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70840/#review215856
-----------------------------------------------------------
On June 12, 2019, 2:04 p.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70840/
> -----------------------------------------------------------
>
> (Updated June 12, 2019, 2:04 p.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, and Madhan Neethiraj.
>
>
> Bugs: ATLAS-3276
> https://issues.apache.org/jira/browse/ATLAS-3276
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Fix stale transactions in atlas due to ATLAS-3246
>
>
> Diffs
> -----
>
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphIndexClient.java 4dd641da7
> repository/src/main/java/org/apache/atlas/services/MetricsService.java 8fb68e926
> repository/src/main/java/org/apache/atlas/util/AtlasMetricsUtil.java 0c86aff2c
>
>
> Diff: https://reviews.apache.org/r/70840/diff/3/
>
>
> Testing
> -------
>
> No longer see stale transaction alerts in atlas logs.
>
> Precommit: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1199/console
>
>
> Thanks,
>
> Sarath Subramanian
>
>
Re: Review Request 70840: ATLAS-3276: Fix stale transactions in atlas
due to ATLAS-3246 (Free-text search)
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70840/#review215856
-----------------------------------------------------------
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphIndexClient.java
Lines 196 (patched)
<https://reviews.apache.org/r/70840/#comment302795>
wrap #198 with try/catch to ignore any error in commit().
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphIndexClient.java
Line 382 (original), 388 (patched)
<https://reviews.apache.org/r/70840/#comment302793>
Consider using try/finally here as well - similar to #195.
Same for line #372 as well.
repository/src/main/java/org/apache/atlas/util/AtlasMetricsUtil.java
Lines 176 (patched)
<https://reviews.apache.org/r/70840/#comment302794>
wrap line #176 with a try/catch, to ignore any errors in commit().
Same for #199 as well.
- Madhan Neethiraj
On June 12, 2019, 8:02 p.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70840/
> -----------------------------------------------------------
>
> (Updated June 12, 2019, 8:02 p.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, and Madhan Neethiraj.
>
>
> Bugs: ATLAS-3276
> https://issues.apache.org/jira/browse/ATLAS-3276
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Fix stale transactions in atlas due to ATLAS-3246
>
>
> Diffs
> -----
>
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphIndexClient.java 4dd641da7
> repository/src/main/java/org/apache/atlas/services/MetricsService.java 8fb68e926
> repository/src/main/java/org/apache/atlas/util/AtlasMetricsUtil.java 0c86aff2c
>
>
> Diff: https://reviews.apache.org/r/70840/diff/2/
>
>
> Testing
> -------
>
> No longer see stale transaction alerts in atlas logs.
>
> Precommit: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1199/console
>
>
> Thanks,
>
> Sarath Subramanian
>
>
Re: Review Request 70840: ATLAS-3276: Fix stale transactions in atlas
due to ATLAS-3246 (Free-text search)
Posted by Sarath Subramanian <sa...@apache.org>.
> On June 12, 2019, 1:32 p.m., Ashutosh Mestry wrote:
> > repository/src/main/java/org/apache/atlas/util/AtlasMetricsUtil.java
> > Lines 176 (patched)
> > <https://reviews.apache.org/r/70840/diff/2/?file=2149254#file2149254line176>
> >
> > Should this be rollback?
Transactions can be terminated manually with commit() or rollback().
> On June 12, 2019, 1:32 p.m., Ashutosh Mestry wrote:
> > repository/src/main/java/org/apache/atlas/util/AtlasMetricsUtil.java
> > Line 182 (original), 188 (patched)
> > <https://reviews.apache.org/r/70840/diff/2/?file=2149254#file2149254line188>
> >
> > In general, if commit is done within catch, it may make sense to have it in finally.
commit is already applied in try block for each runnable thread, moving it to finally() would apply commit() twice which is not desirable.
> On June 12, 2019, 1:32 p.m., Ashutosh Mestry wrote:
> > repository/src/main/java/org/apache/atlas/util/AtlasMetricsUtil.java
> > Lines 199 (patched)
> > <https://reviews.apache.org/r/70840/diff/2/?file=2149254#file2149254line199>
> >
> > Rollback instead of commit?
Transactions can be terminated with commit() or rollback().
- Sarath
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70840/#review215858
-----------------------------------------------------------
On June 12, 2019, 2:04 p.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70840/
> -----------------------------------------------------------
>
> (Updated June 12, 2019, 2:04 p.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, and Madhan Neethiraj.
>
>
> Bugs: ATLAS-3276
> https://issues.apache.org/jira/browse/ATLAS-3276
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Fix stale transactions in atlas due to ATLAS-3246
>
>
> Diffs
> -----
>
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphIndexClient.java 4dd641da7
> repository/src/main/java/org/apache/atlas/services/MetricsService.java 8fb68e926
> repository/src/main/java/org/apache/atlas/util/AtlasMetricsUtil.java 0c86aff2c
>
>
> Diff: https://reviews.apache.org/r/70840/diff/3/
>
>
> Testing
> -------
>
> No longer see stale transaction alerts in atlas logs.
>
> Precommit: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1199/console
>
>
> Thanks,
>
> Sarath Subramanian
>
>
Re: Review Request 70840: ATLAS-3276: Fix stale transactions in atlas
due to ATLAS-3246 (Free-text search)
Posted by Ashutosh Mestry via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70840/#review215858
-----------------------------------------------------------
repository/src/main/java/org/apache/atlas/util/AtlasMetricsUtil.java
Lines 176 (patched)
<https://reviews.apache.org/r/70840/#comment302797>
Should this be rollback?
repository/src/main/java/org/apache/atlas/util/AtlasMetricsUtil.java
Line 182 (original), 188 (patched)
<https://reviews.apache.org/r/70840/#comment302799>
In general, if commit is done within catch, it may make sense to have it in finally.
repository/src/main/java/org/apache/atlas/util/AtlasMetricsUtil.java
Lines 199 (patched)
<https://reviews.apache.org/r/70840/#comment302798>
Rollback instead of commit?
- Ashutosh Mestry
On June 12, 2019, 8:02 p.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70840/
> -----------------------------------------------------------
>
> (Updated June 12, 2019, 8:02 p.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, and Madhan Neethiraj.
>
>
> Bugs: ATLAS-3276
> https://issues.apache.org/jira/browse/ATLAS-3276
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Fix stale transactions in atlas due to ATLAS-3246
>
>
> Diffs
> -----
>
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphIndexClient.java 4dd641da7
> repository/src/main/java/org/apache/atlas/services/MetricsService.java 8fb68e926
> repository/src/main/java/org/apache/atlas/util/AtlasMetricsUtil.java 0c86aff2c
>
>
> Diff: https://reviews.apache.org/r/70840/diff/2/
>
>
> Testing
> -------
>
> No longer see stale transaction alerts in atlas logs.
>
> Precommit: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1199/console
>
>
> Thanks,
>
> Sarath Subramanian
>
>
Re: Review Request 70840: ATLAS-3276: Fix stale transactions in atlas
due to ATLAS-3246 (Free-text search)
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70840/
-----------------------------------------------------------
(Updated June 12, 2019, 1:02 p.m.)
Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, and Madhan Neethiraj.
Changes
-------
addressed review comments.
Bugs: ATLAS-3276
https://issues.apache.org/jira/browse/ATLAS-3276
Repository: atlas
Description
-------
Fix stale transactions in atlas due to ATLAS-3246
Diffs (updated)
-----
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphIndexClient.java 4dd641da7
repository/src/main/java/org/apache/atlas/services/MetricsService.java 8fb68e926
repository/src/main/java/org/apache/atlas/util/AtlasMetricsUtil.java 0c86aff2c
Diff: https://reviews.apache.org/r/70840/diff/2/
Changes: https://reviews.apache.org/r/70840/diff/1-2/
Testing
-------
No longer see stale transaction alerts in atlas logs.
Precommit: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1199/console
Thanks,
Sarath Subramanian