You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "romsharon98 (via GitHub)" <gi...@apache.org> on 2024/10/26 15:29:36 UTC
[PR] Change default value of `namespace` in `task.kubernetes` to be None [airflow]
romsharon98 opened a new pull request, #43402:
URL: https://github.com/apache/airflow/pull/43402
closes: https://github.com/apache/airflow/issues/42957
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Change default value of `namespace` in `task.kubernetes` to be None [airflow]
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on code in PR #43402:
URL: https://github.com/apache/airflow/pull/43402#discussion_r1825774875
##########
providers/src/airflow/providers/cncf/kubernetes/CHANGELOG.rst:
##########
@@ -27,6 +27,13 @@
Changelog
---------
+main
+.....
+
+.. warning::
+ Set the default value of ``namespace`` in _KubernetesDecoratedOperator to ``None``, so it uses the cluster namespace when ``in_cluster`` is True. To retain the previous behavior, set ``namespace="default"``
Review Comment:
Are users aware of this private class? Can we maybe rephrase this to how users use the functionality?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Change default value of `namespace` in `task.kubernetes` to be None [airflow]
Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh commented on code in PR #43402:
URL: https://github.com/apache/airflow/pull/43402#discussion_r1825907286
##########
providers/src/airflow/providers/cncf/kubernetes/CHANGELOG.rst:
##########
@@ -27,6 +27,13 @@
Changelog
---------
+main
+.....
+
+.. warning::
+ Set the default value of ``namespace`` in _KubernetesDecoratedOperator to ``None``, so it uses the cluster namespace when ``in_cluster`` is True. To retain the previous behavior, set ``namespace="default"``
Review Comment:
Right. They shouldnt care about it since it is used by the task operator. Maybe we can add / phrase it better to ask the users to provide the namespace in the operator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Change default value of `namespace` in `task.kubernetes` to be None [airflow]
Posted by "romsharon98 (via GitHub)" <gi...@apache.org>.
romsharon98 merged PR #43402:
URL: https://github.com/apache/airflow/pull/43402
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Change default value of `namespace` in `task.kubernetes` to be None [airflow]
Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh commented on code in PR #43402:
URL: https://github.com/apache/airflow/pull/43402#discussion_r1825425230
##########
providers/src/airflow/providers/cncf/kubernetes/decorators/kubernetes.py:
##########
@@ -65,7 +65,7 @@ class _KubernetesDecoratedOperator(DecoratedOperator, KubernetesPodOperator):
# there are some cases we can't deepcopy the objects (e.g protobuf).
shallow_copy_attrs: Sequence[str] = ("python_callable",)
- def __init__(self, namespace: str = "default", use_dill: bool = False, **kwargs) -> None:
+ def __init__(self, namespace: str | None = None, use_dill: bool = False, **kwargs) -> None:
Review Comment:
Looks like a breaking change to me, it will affect users who do not initialise the decorator namespace right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Change default value of `namespace` in `task.kubernetes` to be None [airflow]
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on code in PR #43402:
URL: https://github.com/apache/airflow/pull/43402#discussion_r1817888152
##########
providers/src/airflow/providers/cncf/kubernetes/decorators/kubernetes.py:
##########
@@ -65,7 +65,7 @@ class _KubernetesDecoratedOperator(DecoratedOperator, KubernetesPodOperator):
# there are some cases we can't deepcopy the objects (e.g protobuf).
shallow_copy_attrs: Sequence[str] = ("python_callable",)
- def __init__(self, namespace: str = "default", use_dill: bool = False, **kwargs) -> None:
+ def __init__(self, namespace: str | None = None, use_dill: bool = False, **kwargs) -> None:
Review Comment:
do we consider this breaking change or a bug fix?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Change default value of `namespace` in `task.kubernetes` to be None [airflow]
Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh commented on code in PR #43402:
URL: https://github.com/apache/airflow/pull/43402#discussion_r1825762581
##########
providers/src/airflow/providers/cncf/kubernetes/decorators/kubernetes.py:
##########
@@ -65,7 +65,7 @@ class _KubernetesDecoratedOperator(DecoratedOperator, KubernetesPodOperator):
# there are some cases we can't deepcopy the objects (e.g protobuf).
shallow_copy_attrs: Sequence[str] = ("python_callable",)
- def __init__(self, namespace: str = "default", use_dill: bool = False, **kwargs) -> None:
+ def __init__(self, namespace: str | None = None, use_dill: bool = False, **kwargs) -> None:
Review Comment:
Thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Change default value of `namespace` in `task.kubernetes` to be None [airflow]
Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh commented on code in PR #43402:
URL: https://github.com/apache/airflow/pull/43402#discussion_r1825763290
##########
providers/src/airflow/providers/cncf/kubernetes/CHANGELOG.rst:
##########
@@ -27,6 +27,13 @@
Changelog
---------
Review Comment:
Is this format correct?
CC @eladkal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Change default value of `namespace` in `task.kubernetes` to be None [airflow]
Posted by "romsharon98 (via GitHub)" <gi...@apache.org>.
romsharon98 commented on code in PR #43402:
URL: https://github.com/apache/airflow/pull/43402#discussion_r1825580844
##########
providers/src/airflow/providers/cncf/kubernetes/decorators/kubernetes.py:
##########
@@ -65,7 +65,7 @@ class _KubernetesDecoratedOperator(DecoratedOperator, KubernetesPodOperator):
# there are some cases we can't deepcopy the objects (e.g protobuf).
shallow_copy_attrs: Sequence[str] = ("python_callable",)
- def __init__(self, namespace: str = "default", use_dill: bool = False, **kwargs) -> None:
+ def __init__(self, namespace: str | None = None, use_dill: bool = False, **kwargs) -> None:
Review Comment:
Added a warning in changelog and bump the provider version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org