You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2023/05/22 20:28:26 UTC
[kudu-CR] [tools] add bound http address into DaemonInfoPB
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19912
Change subject: [tools] add bound_http_address into DaemonInfoPB
......................................................................
[tools] add bound_http_address into DaemonInfoPB
This patch adds bound_http_address field into the DaemonInfoPB message.
The new field will be used by test scenarios in follow-up changelists.
Change-Id: I746876e961a9fe42fb20c72c6ccff4afb3fb7943
---
M src/kudu/tools/tool.proto
M src/kudu/tools/tool_action_test.cc
2 files changed, 9 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/12/19912/1
--
To view, visit http://gerrit.cloudera.org:8080/19912
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I746876e961a9fe42fb20c72c6ccff4afb3fb7943
Gerrit-Change-Number: 19912
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
[kudu-CR] [tools] add bound http address into DaemonInfoPB
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19912 )
Change subject: [tools] add bound_http_address into DaemonInfoPB
......................................................................
[tools] add bound_http_address into DaemonInfoPB
This patch adds bound_http_address field into the DaemonInfoPB message.
The new field will be used by test scenarios in follow-up changelists.
Change-Id: I746876e961a9fe42fb20c72c6ccff4afb3fb7943
Reviewed-on: http://gerrit.cloudera.org:8080/19912
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
---
M src/kudu/tools/tool.proto
M src/kudu/tools/tool_action_test.cc
2 files changed, 9 insertions(+), 4 deletions(-)
Approvals:
Alexey Serbin: Verified
Abhishek Chennaka: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/19912
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I746876e961a9fe42fb20c72c6ccff4afb3fb7943
Gerrit-Change-Number: 19912
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR] [tools] add bound http address into DaemonInfoPB
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [tools] add bound_http_address into DaemonInfoPB
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/19912
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I746876e961a9fe42fb20c72c6ccff4afb3fb7943
Gerrit-Change-Number: 19912
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR] [tools] add bound http address into DaemonInfoPB
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/19912 )
Change subject: [tools] add bound_http_address into DaemonInfoPB
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/19912
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I746876e961a9fe42fb20c72c6ccff4afb3fb7943
Gerrit-Change-Number: 19912
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Tue, 23 May 2023 04:22:08 +0000
Gerrit-HasComments: No
[kudu-CR] [tools] add bound http address into DaemonInfoPB
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/19912 )
Change subject: [tools] add bound_http_address into DaemonInfoPB
......................................................................
Patch Set 1: Code-Review+1
Looks good to me. Please confirm the test failures are unrelated.
--
To view, visit http://gerrit.cloudera.org:8080/19912
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I746876e961a9fe42fb20c72c6ccff4afb3fb7943
Gerrit-Change-Number: 19912
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Tue, 23 May 2023 01:14:58 +0000
Gerrit-HasComments: No
[kudu-CR] [tools] add bound http address into DaemonInfoPB
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19912 )
Change subject: [tools] add bound_http_address into DaemonInfoPB
......................................................................
Patch Set 1: Verified+1
unrelated test failures (DEBUG):
* CatalogManagerConfigurations/MasterStressTest.Test/2 (https://issues.apache.org/jira/browse/KUDU-3481)
* MultiThreadedHybridClockTabletTest/0.UpdateNoMergeCompaction (https://issues.apache.org/jira/browse/KUDU-3285)
F20230522 20:45:47.163322 1908 hms_notification_log_listener.cc:264] Received out-of-order notification log event (last processed event ID: 22): 22 DROP_TABLE default.table_975e93282e3f4e09833880a7c0dd094a
--
To view, visit http://gerrit.cloudera.org:8080/19912
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I746876e961a9fe42fb20c72c6ccff4afb3fb7943
Gerrit-Change-Number: 19912
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Tue, 23 May 2023 02:20:43 +0000
Gerrit-HasComments: No