You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Mark Miller (JIRA)" <ji...@apache.org> on 2013/04/30 23:00:18 UTC
[jira] [Commented] (SOLR-4778) Move LogWatcher initialization code
out of CoreContainer
[ https://issues.apache.org/jira/browse/SOLR-4778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13645977#comment-13645977 ]
Mark Miller commented on SOLR-4778:
-----------------------------------
+1
bq. I'm not convinced we have much coverage here.
I don't think we have tests for this LogWatcher stuff other than manually checking it in the UI do we?
> Move LogWatcher initialization code out of CoreContainer
> --------------------------------------------------------
>
> Key: SOLR-4778
> URL: https://issues.apache.org/jira/browse/SOLR-4778
> Project: Solr
> Issue Type: Improvement
> Reporter: Alan Woodward
> Priority: Minor
> Fix For: 5.0, 4.4
>
> Attachments: SOLR-4778.patch
>
>
> CoreContainer.load is a bit scary. We can simplify it a bit by moving the LogWatcher initialization code into LogWatcher itself, which is where is belongs really.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org