You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@weex.apache.org by sospartan <gi...@git.apache.org> on 2017/03/06 10:13:43 UTC
[GitHub] incubator-weex pull request #40: * [android] fix ConcurrentModificationExcep...
GitHub user sospartan opened a pull request:
https://github.com/apache/incubator-weex/pull/40
* [android] fix ConcurrentModificationException in list sticky map
```
java.util.ConcurrentModificationException
at java.util.HashMap$HashIterator.nextEntry(HashMap.java:806)
at java.util.HashMap$EntryIterator.next(HashMap.java:843)
at java.util.HashMap$EntryIterator.next(HashMap.java:841)
at com.taobao.weex.ui.component.list.BasicListComponent.(BasicListComponent.java:618)
at com.taobao.weex.ui.view.listview.adapter.WXRecyclerViewOnScrollListener.(WXRecyclerViewOnScrollListener.java:270)
at android.support.v7.widget.RecyclerView.(RecyclerView.java:3954)
at android.support.v7.widget.RecyclerView.(RecyclerView.java:3115)
at android.support.v7.widget.RecyclerView.(RecyclerView.java:2917)
```
@YorkShen
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sospartan/incubator-weex 0.11-dev-fix-list-concurrent
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-weex/pull/40.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #40
----
commit 4418c330c1181bb6d0a8de9f9ee8b07e2a335646
Author: sospartan <so...@gmail.com>
Date: 2017-03-06T10:10:34Z
* [android] fix ConcurrentModificationException in list sticky map
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex pull request #40: * [android] fix ConcurrentModificationExcep...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-weex/pull/40
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex issue #40: * [android] fix ConcurrentModificationException in...
Posted by YorkShen <gi...@git.apache.org>.
Github user YorkShen commented on the issue:
https://github.com/apache/incubator-weex/pull/40
OK to merge @sospartan
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-weex issue #40: * [android] fix ConcurrentModificationException in...
Posted by weex-bot <gi...@git.apache.org>.
Github user weex-bot commented on the issue:
https://github.com/apache/incubator-weex/pull/40
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true" data-kind="Warning">
3 Warnings
</th>
</tr>
</thead>
<tbody>
<tr>
<td>:warning:</td>
<td data-sticky="false"><strong><a href="https://github.com/sospartan/incubator-weex/blob/4418c330c1181bb6d0a8de9f9ee8b07e2a335646/ios/sdk/WeexSDKTests/WXStorageTests.m#L123">ios/sdk/WeexSDKTests/WXStorageTests.m#L123</a></strong>: unused variable \u2018tsNow\u2019 [-Wunused-variable] <br /><code>
NSTimeInterval tsNow = [[NSDate date] timeIntervalSince1970];
</code></td>
</tr>
<tr>
<td>:warning:</td>
<td data-sticky="false"><strong><a href="https://github.com/sospartan/incubator-weex/blob/4418c330c1181bb6d0a8de9f9ee8b07e2a335646/ios/sdk/WeexSDKTests/WXStorageTests.m#L227">ios/sdk/WeexSDKTests/WXStorageTests.m#L227</a></strong>: unused variable \u2018tsNow\u2019 [-Wunused-variable] <br /><code>
NSTimeInterval tsNow = [[NSDate date] timeIntervalSince1970];
</code></td>
</tr>
<tr>
<td>:warning:</td>
<td data-sticky="false"><strong><a href="https://github.com/sospartan/incubator-weex/blob/4418c330c1181bb6d0a8de9f9ee8b07e2a335646/ios/sdk/WeexSDKTests/WXStorageTests.m#L228">ios/sdk/WeexSDKTests/WXStorageTests.m#L228</a></strong>: unused variable \u2018ts\u2019 [-Wunused-variable] <br /><code>
NSTimeInterval ts = [infoDic[@"key4"][@"ts"] doubleValue];
</code></td>
</tr>
</tbody>
</table>
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true" data-kind="Message">
1 Message
</th>
</tr>
</thead>
<tbody>
<tr>
<td>:book:</td>
<td data-sticky="false">Executed 53 tests, with 0 failures (0 unexpected) in 67.719 (68.207) seconds</td>
</tr>
</tbody>
</table>
<p align="right" data-meta="generated_by_danger">
Generated by :no_entry_sign: <a href="http://danger.systems/">danger</a>
</p>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---