You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/06/14 02:00:00 UTC

[GitHub] [shardingsphere] cheese8 commented on a diff in pull request #18339: [Issue#18292] Translate into en document according to the cn copy

cheese8 commented on code in PR #18339:
URL: https://github.com/apache/shardingsphere/pull/18339#discussion_r896287653


##########
docs/document/content/reference/encrypt/_index.cn.md:
##########
@@ -29,7 +29,7 @@ Apache ShardingSphere 会将用户请求的明文进行加密后存储到底层
 
 **加密算法配置**:指使用什么加密算法进行加解密。目前 ShardingSphere 内置了五种加解密算法:AES,MD5,RC4,SM3 和 SM4。用户还可以通过实现 ShardingSphere 提供的接口,自行实现一套加解密算法。
 
-**加密表配置**:用于告诉 ShardingSphere 数据表里哪个列用于存储密文数据(cipherColumn)、使用什么算法加解密(encryptorName)、哪个列用于存储辅助查询数据(assistedQueryColumn)、使用什么算法加解密(assistedQueryEncryptorName)、哪个列用于存储明文数据(plainColumn)以及用户想使用哪个列进行 SQL 编写(logicColumn)。
+**加密表配置**:用于告诉 ShardingSphere 数据表里哪个列用于存储密文数据(cipherColumn)、使用什么算法加解密(encryptorName)、哪个列用于存储辅助查询数据(assistedQueryColumn)、使用什么算法对辅助查询数据加解密(assistedQueryEncryptorName)、哪个列用于存储明文数据(plainColumn)以及用户想使用哪个列进行 SQL 编写(logicColumn)。

Review Comment:
   对照`数据表里哪个列用于存储密文数据(cipherColumn)、使用什么算法加解密(encryptorName)`与`哪个列用于存储辅助查询数据(assistedQueryColumn)、使用什么算法加解密(assistedQueryEncryptorName)`,所以这里不是使用算法对辅助查询数据加解密。



##########
docs/document/content/reference/encrypt/_index.en.md:
##########
@@ -35,22 +35,24 @@ The encryption configuration is mainly divided into four parts: data source conf
 **Datasource Configuration**:The configuration of DataSource.
 
 **Encrypt Algorithm Configuration**:What kind of encryption strategy to use for encryption and decryption. 
-Currently ShardingSphere has three built-in encryption/decryption strategies: AES, MD5, RC4. 
+Currently ShardingSphere has five built-in encryption/decryption strategies: AES, MD5, RC4, SM3, SM4. 
 Users can also implement a set of encryption/decryption algorithms by implementing the interface provided by Apache ShardingSphere.
 
 **Encryption Table Configuration**:Show the ShardingSphere data table which column is used to store cipher column data (cipherColumn), 
-which column is used to store plain text data (plainColumn), and which column users want to use for SQL writing (logicColumn)
+what algorithm is used to encryption/decryption (encryptorName), which column is used to store assisted query data (assistedQueryColumn),
+what algorithm is used to encrypt/decrypt assisted query data (assistedQueryColumn),  which column is used to store plain text data (plainColumn), 

Review Comment:
   assistedQueryColumn should be assistedQueryEncryptorName?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org