You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kyuubi.apache.org by GitBox <gi...@apache.org> on 2021/11/04 10:11:32 UTC
[GitHub] [incubator-kyuubi] pan3793 opened a new pull request #1331: [TEST] Refactor test classes to match multi frontend protocol
pan3793 opened a new pull request #1331:
URL: https://github.com/apache/incubator-kyuubi/pull/1331
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/contributions.html
2. If the PR is related to an issue in https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->
### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about the use case of it.
2. If you fix a bug, you can clarify why it is a bug.
-->
As Kyuubi supports RESTful frontend protocol now, and MySQL frontend protocol is coming soon, Thrift is not the only one, this PR refacotor the test classes to match the changes.
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [x] [Run test](https://kyuubi.readthedocs.io/en/latest/develop_tools/testing.html#running-tests) locally before make a pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on pull request #1331: Change term rest to RESTful and refactor test classes to match multi frontend protocol
Posted by GitBox <gi...@apache.org>.
pan3793 commented on pull request #1331:
URL: https://github.com/apache/incubator-kyuubi/pull/1331#issuecomment-961671311
any thoughts? @yaooqinn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1331: [TEST] Refactor test classes to match multi frontend protocol
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1331:
URL: https://github.com/apache/incubator-kyuubi/pull/1331#issuecomment-960894423
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1331?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1331](https://codecov.io/gh/apache/incubator-kyuubi/pull/1331?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f916835) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/8813c4cf9240c4de3c84d2318375d78e718907e3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8813c4c) will **decrease** coverage by `0.01%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head f916835 differs from pull request most recent head 67c6581. Consider uploading reports for the commit 67c6581 to get more accurate results
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1331?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1331 +/- ##
============================================
- Coverage 79.04% 79.02% -0.02%
Complexity 110 110
============================================
Files 179 179
Lines 7491 7491
Branches 916 916
============================================
- Hits 5921 5920 -1
Misses 1081 1081
- Partials 489 490 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1331?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ache/kyuubi/server/KyuubiRestFrontendService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1331/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvS3l1dWJpUmVzdEZyb250ZW5kU2VydmljZS5zY2FsYQ==) | `84.90% <100.00%> (ø)` | |
| [...n/scala/org/apache/kyuubi/engine/ProcBuilder.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1331/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9lbmdpbmUvUHJvY0J1aWxkZXIuc2NhbGE=) | `89.89% <0.00%> (-1.02%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1331?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1331?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [8813c4c...67c6581](https://codecov.io/gh/apache/incubator-kyuubi/pull/1331?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a change in pull request #1331: [TEST] Refactor test classes to match multi frontend protocol
Posted by GitBox <gi...@apache.org>.
pan3793 commented on a change in pull request #1331:
URL: https://github.com/apache/incubator-kyuubi/pull/1331#discussion_r742698387
##########
File path: kyuubi-server/src/main/scala/org/apache/kyuubi/server/RestFrontendService.scala
##########
@@ -33,7 +33,7 @@ import org.apache.kyuubi.service.{AbstractFrontendService, Serverable, Service}
* A frontend service based on RESTful api via HTTP protocol.
* Note: Currently, it only be used in the Kyuubi Server side.
*/
-private[server] class RestFrontendService(override val serverable: Serverable)
+class RestFrontendService(override val serverable: Serverable)
Review comment:
Maybe `RESTfulFrontendService` is a better name? cc @yanghua
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on pull request #1331: [TEST] Refactor test classes to match multi frontend protocol
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #1331:
URL: https://github.com/apache/incubator-kyuubi/pull/1331#issuecomment-961677679
I can not find any supporting evidence from your PR description so I did some research on my own. Some from the best practices of big companies and some from the original author.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1331: [TEST] Refactor test classes to match multi frontend protocol
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1331:
URL: https://github.com/apache/incubator-kyuubi/pull/1331#issuecomment-960894423
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1331?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1331](https://codecov.io/gh/apache/incubator-kyuubi/pull/1331?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2f51b78) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/8813c4cf9240c4de3c84d2318375d78e718907e3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8813c4c) will **decrease** coverage by `0.48%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head 2f51b78 differs from pull request most recent head f916835. Consider uploading reports for the commit f916835 to get more accurate results
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1331?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1331 +/- ##
============================================
- Coverage 79.04% 78.55% -0.49%
Complexity 110 110
============================================
Files 179 179
Lines 7491 7278 -213
Branches 916 891 -25
============================================
- Hits 5921 5717 -204
+ Misses 1081 1075 -6
+ Partials 489 486 -3
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1331?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...org/apache/kyuubi/server/RestFrontendService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1331/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvUmVzdEZyb250ZW5kU2VydmljZS5zY2FsYQ==) | `84.90% <100.00%> (ø)` | |
| [...rg/apache/kyuubi/sql/zorder/ZorderBytesUtils.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1331/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC96b3JkZXIvWm9yZGVyQnl0ZXNVdGlscy5zY2FsYQ==) | `92.66% <0.00%> (-1.75%)` | :arrow_down: |
| [...n/scala/org/apache/kyuubi/engine/ProcBuilder.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1331/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9lbmdpbmUvUHJvY0J1aWxkZXIuc2NhbGE=) | `89.89% <0.00%> (-1.02%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1331?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1331?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [8813c4c...f916835](https://codecov.io/gh/apache/incubator-kyuubi/pull/1331?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1331: Change term rest to RESTful and refactor test classes to match multi frontend protocol
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1331:
URL: https://github.com/apache/incubator-kyuubi/pull/1331#issuecomment-960894423
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on pull request #1331: Change term rest to RESTful and refactor test classes to match multi frontend protocol
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #1331:
URL: https://github.com/apache/incubator-kyuubi/pull/1331#issuecomment-961673572
https://developer.twitter.com/en/docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on pull request #1331: [TEST] Refactor test classes to match multi frontend protocol
Posted by GitBox <gi...@apache.org>.
pan3793 commented on pull request #1331:
URL: https://github.com/apache/incubator-kyuubi/pull/1331#issuecomment-961677295
Reverted the `rest` term related changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter commented on pull request #1331: Change term rest to RESTful and refactor test classes to match multi frontend protocol
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1331:
URL: https://github.com/apache/incubator-kyuubi/pull/1331#issuecomment-960894423
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1331?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1331](https://codecov.io/gh/apache/incubator-kyuubi/pull/1331?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8610721) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/8f3cca9f97ca053f8c9b3936e0e6f7286777a58a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8f3cca9) will **increase** coverage by `0.00%`.
> The diff coverage is `81.81%`.
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1331?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1331 +/- ##
=========================================
Coverage 78.55% 78.55%
Complexity 110 110
=========================================
Files 179 179
Lines 7278 7280 +2
Branches 891 891
=========================================
+ Hits 5717 5719 +2
Misses 1075 1075
Partials 486 486
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1331?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...e/kyuubi/server/KyuubiRESTfulFrontendService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1331/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvS3l1dWJpUkVTVGZ1bEZyb250ZW5kU2VydmljZS5zY2FsYQ==) | `84.90% <70.00%> (ø)` | |
| [...in/scala/org/apache/kyuubi/config/KyuubiConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1331/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jb25maWcvS3l1dWJpQ29uZi5zY2FsYQ==) | `95.26% <91.66%> (+0.01%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1331?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1331?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [8f3cca9...8610721](https://codecov.io/gh/apache/incubator-kyuubi/pull/1331?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on pull request #1331: Change term rest to RESTful and refactor test classes to match multi frontend protocol
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #1331:
URL: https://github.com/apache/incubator-kyuubi/pull/1331#issuecomment-961676527
> Sound like we should change `rest` to `REST`?
the `rest` is ok to me from the given URLs, they are mostly contains lower case `rest`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on pull request #1331: Change term rest to RESTful and refactor test classes to match multi frontend protocol
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #1331:
URL: https://github.com/apache/incubator-kyuubi/pull/1331#issuecomment-961675972
https://www.ics.uci.edu/~fielding/pubs/dissertation/rest_arch_style.htm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on pull request #1331: Change term rest to RESTful and refactor test classes to match multi frontend protocol
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #1331:
URL: https://github.com/apache/incubator-kyuubi/pull/1331#issuecomment-961672960
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on a change in pull request #1331: [TEST] Refactor test classes to match multi frontend protocol
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on a change in pull request #1331:
URL: https://github.com/apache/incubator-kyuubi/pull/1331#discussion_r745270399
##########
File path: kyuubi-common/src/test/scala/org/apache/kyuubi/service/NoopBackendService.scala
##########
@@ -21,6 +21,7 @@ import org.apache.kyuubi.KyuubiException
import org.apache.kyuubi.session.{NoopSessionManager, SessionManager}
class NoopBackendService extends AbstractBackendService("noop") {
+
Review comment:
nit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1331: [TEST] Refactor test classes to match multi frontend protocol
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1331:
URL: https://github.com/apache/incubator-kyuubi/pull/1331#issuecomment-960894423
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1331?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1331](https://codecov.io/gh/apache/incubator-kyuubi/pull/1331?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (67c6581) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/8813c4cf9240c4de3c84d2318375d78e718907e3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8813c4c) will **decrease** coverage by `0.01%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1331?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1331 +/- ##
============================================
- Coverage 79.04% 79.02% -0.02%
Complexity 110 110
============================================
Files 179 179
Lines 7491 7494 +3
Branches 916 917 +1
============================================
+ Hits 5921 5922 +1
- Misses 1081 1082 +1
- Partials 489 490 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1331?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ache/kyuubi/server/KyuubiRestFrontendService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1331/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvS3l1dWJpUmVzdEZyb250ZW5kU2VydmljZS5zY2FsYQ==) | `84.90% <100.00%> (ø)` | |
| [...ain/scala/org/apache/kyuubi/engine/EngineRef.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1331/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9lbmdpbmUvRW5naW5lUmVmLnNjYWxh) | `78.49% <0.00%> (-1.51%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1331?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1331?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [8813c4c...67c6581](https://codecov.io/gh/apache/incubator-kyuubi/pull/1331?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] yanghua commented on a change in pull request #1331: [TEST] Refactor test classes to match multi frontend protocol
Posted by GitBox <gi...@apache.org>.
yanghua commented on a change in pull request #1331:
URL: https://github.com/apache/incubator-kyuubi/pull/1331#discussion_r742762905
##########
File path: kyuubi-server/src/main/scala/org/apache/kyuubi/server/RestFrontendService.scala
##########
@@ -33,7 +33,7 @@ import org.apache.kyuubi.service.{AbstractFrontendService, Serverable, Service}
* A frontend service based on RESTful api via HTTP protocol.
* Note: Currently, it only be used in the Kyuubi Server side.
*/
-private[server] class RestFrontendService(override val serverable: Serverable)
+class RestFrontendService(override val serverable: Serverable)
Review comment:
sounds good. +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1331: Change term rest to RESTful and refactor test classes to match multi frontend protocol
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1331:
URL: https://github.com/apache/incubator-kyuubi/pull/1331#issuecomment-960894423
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1331?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1331](https://codecov.io/gh/apache/incubator-kyuubi/pull/1331?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8610721) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/8f3cca9f97ca053f8c9b3936e0e6f7286777a58a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8f3cca9) will **increase** coverage by `0.00%`.
> The diff coverage is `81.81%`.
> :exclamation: Current head 8610721 differs from pull request most recent head c523e86. Consider uploading reports for the commit c523e86 to get more accurate results
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1331?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1331 +/- ##
=========================================
Coverage 78.55% 78.55%
Complexity 110 110
=========================================
Files 179 179
Lines 7278 7280 +2
Branches 891 891
=========================================
+ Hits 5717 5719 +2
Misses 1075 1075
Partials 486 486
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1331?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...e/kyuubi/server/KyuubiRESTfulFrontendService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1331/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvS3l1dWJpUkVTVGZ1bEZyb250ZW5kU2VydmljZS5zY2FsYQ==) | `84.90% <70.00%> (ø)` | |
| [...in/scala/org/apache/kyuubi/config/KyuubiConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1331/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jb25maWcvS3l1dWJpQ29uZi5zY2FsYQ==) | `95.26% <91.66%> (+0.01%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1331?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1331?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [8f3cca9...c523e86](https://codecov.io/gh/apache/incubator-kyuubi/pull/1331?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a change in pull request #1331: [TEST] Refactor test classes to match multi frontend protocol
Posted by GitBox <gi...@apache.org>.
pan3793 commented on a change in pull request #1331:
URL: https://github.com/apache/incubator-kyuubi/pull/1331#discussion_r742698387
##########
File path: kyuubi-server/src/main/scala/org/apache/kyuubi/server/RestFrontendService.scala
##########
@@ -33,7 +33,7 @@ import org.apache.kyuubi.service.{AbstractFrontendService, Serverable, Service}
* A frontend service based on RESTful api via HTTP protocol.
* Note: Currently, it only be used in the Kyuubi Server side.
*/
-private[server] class RestFrontendService(override val serverable: Serverable)
+class RestFrontendService(override val serverable: Serverable)
Review comment:
Maybe `KyuubiRESTfulFrontendService` is a better name? cc @yanghua
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a change in pull request #1331: [TEST] Refactor test classes to match multi frontend protocol
Posted by GitBox <gi...@apache.org>.
pan3793 commented on a change in pull request #1331:
URL: https://github.com/apache/incubator-kyuubi/pull/1331#discussion_r742697257
##########
File path: kyuubi-server/src/test/scala/org/apache/kyuubi/WithSecuredDFSService.scala
##########
@@ -59,5 +59,5 @@ trait WithSecuredDFSService extends KerberizedTestHelper {
super.afterAll()
}
- def getHadoopConf(): Configuration = miniDFSService.getHadoopConf
+ def getHadoopConf: Configuration = miniDFSService.getHadoopConf
Review comment:
Remove parentheses because the function has no side effect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1331: Change term rest to RESTful and refactor test classes to match multi frontend protocol
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1331:
URL: https://github.com/apache/incubator-kyuubi/pull/1331#issuecomment-960894423
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1331: Change term rest to RESTful and refactor test classes to match multi frontend protocol
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1331:
URL: https://github.com/apache/incubator-kyuubi/pull/1331#issuecomment-960894423
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1331?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1331](https://codecov.io/gh/apache/incubator-kyuubi/pull/1331?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c523e86) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/8f3cca9f97ca053f8c9b3936e0e6f7286777a58a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8f3cca9) will **increase** coverage by `0.00%`.
> The diff coverage is `81.81%`.
> :exclamation: Current head c523e86 differs from pull request most recent head 2f51b78. Consider uploading reports for the commit 2f51b78 to get more accurate results
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1331?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1331 +/- ##
=========================================
Coverage 78.55% 78.55%
Complexity 110 110
=========================================
Files 179 179
Lines 7278 7280 +2
Branches 891 891
=========================================
+ Hits 5717 5719 +2
Misses 1075 1075
Partials 486 486
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1331?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...e/kyuubi/server/KyuubiRESTfulFrontendService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1331/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvS3l1dWJpUkVTVGZ1bEZyb250ZW5kU2VydmljZS5zY2FsYQ==) | `84.90% <70.00%> (ø)` | |
| [...in/scala/org/apache/kyuubi/config/KyuubiConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1331/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jb25maWcvS3l1dWJpQ29uZi5zY2FsYQ==) | `95.26% <91.66%> (+0.01%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1331?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1331?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [8f3cca9...2f51b78](https://codecov.io/gh/apache/incubator-kyuubi/pull/1331?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a change in pull request #1331: [TEST] Refactor test classes to match multi frontend protocol
Posted by GitBox <gi...@apache.org>.
pan3793 commented on a change in pull request #1331:
URL: https://github.com/apache/incubator-kyuubi/pull/1331#discussion_r742697257
##########
File path: kyuubi-server/src/test/scala/org/apache/kyuubi/WithSecuredDFSService.scala
##########
@@ -59,5 +59,5 @@ trait WithSecuredDFSService extends KerberizedTestHelper {
super.afterAll()
}
- def getHadoopConf(): Configuration = miniDFSService.getHadoopConf
+ def getHadoopConf: Configuration = miniDFSService.getHadoopConf
Review comment:
Remove parentheses because the function has no side effects.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] pan3793 closed pull request #1331: [TEST] Refactor test classes to match multi frontend protocol
Posted by GitBox <gi...@apache.org>.
pan3793 closed pull request #1331:
URL: https://github.com/apache/incubator-kyuubi/pull/1331
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on pull request #1331: Change term rest to RESTful and refactor test classes to match multi frontend protocol
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #1331:
URL: https://github.com/apache/incubator-kyuubi/pull/1331#issuecomment-961672960
https://docs.github.com/en/rest
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on pull request #1331: [TEST] Refactor test classes to match multi frontend protocol
Posted by GitBox <gi...@apache.org>.
pan3793 commented on pull request #1331:
URL: https://github.com/apache/incubator-kyuubi/pull/1331#issuecomment-961734744
WDYT other changes of this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on pull request #1331: Change term rest to RESTful and refactor test classes to match multi frontend protocol
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #1331:
URL: https://github.com/apache/incubator-kyuubi/pull/1331#issuecomment-961672960
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on pull request #1331: [TEST] Refactor test classes to match multi frontend protocol
Posted by GitBox <gi...@apache.org>.
pan3793 commented on pull request #1331:
URL: https://github.com/apache/incubator-kyuubi/pull/1331#issuecomment-963830170
Thanks, merging to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on pull request #1331: Change term rest to RESTful and refactor test classes to match multi frontend protocol
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #1331:
URL: https://github.com/apache/incubator-kyuubi/pull/1331#issuecomment-961674119
https://developer.paypal.com/docs/api/overview/#make-rest-api-calls
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on pull request #1331: Change term rest to RESTful and refactor test classes to match multi frontend protocol
Posted by GitBox <gi...@apache.org>.
pan3793 commented on pull request #1331:
URL: https://github.com/apache/incubator-kyuubi/pull/1331#issuecomment-961675747
Sound like we should change `rest` to `REST`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on pull request #1331: Change term rest to RESTful and refactor test classes to match multi frontend protocol
Posted by GitBox <gi...@apache.org>.
pan3793 commented on pull request #1331:
URL: https://github.com/apache/incubator-kyuubi/pull/1331#issuecomment-961671311
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org