You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/07/28 17:25:44 UTC
[GitHub] [ozone] errose28 commented on a change in pull request #2453: HDDS-5485. Add new OM DB tables for AssignUserToTenant
errose28 commented on a change in pull request #2453:
URL: https://github.com/apache/ozone/pull/2453#discussion_r678493268
##########
File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmMetadataManagerImpl.java
##########
@@ -130,10 +132,10 @@
* |----------------------------------------------------------------------|
* | transactionInfoTable| #TRANSACTIONINFO -> OMTransactionInfo |
* |----------------------------------------------------------------------|
- * | tenantUserTable | tenant user name -> a tenant (organization) |
- * | tenantStateTable | tenant user name -> OmDBTenantInfo |
- * | tenantGroupTable | tenant user name -> [tenant group A, B, ...] |
- * | tenantRoleTable | tenant user name -> roles [admin, roleB, ...] |
+ * | tenantAccessIdTable| accessId -> OmTenantAccessIdInfo |
+ * | tenantStateTable | accessId -> OmDBTenantInfo |
+ * | tenantGroupTable | accessId -> [tenant group A, B, ...] |
+ * | tenantRoleTable | accessId -> roles [admin, roleB, ...] |
Review comment:
Nit. New section in the comment block for multi tenant tables, with a line between each table to match formatting in the rest of this block?
##########
File path: hadoop-ozone/interface-storage/src/main/java/org/apache/hadoop/ozone/om/OMMetadataManager.java
##########
@@ -350,6 +351,10 @@ String getMultipartKey(String volume, String bucket, String key, String
Table<String, String> getTenantUserTable();
+ Table<String, OmDBAccessIdInfo> getTenantAccessIdTable();
+
+ Table<String, OmDBAccessIdInfo> getPrincipalToAccessIdsTable();
Review comment:
Should it be OmDBKerberosPrincipalInfo as the value in the table return type?
##########
File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmMetadataManagerImpl.java
##########
@@ -1265,6 +1285,16 @@ private PersistedUserVolumeInfo getVolumesByUser(String userNameKey)
return tenantUserTable;
}
+ @Override
+ public Table<String, OmDBAccessIdInfo> getTenantAccessIdTable() {
+ return tenantAccessIdTable;
+ }
+
+ @Override
+ public Table<String, OmDBAccessIdInfo> getPrincipalToAccessIdsTable() {
Review comment:
Same as above, should be OmDBKerberosPrincipalInfo for the table value?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org