You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "SteNicholas (via GitHub)" <gi...@apache.org> on 2026/04/03 04:48:00 UTC
[PR] [CELEBORN-2298] Introduce NettyTransportBenchmark for Netty transport layer performance evaluation [celeborn]
SteNicholas opened a new pull request, #3647:
URL: https://github.com/apache/celeborn/pull/3647
### What changes were proposed in this pull request?
Introduce `NettyTransportBenchmark` for Netty transport layer performance evaluation.
All suites measure performance through the actual Celeborn transport pipeline
(TransportServer + TransportClientFactory + TransportContext).
Suite overview:
1. RPC Latency - server-client RPC overhead at different payload sizes
2. Concurrent Throughput - multi-client pressure on the transport layer
3. IOMode Comparison - NIO vs native transport (Automatically selects EPOLL/KQUEUE)
4. Server Thread Scaling - validates MAX_DEFAULT_NETTY_THREADS=8 cap
5. Multi-Connection - numConnectionsPerPeer=1 vs 2 vs 4
6. Async Write Pressure - fire-and-forget RPCs to saturate the write path
7. Large Block Transfer - shuffle-like 16MB block transfers (in-memory payload)
8. File-Backed Shuffle - ChunkFetch from disk, NIO vs native transport (EPOLL sendfile bypass detection)
Backport: https://github.com/apache/spark/pull/55061.
### Why are the changes needed?
Netty is a crucial third-party component for Celeborn. Introduce a micro-benchmark test facilitates:
- Verify performance during subsequent Netty upgrades;
- Validate performance after changes to relevant code in Celeborn.
### Does this PR resolve a correctness bug?
No.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Generated `NettyTransportBenchmark-results.txt`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-2298] Introduce NettyTransportBenchmark for Netty transport layer performance evaluation [celeborn]
Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas commented on code in PR #3647:
URL: https://github.com/apache/celeborn/pull/3647#discussion_r3067704393
##########
common/benchmarks/NettyTransportBenchmark-results.txt:
##########
@@ -0,0 +1,123 @@
+================================================================================================
+RPC Round-Trip Latency - 1 KB payload (IOMode=KQUEUE)
+================================================================================================
+
+Java HotSpot(TM) 64-Bit Server VM 1.8.0_202-b08 on Mac OS X 26.3.1
Review Comment:
@pan3793, I have run the netty transport benchmark on Centos with epoll mode. PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-2298] Introduce NettyTransportBenchmark for Netty transport layer performance evaluation [celeborn]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #3647:
URL: https://github.com/apache/celeborn/pull/3647#issuecomment-4228415621
## [Codecov](https://app.codecov.io/gh/apache/celeborn/pull/3647?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `14.28571%` with `6 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 66.95%. Comparing base ([`b4cb5a0`](https://app.codecov.io/gh/apache/celeborn/commit/b4cb5a0b1ac097d33baf8dded1b5be2afd0578a4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c43cadb`](https://app.codecov.io/gh/apache/celeborn/commit/c43cadb0f37403ea921e18492aabd99d1c1a570a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 20 commits behind head on main.
| [Files with missing lines](https://app.codecov.io/gh/apache/celeborn/pull/3647?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...cala/org/apache/celeborn/common/CelebornConf.scala](https://app.codecov.io/gh/apache/celeborn/pull/3647?src=pr&el=tree&filepath=common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fceleborn%2Fcommon%2FCelebornConf.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvY2VsZWJvcm4vY29tbW9uL0NlbGVib3JuQ29uZi5zY2FsYQ==) | 25.00% | [2 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/celeborn/pull/3647?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../common/network/client/TransportClientFactory.java](https://app.codecov.io/gh/apache/celeborn/pull/3647?src=pr&el=tree&filepath=common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fceleborn%2Fcommon%2Fnetwork%2Fclient%2FTransportClientFactory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jZWxlYm9ybi9jb21tb24vbmV0d29yay9jbGllbnQvVHJhbnNwb3J0Q2xpZW50RmFjdG9yeS5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/celeborn/pull/3647?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...pache/celeborn/common/network/util/NettyUtils.java](https://app.codecov.io/gh/apache/celeborn/pull/3647?src=pr&el=tree&filepath=common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fceleborn%2Fcommon%2Fnetwork%2Futil%2FNettyUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jZWxlYm9ybi9jb21tb24vbmV0d29yay91dGlsL05ldHR5VXRpbHMuamF2YQ==) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/celeborn/pull/3647?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #3647 +/- ##
==========================================
+ Coverage 66.91% 66.95% +0.04%
==========================================
Files 358 358
Lines 21986 22006 +20
Branches 1946 1945 -1
==========================================
+ Hits 14710 14731 +21
- Misses 6262 6263 +1
+ Partials 1014 1012 -2
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/celeborn/pull/3647?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-2298] Introduce NettyTransportBenchmark for Netty transport layer performance evaluation [celeborn]
Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas commented on PR #3647:
URL: https://github.com/apache/celeborn/pull/3647#issuecomment-4233543827
Merged to main(v0.7.0).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-2298] Introduce NettyTransportBenchmark for Netty transport layer performance evaluation [celeborn]
Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas commented on PR #3647:
URL: https://github.com/apache/celeborn/pull/3647#issuecomment-4181864657
Ping @RexXiong, @eolivelli.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-2298] Introduce NettyTransportBenchmark for Netty transport layer performance evaluation [celeborn]
Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas commented on PR #3647:
URL: https://github.com/apache/celeborn/pull/3647#issuecomment-4181894219
Ping @RexXiong, @eolivelli.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-2298] Introduce NettyTransportBenchmark for Netty transport layer performance evaluation [celeborn]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #3647:
URL: https://github.com/apache/celeborn/pull/3647#discussion_r3061740412
##########
common/benchmarks/NettyTransportBenchmark-results.txt:
##########
@@ -0,0 +1,123 @@
+================================================================================================
+RPC Round-Trip Latency - 1 KB payload (IOMode=KQUEUE)
+================================================================================================
+
+Java HotSpot(TM) 64-Bit Server VM 1.8.0_202-b08 on Mac OS X 26.3.1
+Apple M4 Pro
Review Comment:
well, the chip looks very powerful
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-2298] Introduce NettyTransportBenchmark for Netty transport layer performance evaluation [celeborn]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #3647:
URL: https://github.com/apache/celeborn/pull/3647#discussion_r3061734516
##########
common/benchmarks/NettyTransportBenchmark-results.txt:
##########
@@ -0,0 +1,123 @@
+================================================================================================
+RPC Round-Trip Latency - 1 KB payload (IOMode=KQUEUE)
+================================================================================================
+
+Java HotSpot(TM) 64-Bit Server VM 1.8.0_202-b08 on Mac OS X 26.3.1
Review Comment:
the JDK version looks too old.
do you have a chance to run it in EPOLL mode? I suppose it's mostly reflects prod use cases
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-2298] Introduce NettyTransportBenchmark for Netty transport layer performance evaluation [celeborn]
Posted by "SteNicholas (via GitHub)" <gi...@apache.org>.
SteNicholas closed pull request #3647: [CELEBORN-2298] Introduce NettyTransportBenchmark for Netty transport layer performance evaluation
URL: https://github.com/apache/celeborn/pull/3647
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org