You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "rusackas (via GitHub)" <gi...@apache.org> on 2026/09/09 21:46:23 UTC

[PR] fix(security): use self-repository syntax for setup-backend in helm workflow [superset]

rusackas opened a new pull request, #44117:
URL: https://github.com/apache/superset/pull/44117

   ### SUMMARY
   zizmor's `self-repository` check flags the relative `./` action reference in
   `.github/workflows/superset-helm-lint-test.yml`'s "Setup Python" step: GitHub
   has a dedicated `$/...` syntax for referencing an action that lives in the
   same repository being checked out, and `./...` is considered an anti-pattern
   here (it works, but doesn't express the self-repo relationship explicitly the
   way `$/...` does). This matches the fix already applied to a sibling `uses:`
   line further down the same file in #44083, and to other workflows in #44040 /
   #44116.
   
   Resolves code-scanning alert #2641
   (https://github.com/apache/superset/security/code-scanning/2641)
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   N/A (CI workflow change, no UI)
   
   ### TESTING INSTRUCTIONS
   - `pre-commit run --files .github/workflows/superset-helm-lint-test.yml`
     passes, including the `zizmor (GHA security audit)` hook, confirming the
     alert no longer fires on this line.
   - The helm lint/test workflow itself is unchanged in behavior; `$/...` and
     `./...` resolve to the same local action path.
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(security): use self-repository syntax for setup-backend in helm workflow [superset]

Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #44117:
URL: https://github.com/apache/superset/pull/44117#issuecomment-5609188227

   AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(security): use self-repository syntax for setup-backend in helm workflow [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas merged PR #44117:
URL: https://github.com/apache/superset/pull/44117


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org