You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ian Downes <ia...@gmail.com> on 2014/05/01 19:18:59 UTC
Review Request 20957: Update Subprocess to use Envp from stout.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20957/
-----------------------------------------------------------
Review request for mesos, Ben Mahler, Jie Yu, and Vinod Kone.
Repository: mesos-git
Description
-------
See 20956.
Diffs
-----
3rdparty/libprocess/src/subprocess.cpp 27a4355a7b94fd08a360e2d182f9cf275b046ce4
Diff: https://reviews.apache.org/r/20957/diff/
Testing
-------
Thanks,
Ian Downes
Re: Review Request 20957: Update Subprocess to use Envp from stout.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20957/#review42389
-----------------------------------------------------------
Bad patch!
Reviews applied: [20956]
Failed command: git apply --index 20956.patch
Error:
error: patch failed: 3rdparty/libprocess/3rdparty/stout/Makefile.am:11
error: 3rdparty/libprocess/3rdparty/stout/Makefile.am: patch does not apply
- Mesos ReviewBot
On May 1, 2014, 5:18 p.m., Ian Downes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20957/
> -----------------------------------------------------------
>
> (Updated May 1, 2014, 5:18 p.m.)
>
>
> Review request for mesos, Ben Mahler, Jie Yu, and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See 20956.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/subprocess.cpp 27a4355a7b94fd08a360e2d182f9cf275b046ce4
>
> Diff: https://reviews.apache.org/r/20957/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ian Downes
>
>
Re: Review Request 20957: Update Subprocess to use Envp from stout.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20957/#review43549
-----------------------------------------------------------
Bad patch!
Reviews applied: [20957]
Failed command: make -j3 distcheck GTEST_FILTER='' >/dev/null
Error:
configure: WARNING: can not find python-boto
-------------------------------------------------------------------
mesos-ec2 services will not function.
-------------------------------------------------------------------
ev.c:1531:31: warning: 'ev_default_loop_ptr' initialized and declared 'extern' [enabled by default]
ev.c: In function 'evpipe_write':
ev.c:2160:17: warning: ignoring return value of 'write', declared with attribute warn_unused_result [-Wunused-result]
ev.c:2172:17: warning: ignoring return value of 'write', declared with attribute warn_unused_result [-Wunused-result]
ev.c: In function 'pipecb':
ev.c:2193:16: warning: ignoring return value of 'read', declared with attribute warn_unused_result [-Wunused-result]
ev.c:2207:16: warning: ignoring return value of 'read', declared with attribute warn_unused_result [-Wunused-result]
In file included from /usr/include/c++/4.6/ext/hash_set:61:0,
from src/glog/stl_logging.h:54,
from src/stl_logging_unittest.cc:34:
/usr/include/c++/4.6/backward/backward_warning.h:33:2: warning: #warning This file includes at least one deprecated or antiquated header which may be removed without further notice at a future date. Please use a non-deprecated interface with equivalent functionality instead. For a listing of replacement headers and interfaces, consult the file backward_warning.h. To disable this warning use -Wno-deprecated. [-Wcpp]
In file included from src/utilities.h:73:0,
from src/googletest.h:38,
from src/stl_logging_unittest.cc:48:
src/base/mutex.h:137:0: warning: "_XOPEN_SOURCE" redefined [enabled by default]
/usr/include/features.h:166:0: note: this is the location of the previous definition
../../../3rdparty/libprocess/src/subprocess.cpp:21:32: fatal error: stout/os/execenv.hpp: No such file or directory
compilation terminated.
make[5]: *** [libprocess_la-subprocess.lo] Error 1
make[5]: *** Waiting for unfinished jobs....
make[4]: *** [all-recursive] Error 1
make[3]: *** [all-recursive] Error 1
make[2]: *** [all] Error 2
make[1]: *** [all-recursive] Error 1
make: *** [distcheck] Error 1
- Mesos ReviewBot
On May 19, 2014, 10:58 p.m., Ian Downes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20957/
> -----------------------------------------------------------
>
> (Updated May 19, 2014, 10:58 p.m.)
>
>
> Review request for mesos, Ben Mahler, Jie Yu, and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See 20956.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/subprocess.cpp 27a4355a7b94fd08a360e2d182f9cf275b046ce4
>
> Diff: https://reviews.apache.org/r/20957/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ian Downes
>
>
Re: Review Request 20957: Update Subprocess to use Envp from stout.
Posted by Ian Downes <ia...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20957/
-----------------------------------------------------------
(Updated May 19, 2014, 3:58 p.m.)
Review request for mesos, Ben Mahler, Jie Yu, and Vinod Kone.
Changes
-------
Rebased.
Repository: mesos-git
Description
-------
See 20956.
Diffs (updated)
-----
3rdparty/libprocess/src/subprocess.cpp 27a4355a7b94fd08a360e2d182f9cf275b046ce4
Diff: https://reviews.apache.org/r/20957/diff/
Testing
-------
Thanks,
Ian Downes
Re: Review Request 20957: Update Subprocess to use Envp from stout.
Posted by Ian Downes <ia...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20957/
-----------------------------------------------------------
(Updated May 16, 2014, 3:06 p.m.)
Review request for mesos, Ben Mahler, Jie Yu, and Vinod Kone.
Changes
-------
Updated to use ExecEnv.
Repository: mesos-git
Description
-------
See 20956.
Diffs (updated)
-----
3rdparty/libprocess/src/subprocess.cpp 27a4355a7b94fd08a360e2d182f9cf275b046ce4
Diff: https://reviews.apache.org/r/20957/diff/
Testing
-------
Thanks,
Ian Downes
Re: Review Request 20957: Update Subprocess to use Envp from stout.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20957/#review42325
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On May 1, 2014, 5:18 p.m., Ian Downes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20957/
> -----------------------------------------------------------
>
> (Updated May 1, 2014, 5:18 p.m.)
>
>
> Review request for mesos, Ben Mahler, Jie Yu, and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See 20956.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/subprocess.cpp 27a4355a7b94fd08a360e2d182f9cf275b046ce4
>
> Diff: https://reviews.apache.org/r/20957/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ian Downes
>
>