[GitHub] [netbeans] jtulach commented on a diff in pull request #5694: JS: Static initializer blocks and "for await ... of ..."

["jtulach (via GitHub)" <gi...@apache.org>]

jtulach commented on code in PR #5694:
URL: https://github.com/apache/netbeans/pull/5694#discussion_r1145372041


##########
webcommon/libs.nashorn/src/com/oracle/js/parser/AbstractParser.java:
##########


Review Comment:
   Wow! Thanks for BCCing me.
   
   > The resulting binary was already part of the release ... now the code is also in the project.
   
   If Apache Foundation is OK with hosting UPL code in its repositories, then I believe this is legally OK move. Go on.
   
   From an engineering perspective: This means NetBeans project is going to host a fork of Graal.js parser. So far NetBeans only relied on a fork of the Graal.js parser created by me. The difference is: now it is going to be easier to add further diverging commits to the fork. That may get us into problems when trying to support new features of JavaScript offered by new versions of Graal.js project.
   
   The original plan always was to change NetBeans JavaScript Editor to work with 21.+ version of Graal.js parser. By maintaining our own fork we are diverging from that goal. Diverging may have some positive effect now, but may hurt us in the future.
   
   Whether such a "divergence" is bad remains to be seen. Moreover it is my personal failure that I haven't managed to convince anyone in OracleLabs (probably @sdedic) to work on reworking the JavaScript support in NetBeans onto new versions of Graal.js. My bad and I have no right to complain.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists