[GitHub] conglei commented on a change in pull request #5865: fixed modal close issue

[GitBox <gi...@apache.org>]

conglei commented on a change in pull request #5865: fixed modal close issue
URL: https://github.com/apache/incubator-superset/pull/5865#discussion_r217152084
 
 

 ##########
 File path: superset/assets/src/components/ModalTrigger.jsx
 ##########
 @@ -82,31 +82,31 @@ export default class ModalTrigger extends React.Component {
       'btn btn-default btn-sm': this.props.isButton,
     });
     if (this.props.isButton) {
-      return (
+      return [
 
 Review comment:
   @williaster Thanks! was reading the article before. and Indeed In think in this case, `<Fragment />` makes more sense. 
   
   > Children in an array must have a key to prevent React’s key warning.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org