You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Mark Wagner <wa...@gmail.com> on 2013/06/04 20:01:01 UTC

Review Request: Initialize object inspectors with union of table properties and partition properties

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11632/
-----------------------------------------------------------

Review request for hive and Ashutosh Chauhan.


Description
-------

Change the initialization of object inspectors and deserializers to use the union of partition properties and table properties for partitioned tables. There is no change for unpartitioned tables.


Diffs
-----

  ql/src/java/org/apache/hadoop/hive/ql/exec/MapOperator.java 9422bf7 
  ql/src/java/org/apache/hadoop/hive/ql/plan/PartitionDesc.java f0b16e4 
  ql/src/test/queries/clientpositive/avro_partitioned.q PRE-CREATION 
  ql/src/test/results/clientpositive/avro_partitioned.q.out PRE-CREATION 

Diff: https://reviews.apache.org/r/11632/diff/


Testing
-------

I've done manual end-to-end testing with various queries/tables and have created a .q test for reading partitioned Avro tables.


Thanks,

Mark Wagner


Re: Review Request: Initialize object inspectors with union of table properties and partition properties

Posted by Ashutosh Chauhan <ha...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11632/#review22081
-----------------------------------------------------------

Ship it!


+1

- Ashutosh Chauhan


On June 4, 2013, 6:01 p.m., Mark Wagner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11632/
> -----------------------------------------------------------
> 
> (Updated June 4, 2013, 6:01 p.m.)
> 
> 
> Review request for hive and Ashutosh Chauhan.
> 
> 
> Description
> -------
> 
> Change the initialization of object inspectors and deserializers to use the union of partition properties and table properties for partitioned tables. There is no change for unpartitioned tables.
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/MapOperator.java 9422bf7 
>   ql/src/java/org/apache/hadoop/hive/ql/plan/PartitionDesc.java f0b16e4 
>   ql/src/test/queries/clientpositive/avro_partitioned.q PRE-CREATION 
>   ql/src/test/results/clientpositive/avro_partitioned.q.out PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/11632/diff/
> 
> 
> Testing
> -------
> 
> I've done manual end-to-end testing with various queries/tables and have created a .q test for reading partitioned Avro tables.
> 
> 
> Thanks,
> 
> Mark Wagner
> 
>