You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by "Hadoop QA (Jira)" <ji...@apache.org> on 2019/09/16 01:34:00 UTC
[jira] [Commented] (PHOENIX-5474) IndexTool should report the
number of rows built
[ https://issues.apache.org/jira/browse/PHOENIX-5474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16930185#comment-16930185 ]
Hadoop QA commented on PHOENIX-5474:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12980356/PHOENIX-5474.master.02.patch
against master branch at commit f83339626ff95cdc025ad7d8b1a1eb8b79fad10b.
ATTACHMENT ID: 12980356
{color:green}+1 @author{color}. The patch does not contain any @author tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings.
{color:red}-1 release audit{color}. The applied patch generated 3 release audit warnings (more than the master's current 0 warnings).
{color:red}-1 lineLengths{color}. The patch introduces the following lines longer than 100:
+ IndexTool indexTool = runIndexTool(directApi, useSnapshot, schemaName, dataTableName, indexTableName, null, 0, new String[0]);
+ assertEquals(NROWS, indexTool.getJob().getCounters().findCounter(INPUT_RECORDS).getValue());
+ long actualRowCount = IndexScrutiny.scrutinizeIndex(conn, dataTableFullName, indexTableFullName);
+ PhoenixMapReduceUtil.setInput(job, PhoenixServerBuildIndexDBWritable.class, PhoenixServerBuildIndexInputFormat.class,
+ ImmutableBytesWritable tmpPtr = new ImmutableBytesWritable(kv.getValueArray(), kv.getValueOffset(), kv.getValueLength());
+ Mapper<NullWritable, PhoenixServerBuildIndexDBWritable, ImmutableBytesWritable, IntWritable> {
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/2959//testReport/
Release audit warnings: https://builds.apache.org/job/PreCommit-PHOENIX-Build/2959//artifact/patchprocess/patchReleaseAuditWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/2959//console
This message is automatically generated.
> IndexTool should report the number of rows built
> ------------------------------------------------
>
> Key: PHOENIX-5474
> URL: https://issues.apache.org/jira/browse/PHOENIX-5474
> Project: Phoenix
> Issue Type: Bug
> Reporter: Kadir OZDEMIR
> Assignee: Kadir OZDEMIR
> Priority: Major
> Fix For: 4.15.0, 5.1.0, 4.14.3
>
> Attachments: PHOENIX-5474.master.01.patch, PHOENIX-5474.master.02.patch
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> In the old design, the IndexTool MR job mapper first scanned the data table rows one by one using a Phoenix client code, then constructed the index rows and finally sent these row mutations to region servers to update the rows on the index table regions. While doing that, it emitted the counters at the row level. In the new design, this entire process is done on the server side (within a coprocessor). So, the mapper just issues one RPC call to instruct the coprocessor to build the entire table region. Thus, currently it does not report the number of rows that have been built, instead it reports the number of table regions built.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)