You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/01/09 09:02:24 UTC

[GitHub] [incubator-mxnet] JiangZhaoh removed a comment on issue #17255: [DO NOT REVIEW]Set np default dtype( float32 <-> float64)

JiangZhaoh removed a comment on issue #17255: [DO NOT REVIEW]Set np default dtype( float32 <-> float64)
URL: https://github.com/apache/incubator-mxnet/pull/17255#issuecomment-572460479
 
 
   > This PR changes so many things and it feels odd. I'm afraid it will cause quite some confusion when people explicitly set the type, change the default and then wonder when it's not being used - the UX wouldn't be great
   Could you please tell me how can I finish this function if I don't change these files? I know some files maybe don't need to change, but I think most of them definitely need to be modified to assure consistency. If you have better idea, please explain it and I'm willing to change my method.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services