[GitHub] [beam] dustin12 commented on a diff in pull request #27609: Fix bug causing elapsed time to be negative

["dustin12 (via GitHub)" <gi...@apache.org>]

dustin12 commented on code in PR #27609:
URL: https://github.com/apache/beam/pull/27609#discussion_r1280986479


##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/StreamingDataflowWorker.java:
##########
@@ -1527,7 +1527,7 @@ public void close() {
       } else {
         LastExceptionDataProvider.reportException(t);
         LOG.debug("Failed work: {}", work);
-        Duration elapsedTimeSinceStart = new Duration(clock.get(), work.getStartTime());
+        Duration elapsedTimeSinceStart = new Duration(work.getStartTime(), clock.get());

Review Comment:
   Do we want to use one of the other Duration methods like Duration.ofSeconds(x)?  This constructor seems kind of confusing.  



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org