You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/01/20 00:06:38 UTC
[GitHub] [kafka] mattwong949 opened a new pull request #11694: MINOR: deleteHorizonMs update to documentation and DumpLogSegments tool
mattwong949 opened a new pull request #11694:
URL: https://github.com/apache/kafka/pull/11694
This PR updates the documentation and tooling to match the changes made in https://github.com/apache/kafka/pull/10914
In the documentation, changes include the adding the new attribute and updating field names.
In the DumpLogSegments tool, when record batch information is printed, it will also include what the value of deleteHorizonMs is ( `OptionalLong.empty` or `OptionalLong[123456] )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mattwong949 commented on a change in pull request #11694: MINOR: deleteHorizonMs update to documentation and DumpLogSegments tool
Posted by GitBox <gi...@apache.org>.
mattwong949 commented on a change in pull request #11694:
URL: https://github.com/apache/kafka/pull/11694#discussion_r791420348
##########
File path: clients/src/main/java/org/apache/kafka/common/record/DefaultRecordBatch.java
##########
@@ -82,9 +82,9 @@
* are retained only until either a new sequence number is written by the corresponding producer or the producerId
* is expired from lack of activity.
*
- * There is no similar need to preserve the timestamp from the original batch after compaction. The FirstTimestamp
+ * There is no similar need to preserve the timestamp from the original batch after compaction. The BaseTimestamp
* field therefore always reflects the timestamp of the first record in the batch. If the batch is empty, the
- * FirstTimestamp will be set to -1 (NO_TIMESTAMP).
+ * BaseTimestamp will be set to -1 (NO_TIMESTAMP).
Review comment:
you are right, I've revised the comments to be accurate about BaseTimestamp after compaction.
##########
File path: clients/src/main/java/org/apache/kafka/common/record/DefaultRecordBatch.java
##########
@@ -82,9 +82,9 @@
* are retained only until either a new sequence number is written by the corresponding producer or the producerId
* is expired from lack of activity.
*
- * There is no similar need to preserve the timestamp from the original batch after compaction. The FirstTimestamp
+ * There is no similar need to preserve the timestamp from the original batch after compaction. The BaseTimestamp
* field therefore always reflects the timestamp of the first record in the batch. If the batch is empty, the
- * FirstTimestamp will be set to -1 (NO_TIMESTAMP).
+ * BaseTimestamp will be set to -1 (NO_TIMESTAMP).
Review comment:
you are right, thanks for the catch. I've revised the comments to be accurate about BaseTimestamp after compaction.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mattwong949 commented on a change in pull request #11694: MINOR: deleteHorizonMs update to documentation and DumpLogSegments tool
Posted by GitBox <gi...@apache.org>.
mattwong949 commented on a change in pull request #11694:
URL: https://github.com/apache/kafka/pull/11694#discussion_r791420348
##########
File path: clients/src/main/java/org/apache/kafka/common/record/DefaultRecordBatch.java
##########
@@ -82,9 +82,9 @@
* are retained only until either a new sequence number is written by the corresponding producer or the producerId
* is expired from lack of activity.
*
- * There is no similar need to preserve the timestamp from the original batch after compaction. The FirstTimestamp
+ * There is no similar need to preserve the timestamp from the original batch after compaction. The BaseTimestamp
* field therefore always reflects the timestamp of the first record in the batch. If the batch is empty, the
- * FirstTimestamp will be set to -1 (NO_TIMESTAMP).
+ * BaseTimestamp will be set to -1 (NO_TIMESTAMP).
Review comment:
you are right, I've revised the comments to be accurate about BaseTimestamp after compaction.
##########
File path: clients/src/main/java/org/apache/kafka/common/record/DefaultRecordBatch.java
##########
@@ -82,9 +82,9 @@
* are retained only until either a new sequence number is written by the corresponding producer or the producerId
* is expired from lack of activity.
*
- * There is no similar need to preserve the timestamp from the original batch after compaction. The FirstTimestamp
+ * There is no similar need to preserve the timestamp from the original batch after compaction. The BaseTimestamp
* field therefore always reflects the timestamp of the first record in the batch. If the batch is empty, the
- * FirstTimestamp will be set to -1 (NO_TIMESTAMP).
+ * BaseTimestamp will be set to -1 (NO_TIMESTAMP).
Review comment:
you are right, thanks for the catch. I've revised the comments to be accurate about BaseTimestamp after compaction.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] hachikuji merged pull request #11694: MINOR: deleteHorizonMs update to documentation and DumpLogSegments tool
Posted by GitBox <gi...@apache.org>.
hachikuji merged pull request #11694:
URL: https://github.com/apache/kafka/pull/11694
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] hachikuji commented on a change in pull request #11694: MINOR: deleteHorizonMs update to documentation and DumpLogSegments tool
Posted by GitBox <gi...@apache.org>.
hachikuji commented on a change in pull request #11694:
URL: https://github.com/apache/kafka/pull/11694#discussion_r790091139
##########
File path: clients/src/main/java/org/apache/kafka/common/record/DefaultRecordBatch.java
##########
@@ -82,9 +82,9 @@
* are retained only until either a new sequence number is written by the corresponding producer or the producerId
* is expired from lack of activity.
*
- * There is no similar need to preserve the timestamp from the original batch after compaction. The FirstTimestamp
+ * There is no similar need to preserve the timestamp from the original batch after compaction. The BaseTimestamp
* field therefore always reflects the timestamp of the first record in the batch. If the batch is empty, the
- * FirstTimestamp will be set to -1 (NO_TIMESTAMP).
+ * BaseTimestamp will be set to -1 (NO_TIMESTAMP).
Review comment:
The comment is still inaccurate, no? The base timestamp does not always reflect the timestamp of the first record in the batch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org