You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2018/02/19 17:47:23 UTC
Review Request 65710: Fixed build with CSI enabled.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65710/
-----------------------------------------------------------
Review request for mesos, Chun-Hung Hsiao and James Peach.
Repository: mesos
Description
-------
This patch adds two required includes to CSI-related tests compiled
only when GRPC is enabled in an autotools build. The compilation of
these files was broken when we cleaned up `src/tests/flags.hpp` in
`f6eb3933798` since their includes were not exhaustive.
Diffs
-----
src/tests/agent_resource_provider_config_api_tests.cpp 046350dcd30efd734018fbc4bd08cc39b6cd686d
src/tests/storage_local_resource_provider_tests.cpp 50130675559a6363363f2f23d00fa45025822213
Diff: https://reviews.apache.org/r/65710/diff/1/
Testing
-------
`make check`
Thanks,
Benjamin Bannier
Re: Review Request 65710: Fixed build with CSI enabled.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65710/#review197761
-----------------------------------------------------------
Patch looks great!
Reviews applied: [65710]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Feb. 19, 2018, 5:47 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65710/
> -----------------------------------------------------------
>
> (Updated Feb. 19, 2018, 5:47 p.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao and James Peach.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds two required includes to CSI-related tests compiled
> only when GRPC is enabled in an autotools build. The compilation of
> these files was broken when we cleaned up `src/tests/flags.hpp` in
> `f6eb3933798` since their includes were not exhaustive.
>
>
> Diffs
> -----
>
> src/tests/agent_resource_provider_config_api_tests.cpp 046350dcd30efd734018fbc4bd08cc39b6cd686d
> src/tests/storage_local_resource_provider_tests.cpp 50130675559a6363363f2f23d00fa45025822213
>
>
> Diff: https://reviews.apache.org/r/65710/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 65710: Fixed build with CSI enabled.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65710/#review197759
-----------------------------------------------------------
PASS: Mesos patch 65710 was successfully built and tested.
Reviews applied: `['65710']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65710
- Mesos Reviewbot Windows
On Feb. 19, 2018, 5:47 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65710/
> -----------------------------------------------------------
>
> (Updated Feb. 19, 2018, 5:47 p.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao and James Peach.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds two required includes to CSI-related tests compiled
> only when GRPC is enabled in an autotools build. The compilation of
> these files was broken when we cleaned up `src/tests/flags.hpp` in
> `f6eb3933798` since their includes were not exhaustive.
>
>
> Diffs
> -----
>
> src/tests/agent_resource_provider_config_api_tests.cpp 046350dcd30efd734018fbc4bd08cc39b6cd686d
> src/tests/storage_local_resource_provider_tests.cpp 50130675559a6363363f2f23d00fa45025822213
>
>
> Diff: https://reviews.apache.org/r/65710/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 65710: Fixed build with CSI enabled.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65710/#review197760
-----------------------------------------------------------
Ship it!
Ship It!
- James Peach
On Feb. 19, 2018, 5:47 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65710/
> -----------------------------------------------------------
>
> (Updated Feb. 19, 2018, 5:47 p.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao and James Peach.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds two required includes to CSI-related tests compiled
> only when GRPC is enabled in an autotools build. The compilation of
> these files was broken when we cleaned up `src/tests/flags.hpp` in
> `f6eb3933798` since their includes were not exhaustive.
>
>
> Diffs
> -----
>
> src/tests/agent_resource_provider_config_api_tests.cpp 046350dcd30efd734018fbc4bd08cc39b6cd686d
> src/tests/storage_local_resource_provider_tests.cpp 50130675559a6363363f2f23d00fa45025822213
>
>
> Diff: https://reviews.apache.org/r/65710/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>