You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by AhyoungRyu <gi...@git.apache.org> on 2015/12/29 06:57:30 UTC
[GitHub] incubator-zeppelin pull request: Fix some typos and grammars in wr...
GitHub user AhyoungRyu opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/578
Fix some typos and grammars in writingzeppelininterpreter.md
### What is this PR for?
I just fixed a few typos and grammars in **writingzeppelininterpreter.md**. And added some markdown codes for increasing readability.
### What type of PR is it?
Improvement
### Todos
* [x] - Fix typos and grammars in writingzeppelininterpreter.md
### Is there a relevant Jira issue?
No : )
### How should this be tested?
Click [here](http://zeppelin.incubator.apache.org/docs/0.6.0-incubating-SNAPSHOT/development/writingzeppelininterpreter.html).
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/AhyoungRyu/incubator-zeppelin Fix-Typo
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/578.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #578
----
commit fba5dda93a6781bd90e88b8c316ff92a72664915
Author: Ryu Ah young <fb...@hanmail.net>
Date: 2015-12-29T05:48:32Z
Fix some typos and grammars in writingzeppelininterpreter.md
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Fix some typos, grammars and Incr...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/578#issuecomment-171183165
@corneadoug @felixcheung I applied the comments : )
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Fix some typos, grammars and Incr...
Posted by AhyoungRyu <gi...@git.apache.org>.
GitHub user AhyoungRyu reopened a pull request:
https://github.com/apache/incubator-zeppelin/pull/578
Fix some typos, grammars and Increase readability documentation
### What is this PR for?
It would be better if Zeppelin provides looking good documentation.
### What type of PR is it?
Improvement
### Todos
* [x] - Fix typos, grammars and Increase readability writingzeppelininterpreter.md
* [x] - Also spark.md
* [x] - tutorial.md
* [x] - cassandra.md
* [x] - elasticsearch.md
* [x] - flink.md
* [x] - hive.md
* [x] - lens.md
* [x] - markdown.md
* [x] - rest-interpreter.md
### Is there a relevant Jira issue?
No : )
### How should this be tested?
These documentations are in [here](http://zeppelin.incubator.apache.org/docs/0.6.0-incubating-SNAPSHOT/).
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/AhyoungRyu/incubator-zeppelin Fix-Typo
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/578.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #578
----
commit fba5dda93a6781bd90e88b8c316ff92a72664915
Author: Ryu Ah young <fb...@hanmail.net>
Date: 2015-12-29T05:48:32Z
Fix some typos and grammars in writingzeppelininterpreter.md
commit c0bc977cd6800b5201826d241aacbde860337f1c
Author: Ryu Ah young <fb...@hanmail.net>
Date: 2015-12-29T06:46:17Z
Add .sh next to .bin/zeppein-daemon
commit f7b410868ce36a7a521faa3e6ce54808783aa98a
Author: Ryu Ah young <fb...@hanmail.net>
Date: 2015-12-29T08:03:40Z
Increase readability and delete useless <br>, <hr> tag spark.md
commit e88eab254e38619f0176cc96d4e325d1b5d1fb88
Author: Ryu Ah young <fb...@hanmail.net>
Date: 2015-12-29T10:04:41Z
Increase readability and delete useless <br> tag tutorial.md
commit a88ba7caa41a5b7a6e4a683a2bd4dd70bc70cd56
Author: Ryu Ah young <fb...@hanmail.net>
Date: 2015-12-30T04:47:58Z
Remove unnecessary space in writingzeppelininterpreter.md
commit f53ac18e53218749931cee541c073d205c768963
Author: Ryu Ah young <fb...@hanmail.net>
Date: 2015-12-30T04:48:56Z
Change rebuild -> rebuilding in spark.md
commit 0da8be607183820fcb26e5d98a79ecd3bea5edae
Author: Ryu Ah young <fb...@hanmail.net>
Date: 2016-01-01T05:59:53Z
Increase readability and Remove useless <br>, <hr> tag cassandra.md
commit bd9f3128ba24a9da8770cb8ae58e3204ac5f4d06
Author: Ryu Ah young <fb...@hanmail.net>
Date: 2016-01-01T06:57:25Z
Increase readability and remove useless <hr> tag elasticsearch.md
commit 9d2da2320f34d75a6c4870c5eec010d47128c09a
Author: Ryu Ah young <fb...@hanmail.net>
Date: 2016-01-01T07:22:29Z
Add highlight for scala code and Increase readability flink.md
commit 0ff3eda8d0f04ac55f8d5a8bd83dce256ce7c778
Author: Ryu Ah young <fb...@hanmail.net>
Date: 2016-01-01T07:53:24Z
Add short description about Apache hive and Increase readability hive.md
commit 511e20de407b16bbbb840443e215ca81bc429784
Author: Ryu Ah young <fb...@hanmail.net>
Date: 2016-01-01T08:29:49Z
Remove numbering flink.md
commit 85ace99cf6631480a0dbc19f255ed5c79c6e4497
Author: Ryu Ah young <fb...@hanmail.net>
Date: 2016-01-01T08:33:19Z
Remove useless 'to' in lens.md
commit 64c2826c4d11d17ed401a395d1b4b710ac6fb719
Author: Ryu Ah young <fb...@hanmail.net>
Date: 2016-01-01T20:28:36Z
Fix image size unit px -> % and Increase readability markdown.md
commit d5571b9a5deb2bbea125c924f06fa04581378195
Author: Ryu Ah young <fb...@hanmail.net>
Date: 2016-01-02T04:05:37Z
Add numbering for dividing the table list and Fix grammar error rest-interpreter.md
commit f01f9ef72ffe12a8814d681186e72796c3a28d02
Author: Ryu Ah young <fb...@hanmail.net>
Date: 2016-01-02T06:55:00Z
Fix grammar error and Increase readability interpreters.md
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Fix some typos, grammars and Incr...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/578#issuecomment-171198503
Honestly, there is too much changes in that PR to properly review all the grammar and sentences.
But I think that overall the changes are good, and people can always fix the docs later :) LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Fix some typos, grammars and Incr...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/578#issuecomment-170793941
@corneadoug but point 2 is code change that someone creating a new interpreter should do, right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Fix some typos, grammars and Incr...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/578#issuecomment-170776132
@corneadoug looks good, I'd only add in 2, instead of a specific line number, could we refer to it as:
Add your interpreter to the `ZEPPELIN_INTERPRETERS()` list in [zeppelin-zengine/src/main/java/org/apache/zeppelin/conf/ZeppelinConfiguration.java](https://github.com/apache/incubator-zeppelin/blob/master/zeppelin-zengine/src/main/java/org/apache/zeppelin/conf/ZeppelinConfiguration.java)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Fix some typos, grammars and Incr...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/578#issuecomment-170785421
@felixcheung I thing its fine in this category since the step before is adding the interpreter under the right folder
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Fix some typos, grammars and Incr...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/578#issuecomment-170798339
Yes, but its more things to do when adding the interpreter to Zeppelin
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Fix some typos, grammars and Incr...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/578
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Fix some typos, grammars and Incr...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/578#issuecomment-170763676
While reviewing this PR, I found out that the **docs/development/writingzeppelininterpreter.md** might not be accurate.
For example, in https://github.com/apache/incubator-zeppelin/blob/master/docs/development/writingzeppelininterpreter.md#configure-your-interpreter
The interpreter should be added to `conf/zeppelin-site.xml.template` only (since conf/zeppelin-site.xml is user configuration)
And the part about default configuration should not be as a 'Note' but as a step to do.
In the end, it should look like this:
### Configure your interpreter
To configure your interpreter you need to follow these steps:
1. Add your interpreter class name to the zeppelin.interpreters property in `conf/zeppelin-site.xml.template`
Property value is comma separated [INTERPRETER_CLASS_NAME].
For example:
```
<property>
<name>zeppelin.interpreters</name>
<value>org.apache.zeppelin.spark.SparkInterpreter,org.apache.zeppelin.spark.PySparkInterpreter,org.apache.zeppelin.spark.SparkSqlInterpreter,org.apache.zeppelin.spark.DepInterpreter,org.apache.zeppelin.markdown.Markdown,org.apache.zeppelin.shell.ShellInterpreter,org.apache.zeppelin.hive.HiveInterpreter,com.me.MyNewInterpreter</value>
</property>
```
2. Add your interpreter to the [default configuration](https://github.com/apache/incubator-zeppelin/blob/master/zeppelin-zengine/src/main/java/org/apache/zeppelin/conf/ZeppelinConfiguration.java#L397) which is used when there is no `zeppelin-site.xml`.
3. Start zeppelin by running ```./bin/zeppelin-deamon start```
4. In the interpreter page, click the `+Create` button and configure your interpreter properties.
Now you are done and ready to use your interpreter.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Fix some typos, grammars and Incr...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/578
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Fix some typos, grammars and Incr...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/578#issuecomment-169854633
So, ready to review : )
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [WIP] Fix some typos, grammars an...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/578#issuecomment-167936393
@HeartSaVioR Thank you for your kind reviewing! I applied the comments that you mentioned.
And I'll commit the rest of TODO.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Fix some typos, grammars and Incr...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/578#issuecomment-170364398
LGTM. Thanks @AhyoungRyu improving docs!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Fix some typos, grammars and Incr...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/578#issuecomment-170776963
... although, shouldn't point 1 & 2 be part of https://github.com/apache/incubator-zeppelin/blob/master/docs/development/writingzeppelininterpreter.md#make-your-own-interpreter instead they should be code changes to include in the PR for the new interpreter?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Fix some typos, grammars and Incr...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/578#issuecomment-169854531
I checked out several docs pages(in the above TODO list), since there are some grammar error or typos or bad alignment. Actually I want to checkout another pages too in this PR, but I saw the other PR which fix same docs pages. So after this PR merged, I will open another PR for them.
So far, below pages also have to be checked.
* [ ] - install.md (a table in this docs is little bit not pretty(?))
* [ ] - table.md
* [ ] - angular.md
* [ ] - notebookashomepage.md
* [ ] - rest-notebook.md
* [ ] - howtocontribute.md
* [ ] - howtocontributewebsite.md
* [ ] - Remove the duplicated section between interpreter.md and writingzeppelininterpreter.md
* [ ] - Divide display.md into text.md & html.md
* [ ] - Divide storage.md into gitstorage.md & s3storage.md
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Fix some typos, grammars and Incr...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/578#issuecomment-172346261
LGTM i'm merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Fix some typos, grammars and Incr...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/578#issuecomment-170643217
@felixcheung
I really appreciate to your prudent review : )
All your comments are make sense, so I applied them.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---