You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/08/25 01:25:02 UTC
[GitHub] [kafka] ableegoldman opened a new pull request #11257: HOTFIX: fix backport of #11248 by future-proofing the EmbeddedKafkaCluster
ableegoldman opened a new pull request #11257:
URL: https://github.com/apache/kafka/pull/11257
A backport of #11248 broke the 2.8 build due to usage of the `EmbeddedKafkaCluster#stop` method, which used to be private. It seems we made this public when we upgraded to JUnit5 on the 3.0 branch and had to remove the ExternalResource that was previously responsible for calling `start()` and `stop()` for this class using the no-longer-available `@ClassRule` annotation.
Rather than adapt this test to the 2.8 style by migrating it to use `@ClassRule` as well, I opted to just make the `stop() method public as well (since its analogue `start()` has always been public anyways). This should hopefully prevent any future backports that include integration tests from having to manually go in and adapt the test, or accidentally break the build as happened here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ableegoldman merged pull request #11257: HOTFIX: fix backport of #11248 by future-proofing the EmbeddedKafkaCluster
Posted by GitBox <gi...@apache.org>.
ableegoldman merged pull request #11257:
URL: https://github.com/apache/kafka/pull/11257
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ableegoldman commented on pull request #11257: HOTFIX: fix backport of #11248 by future-proofing the EmbeddedKafkaCluster
Posted by GitBox <gi...@apache.org>.
ableegoldman commented on pull request #11257:
URL: https://github.com/apache/kafka/pull/11257#issuecomment-905150624
Failures are unrelated are known to be flaky on older branches (`connect.integration.RebalanceSourceConnectorsIntegrationTest.testMultipleWorkersRejoining`) -- will merge to unblock the 2.8 build
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ableegoldman commented on pull request #11257: HOTFIX: fix backport of #11248 by future-proofing the EmbeddedKafkaCluster
Posted by GitBox <gi...@apache.org>.
ableegoldman commented on pull request #11257:
URL: https://github.com/apache/kafka/pull/11257#issuecomment-905096193
@jolshan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org