[GitHub] [incubator-doris] Jibing-Li commented on a diff in pull request #9151: Support hive with HA HDFS. Pass ha configuration through hive create table properties.

[GitBox <gi...@apache.org>]

Jibing-Li commented on code in PR #9151:
URL: https://github.com/apache/incubator-doris/pull/9151#discussion_r859333798


##########
fe/fe-core/src/main/java/org/apache/doris/planner/BrokerScanNode.java:
##########
@@ -522,7 +529,12 @@ private void processFileGroup(
                     rangeDesc.setNumAsString(context.fileGroup.isNumAsString());
                     rangeDesc.setReadJsonByLine(context.fileGroup.isReadJsonByLine());
                 }
-                rangeDesc.setHdfsParams(tHdfsParams);
+                if (rangeDesc.hdfs_params != null && rangeDesc.hdfs_params.getFsName() == null) {

Review Comment:
   The origin code calls rangeDesc.setHdfsParams twice in the if and else block. I don't think we need to add a function for the duplicate code, because it is only used in these two places.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org