You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "Xu-Wentao (via GitHub)" <gi...@apache.org> on 2023/04/21 10:44:34 UTC
[GitHub] [shardingsphere-on-cloud] Xu-Wentao opened a new pull request, #318: perf(pitr): check status of agent servers before do backup
Xu-Wentao opened a new pull request, #318:
URL: https://github.com/apache/shardingsphere-on-cloud/pull/318
<!-- Please answer these questions before submitting a pull request -->
### Type of change:
<!-- Please delete options that are not relevant. -->
- [ ] Bugfix
- [ ] New feature provided
- [x] Improve performance
- [ ] Backport patches
### What this PR does / why we need it:
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->
- check agent servers status before backup to make sure exec backup request will send to agent server successfully.
- cli will print the status of agent servers as a table.
- cli will ping agent server's `/ping` api to check status.
- save `csn` info from exported metadata if csn is not empty.
### Pre-submission checklist:
<!--
Please follow the requirements:
1. Test is required for the feat/fix PR, unless you have a good reason
2. Doc is required for the feat PR
3. Use "request review" to notify the reviewer once you have resolved the review
-->
* [x] Did you explain what problem does this PR solve? Or what new features have been added?
* [ ] Have you added corresponding test cases?
* [ ] Have you modified the corresponding document?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-on-cloud] sonarcloud[bot] commented on pull request #318: perf(pitr): check status of agent servers before do backup
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #318:
URL: https://github.com/apache/shardingsphere-on-cloud/pull/318#issuecomment-1518914929
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_shardingsphere-on-cloud&pullRequest=318)
[](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=318&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=318&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=318&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=318&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=318&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=318&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_shardingsphere-on-cloud&pullRequest=318&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_shardingsphere-on-cloud&pullRequest=318&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_shardingsphere-on-cloud&pullRequest=318&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=318&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=318&resolved=false&types=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=318&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_shardingsphere-on-cloud&pullRequest=318) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_shardingsphere-on-cloud&pullRequest=318&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_shardingsphere-on-cloud&pullRequest=318&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-on-cloud] sonarcloud[bot] commented on pull request #318: perf(pitr): check status of agent servers before do backup
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #318:
URL: https://github.com/apache/shardingsphere-on-cloud/pull/318#issuecomment-1518958972
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_shardingsphere-on-cloud&pullRequest=318)
[](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=318&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=318&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=318&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=318&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=318&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=318&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_shardingsphere-on-cloud&pullRequest=318&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_shardingsphere-on-cloud&pullRequest=318&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_shardingsphere-on-cloud&pullRequest=318&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=318&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=318&resolved=false&types=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=318&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_shardingsphere-on-cloud&pullRequest=318) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_shardingsphere-on-cloud&pullRequest=318&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_shardingsphere-on-cloud&pullRequest=318&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-on-cloud] wbtlb commented on pull request #318: perf(pitr): check status of agent servers before do backup
Posted by "wbtlb (via GitHub)" <gi...@apache.org>.
wbtlb commented on PR #318:
URL: https://github.com/apache/shardingsphere-on-cloud/pull/318#issuecomment-1518959520
approve
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-on-cloud] sonarcloud[bot] commented on pull request #318: perf(pitr): check status of agent servers before do backup
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #318:
URL: https://github.com/apache/shardingsphere-on-cloud/pull/318#issuecomment-1518958740
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_shardingsphere-on-cloud&pullRequest=318)
[](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=318&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=318&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=318&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=318&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=318&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=318&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_shardingsphere-on-cloud&pullRequest=318&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_shardingsphere-on-cloud&pullRequest=318&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_shardingsphere-on-cloud&pullRequest=318&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=318&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=318&resolved=false&types=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=318&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_shardingsphere-on-cloud&pullRequest=318) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_shardingsphere-on-cloud&pullRequest=318&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_shardingsphere-on-cloud&pullRequest=318&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-on-cloud] mlycore merged pull request #318: perf(pitr): check status of agent servers before do backup
Posted by "mlycore (via GitHub)" <gi...@apache.org>.
mlycore merged PR #318:
URL: https://github.com/apache/shardingsphere-on-cloud/pull/318
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-on-cloud] wbtlb commented on a diff in pull request #318: perf(pitr): check status of agent servers before do backup
Posted by "wbtlb (via GitHub)" <gi...@apache.org>.
wbtlb commented on code in PR #318:
URL: https://github.com/apache/shardingsphere-on-cloud/pull/318#discussion_r1174513028
##########
pitr/cli/internal/cmd/backup.go:
##########
@@ -253,6 +257,37 @@ func execBackup(lsBackup *model.LsBackup) error {
return nil
}
+func checkAgentServerStatus(lsBackup *model.LsBackup) bool {
+
+ type Status struct {
Review Comment:
I think move struct definition out of func is better
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-on-cloud] Xu-Wentao commented on a diff in pull request #318: perf(pitr): check status of agent servers before do backup
Posted by "Xu-Wentao (via GitHub)" <gi...@apache.org>.
Xu-Wentao commented on code in PR #318:
URL: https://github.com/apache/shardingsphere-on-cloud/pull/318#discussion_r1174515164
##########
pitr/cli/internal/cmd/backup.go:
##########
@@ -253,6 +257,37 @@ func execBackup(lsBackup *model.LsBackup) error {
return nil
}
+func checkAgentServerStatus(lsBackup *model.LsBackup) bool {
+
+ type Status struct {
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-on-cloud] sonarcloud[bot] commented on pull request #318: perf(pitr): check status of agent servers before do backup
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #318:
URL: https://github.com/apache/shardingsphere-on-cloud/pull/318#issuecomment-1518922178
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_shardingsphere-on-cloud&pullRequest=318)
[](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=318&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=318&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=318&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=318&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=318&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=318&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_shardingsphere-on-cloud&pullRequest=318&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_shardingsphere-on-cloud&pullRequest=318&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_shardingsphere-on-cloud&pullRequest=318&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=318&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=318&resolved=false&types=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache_shardingsphere-on-cloud&pullRequest=318&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_shardingsphere-on-cloud&pullRequest=318) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_shardingsphere-on-cloud&pullRequest=318&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_shardingsphere-on-cloud&pullRequest=318&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-on-cloud] Xu-Wentao commented on a diff in pull request #318: perf(pitr): check status of agent servers before do backup
Posted by "Xu-Wentao (via GitHub)" <gi...@apache.org>.
Xu-Wentao commented on code in PR #318:
URL: https://github.com/apache/shardingsphere-on-cloud/pull/318#discussion_r1174515164
##########
pitr/cli/internal/cmd/backup.go:
##########
@@ -253,6 +257,37 @@ func execBackup(lsBackup *model.LsBackup) error {
return nil
}
+func checkAgentServerStatus(lsBackup *model.LsBackup) bool {
+
+ type Status struct {
Review Comment:
> I think move struct definition out of func is better
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org