You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by kf...@apache.org on 2012/03/08 09:43:46 UTC

svn commit: r1298299 - in /tomcat/tc7.0.x/trunk: java/org/apache/catalina/ha/authenticator/ webapps/docs/

Author: kfujino
Date: Thu Mar  8 08:43:46 2012
New Revision: 1298299

URL: http://svn.apache.org/viewvc?rev=1298299&view=rev
Log:
Replicate Principal in ClusterSingleSignOn.

Modified:
    tomcat/tc7.0.x/trunk/java/org/apache/catalina/ha/authenticator/ClusterSingleSignOn.java
    tomcat/tc7.0.x/trunk/java/org/apache/catalina/ha/authenticator/ClusterSingleSignOnListener.java
    tomcat/tc7.0.x/trunk/java/org/apache/catalina/ha/authenticator/SingleSignOnMessage.java
    tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml

Modified: tomcat/tc7.0.x/trunk/java/org/apache/catalina/ha/authenticator/ClusterSingleSignOn.java
URL: http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/catalina/ha/authenticator/ClusterSingleSignOn.java?rev=1298299&r1=1298298&r2=1298299&view=diff
==============================================================================
--- tomcat/tc7.0.x/trunk/java/org/apache/catalina/ha/authenticator/ClusterSingleSignOn.java (original)
+++ tomcat/tc7.0.x/trunk/java/org/apache/catalina/ha/authenticator/ClusterSingleSignOn.java Thu Mar  8 08:43:46 2012
@@ -31,6 +31,8 @@ import org.apache.catalina.Session;
 import org.apache.catalina.authenticator.SingleSignOn;
 import org.apache.catalina.ha.CatalinaCluster;
 import org.apache.catalina.ha.ClusterManager;
+import org.apache.catalina.ha.session.SerializablePrincipal;
+import org.apache.catalina.realm.GenericPrincipal;
 import org.apache.tomcat.util.ExceptionUtils;
 
 
@@ -318,6 +320,12 @@ public class ClusterSingleSignOn
             msg.setUsername(username);
             msg.setPassword(password);
 
+            SerializablePrincipal sp = null;
+            if (principal instanceof GenericPrincipal) {
+                sp = SerializablePrincipal.createPrincipal((GenericPrincipal) principal);
+                msg.setPrincipal(sp);
+            }
+
             cluster.send(msg);
             if (containerLog.isDebugEnabled())
                 containerLog.debug("SingleSignOnMessage Send with action "
@@ -376,6 +384,12 @@ public class ClusterSingleSignOn
             msg.setUsername(username);
             msg.setPassword(password);
 
+            SerializablePrincipal sp = null;
+            if (principal instanceof GenericPrincipal) {
+                sp = SerializablePrincipal.createPrincipal((GenericPrincipal) principal);
+                msg.setPrincipal(sp);
+            }
+
             cluster.send(msg);
             if (containerLog.isDebugEnabled())
                 containerLog.debug("SingleSignOnMessage Send with action "

Modified: tomcat/tc7.0.x/trunk/java/org/apache/catalina/ha/authenticator/ClusterSingleSignOnListener.java
URL: http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/catalina/ha/authenticator/ClusterSingleSignOnListener.java?rev=1298299&r1=1298298&r2=1298299&view=diff
==============================================================================
--- tomcat/tc7.0.x/trunk/java/org/apache/catalina/ha/authenticator/ClusterSingleSignOnListener.java (original)
+++ tomcat/tc7.0.x/trunk/java/org/apache/catalina/ha/authenticator/ClusterSingleSignOnListener.java Thu Mar  8 08:43:46 2012
@@ -18,6 +18,7 @@
 package org.apache.catalina.ha.authenticator;
 
 import java.io.IOException;
+import java.security.Principal;
 import java.util.Map;
 
 import org.apache.catalina.Session;
@@ -90,6 +91,7 @@ public class ClusterSingleSignOnListener
             SingleSignOnMessage msg = (SingleSignOnMessage) myobj;
             int action = msg.getAction();
             Session session = null;
+            Principal principal = null;
 
             if (log.isDebugEnabled())
                 log.debug("SingleSignOnMessage Received with action "
@@ -112,11 +114,17 @@ public class ClusterSingleSignOnListener
                 clusterSSO.deregisterLocal(msg.getSsoId());
                 break;
             case SingleSignOnMessage.REGISTER_SESSION:
-                clusterSSO.registerLocal(msg.getSsoId(), null, msg.getAuthType(),
+                if (msg.getPrincipal() != null) {
+                    principal = msg.getPrincipal().getPrincipal();
+                }
+                clusterSSO.registerLocal(msg.getSsoId(), principal, msg.getAuthType(),
                                          msg.getUsername(), msg.getPassword());
                 break;
             case SingleSignOnMessage.UPDATE_SESSION:
-                clusterSSO.updateLocal(msg.getSsoId(), null, msg.getAuthType(),
+                if (msg.getPrincipal() != null) {
+                    principal = msg.getPrincipal().getPrincipal();
+                }
+                clusterSSO.updateLocal(msg.getSsoId(), principal, msg.getAuthType(),
                                        msg.getUsername(), msg.getPassword());
                 break;
             case SingleSignOnMessage.REMOVE_SESSION:

Modified: tomcat/tc7.0.x/trunk/java/org/apache/catalina/ha/authenticator/SingleSignOnMessage.java
URL: http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/catalina/ha/authenticator/SingleSignOnMessage.java?rev=1298299&r1=1298298&r2=1298299&view=diff
==============================================================================
--- tomcat/tc7.0.x/trunk/java/org/apache/catalina/ha/authenticator/SingleSignOnMessage.java (original)
+++ tomcat/tc7.0.x/trunk/java/org/apache/catalina/ha/authenticator/SingleSignOnMessage.java Thu Mar  8 08:43:46 2012
@@ -18,6 +18,7 @@
 package org.apache.catalina.ha.authenticator;
 
 import org.apache.catalina.ha.ClusterMessage;
+import org.apache.catalina.ha.session.SerializablePrincipal;
 import org.apache.catalina.tribes.Member;
 
 /**
@@ -43,6 +44,7 @@ public class SingleSignOnMessage impleme
     private String authType = null;
     private String password = null;
     private String username = null;
+    private SerializablePrincipal principal = null;
 
     private Member address = null;
     private long timestamp = 0;
@@ -175,6 +177,13 @@ public class SingleSignOnMessage impleme
         this.username = username;
     }
 
+    public SerializablePrincipal getPrincipal() {
+        return principal;
+    }
+
+    public void setPrincipal(SerializablePrincipal principal) {
+        this.principal = principal;
+    }
 
     // --------------------------------------------------------- Public Methods
 

Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml
URL: http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml?rev=1298299&r1=1298298&r2=1298299&view=diff
==============================================================================
--- tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml Thu Mar  8 08:43:46 2012
@@ -118,6 +118,13 @@
       </fix>
     </changelog>
   </subsection>
+  <subsection name="Cluster">
+    <changelog>
+      <fix>
+        Replicate principal in ClusterSingleSignOn. (kfujino)
+      </fix>
+    </changelog>
+  </subsection>
   <subsection name="Web applications">
     <changelog>
       <fix>



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org