[GitHub] [superset] hughhhh commented on pull request #23868: fix: move dynamic schema out of base Postgres class

["hughhhh (via GitHub)" <gi...@apache.org>]

hughhhh commented on PR #23868:
URL: https://github.com/apache/superset/pull/23868#issuecomment-1528174249

   > @hughhhh or @betodealmeida Netezza, snowflake, hana and vertica also are based from the `PostgresBaseEngineSpec`. Have we tested how this change impacts those dbs?
   
   this is basically a revert on what current functionality, instead of having `supports_dynamic_schema = True` in the base class instead we moved this functionality to live only in the specific engine specs [snowflake example](https://github.com/apache/superset/blob/8d14420d14e572d9101d772e06c5d980f55502b2/superset/db_engine_specs/snowflake.py#L87)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org