[GitHub] [superset] eschutho commented on pull request #22405: fix(sqla): copy temporal range logic to helper

[GitBox <gi...@apache.org>]

eschutho commented on PR #22405:
URL: https://github.com/apache/superset/pull/22405#issuecomment-1349568266

   HI @villebro. Thanks for flagging this. Yes, @hughhhh will be working on removing the code duplication in the next few weeks. The original plan was to incorporate SIP68 work here and remove the sqlaTable and migrate the tables and columns over to the new SIP68 models and at the same time use the new mixin, but we decided not to allow charts to be created by tables and columns and the new dataset models and now we need to dig right into sqlaTable instead. But the plan moving forward is to use the exploreMixin and clean up the sqlaTable code during the process of moving the code over. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org