You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/07/28 17:42:10 UTC
[GitHub] [superset] michael-s-molina opened a new pull request #15929: chore: Changes the main menu order as defined in SIP-34
michael-s-molina opened a new pull request #15929:
URL: https://github.com/apache/superset/pull/15929
### SUMMARY
This PR is a follow-up of https://github.com/apache/superset/pull/15915 where we discussed the possibility of ordering the main menu items according to user workflows or usage. We decided to change the main menu order as defined in [SIP-34](https://github.com/apache/superset/issues/8976).
The order defined was Dashboards -> Charts -> SQL Lab -> Data as you can see in the following screenshot from [SIP-34](https://github.com/apache/superset/issues/8976):
Thanks @junlincc @ktmud @graceguo-supercat @john-bodley @srinify for the valuable discussion.
Closes https://github.com/apache/superset/pull/15915
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<img width="495" alt="127211943-d3dfe888-f62e-4fe4-896c-6e035e2aac06" src="https://user-images.githubusercontent.com/70410625/127370147-829c6021-e5e5-4762-ae7c-32eb0db8792a.png">
<img width="521" alt="Screen Shot 2021-07-28 at 2 37 22 PM" src="https://user-images.githubusercontent.com/70410625/127370085-85ab3621-02e3-4cb6-acad-be9ca2bfe2dd.png">
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [x] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina merged pull request #15929: chore: Changes the main menu order as defined in SIP-34
Posted by GitBox <gi...@apache.org>.
michael-s-molina merged pull request #15929:
URL: https://github.com/apache/superset/pull/15929
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #15929: chore: Changes the main menu order as defined in SIP-34
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #15929:
URL: https://github.com/apache/superset/pull/15929#issuecomment-888562318
# [Codecov](https://codecov.io/gh/apache/superset/pull/15929?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#15929](https://codecov.io/gh/apache/superset/pull/15929?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (384e791) into [master](https://codecov.io/gh/apache/superset/commit/32d2aa0c404f47abaa270bf1c572fdd26feb16ed?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (32d2aa0) will **decrease** coverage by `0.08%`.
> The diff coverage is `88.57%`.
> :exclamation: Current head 384e791 differs from pull request most recent head a5f9678. Consider uploading reports for the commit a5f9678 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/15929?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #15929 +/- ##
==========================================
- Coverage 77.05% 76.97% -0.09%
==========================================
Files 988 988
Lines 52180 52195 +15
Branches 7095 7095
==========================================
- Hits 40209 40175 -34
- Misses 11746 11795 +49
Partials 225 225
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `81.27% <100.00%> (+0.01%)` | :arrow_up: |
| mysql | `81.48% <100.00%> (-0.04%)` | :arrow_down: |
| postgres | `81.55% <100.00%> (+0.05%)` | :arrow_up: |
| presto | `?` | |
| python | `81.89% <100.00%> (-0.18%)` | :arrow_down: |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/15929?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...-frontend/src/components/CronPicker/CronPicker.tsx](https://codecov.io/gh/apache/superset/pull/15929/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ3JvblBpY2tlci9Dcm9uUGlja2VyLnRzeA==) | `91.66% <ø> (ø)` | |
| [superset-frontend/src/views/CRUD/alert/types.ts](https://codecov.io/gh/apache/superset/pull/15929/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvdHlwZXMudHM=) | `100.00% <ø> (ø)` | |
| [superset/annotation\_layers/annotations/api.py](https://codecov.io/gh/apache/superset/pull/15929/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvYXBpLnB5) | `84.96% <ø> (ø)` | |
| [superset/reports/api.py](https://codecov.io/gh/apache/superset/pull/15929/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvcmVwb3J0cy9hcGkucHk=) | `87.78% <ø> (ø)` | |
| [superset/reports/logs/api.py](https://codecov.io/gh/apache/superset/pull/15929/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvcmVwb3J0cy9sb2dzL2FwaS5weQ==) | `94.11% <ø> (ø)` | |
| [...frontend/src/views/CRUD/alert/AlertReportModal.tsx](https://codecov.io/gh/apache/superset/pull/15929/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvQWxlcnRSZXBvcnRNb2RhbC50c3g=) | `61.70% <66.66%> (ø)` | |
| [superset/charts/api.py](https://codecov.io/gh/apache/superset/pull/15929/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `85.48% <100.00%> (ø)` | |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/superset/pull/15929/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `92.95% <100.00%> (ø)` | |
| [superset/initialization/\_\_init\_\_.py](https://codecov.io/gh/apache/superset/pull/15929/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvaW5pdGlhbGl6YXRpb24vX19pbml0X18ucHk=) | `87.91% <100.00%> (ø)` | |
| [superset/models/reports.py](https://codecov.io/gh/apache/superset/pull/15929/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvbW9kZWxzL3JlcG9ydHMucHk=) | `100.00% <100.00%> (ø)` | |
| ... and [13 more](https://codecov.io/gh/apache/superset/pull/15929/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/15929?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/15929?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [32d2aa0...a5f9678](https://codecov.io/gh/apache/superset/pull/15929?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org