You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Sid Wagle <sw...@hortonworks.com> on 2015/01/20 00:45:49 UTC

Review Request 30058: Support querying Metrics System Hbase metrics using Ambari API

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30058/
-----------------------------------------------------------

Review request for Ambari, Dmytro Sen, Mahadev Konar, and Myroslav Papirkovskyy.


Bugs: AMBARI-9165
    https://issues.apache.org/jira/browse/AMBARI-9165


Repository: ambari


Description
-------

API call to request component metrics for METRIC_COLLECTOR should return AMS-Hbase metrics.


Diffs
-----

  ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStore.java 1a0f530 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractPropertyProvider.java f13e1ba 
  ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProvider.java 8d29b4e 
  ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/PropertyHelper.java 4a92c66 
  ambari-server/src/main/resources/ganglia_properties.json 5bcf754 
  ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProviderTest.java 31df3e2 
  ambari-server/src/test/resources/ams/embedded_host_metric.json PRE-CREATION 

Diff: https://reviews.apache.org/r/30058/diff/


Testing
-------


Thanks,

Sid Wagle


Re: Review Request 30058: Support querying Metrics System Hbase metrics using Ambari API

Posted by Mahadev Konar <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30058/#review68677
-----------------------------------------------------------

Ship it!


Ship It!

- Mahadev Konar


On Jan. 20, 2015, 12:21 a.m., Sid Wagle wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30058/
> -----------------------------------------------------------
> 
> (Updated Jan. 20, 2015, 12:21 a.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Mahadev Konar, and Myroslav Papirkovskyy.
> 
> 
> Bugs: AMBARI-9165
>     https://issues.apache.org/jira/browse/AMBARI-9165
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> API call to request component metrics for METRIC_COLLECTOR should return AMS-Hbase metrics.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractPropertyProvider.java f13e1ba 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProvider.java 8d29b4e 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/PropertyHelper.java 4a92c66 
>   ambari-server/src/main/resources/ganglia_properties.json 5bcf754 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProviderTest.java 31df3e2 
>   ambari-server/src/test/resources/ams/embedded_host_metric.json PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/30058/diff/
> 
> 
> Testing
> -------
> 
> Unit test pass.
> Manually verified.
> 
> 
> Thanks,
> 
> Sid Wagle
> 
>


Re: Review Request 30058: Support querying Metrics System Hbase metrics using Ambari API

Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30058/
-----------------------------------------------------------

(Updated Jan. 20, 2015, 12:21 a.m.)


Review request for Ambari, Dmytro Sen, Mahadev Konar, and Myroslav Papirkovskyy.


Bugs: AMBARI-9165
    https://issues.apache.org/jira/browse/AMBARI-9165


Repository: ambari


Description
-------

API call to request component metrics for METRIC_COLLECTOR should return AMS-Hbase metrics.


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractPropertyProvider.java f13e1ba 
  ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProvider.java 8d29b4e 
  ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/PropertyHelper.java 4a92c66 
  ambari-server/src/main/resources/ganglia_properties.json 5bcf754 
  ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProviderTest.java 31df3e2 
  ambari-server/src/test/resources/ams/embedded_host_metric.json PRE-CREATION 

Diff: https://reviews.apache.org/r/30058/diff/


Testing (updated)
-------

Unit test pass.
Manually verified.


Thanks,

Sid Wagle


Re: Review Request 30058: Support querying Metrics System Hbase metrics using Ambari API

Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30058/
-----------------------------------------------------------

(Updated Jan. 19, 2015, 11:55 p.m.)


Review request for Ambari, Dmytro Sen, Mahadev Konar, and Myroslav Papirkovskyy.


Bugs: AMBARI-9165
    https://issues.apache.org/jira/browse/AMBARI-9165


Repository: ambari


Description
-------

API call to request component metrics for METRIC_COLLECTOR should return AMS-Hbase metrics.


Diffs (updated)
-----

  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractPropertyProvider.java f13e1ba 
  ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProvider.java 8d29b4e 
  ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/PropertyHelper.java 4a92c66 
  ambari-server/src/main/resources/ganglia_properties.json 5bcf754 
  ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProviderTest.java 31df3e2 
  ambari-server/src/test/resources/ams/embedded_host_metric.json PRE-CREATION 

Diff: https://reviews.apache.org/r/30058/diff/


Testing
-------


Thanks,

Sid Wagle