You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "Ajay9704 (via GitHub)" <gi...@apache.org> on 2026/01/17 07:13:59 UTC

[PR] fix:committers-link-60682 [airflow]

Ajay9704 opened a new pull request, #60684:
URL: https://github.com/apache/airflow/pull/60684

   
   Summary
   Fixed broken links to the GitHub airflow-committers team that were causing 404 errors. The links https://github.com/orgs/apache/teams/airflow-committers/members and https://github.com/orgs/apache/teams/airflow-committers are inaccessible to the public as GitHub organization teams are typically private.
   Changes Made
   Replaced broken GitHub team links with the official Apache Airflow committers page: https://airflow.apache.org/docs/apache-airflow/stable/project.html#committers
   Applied fixes to both affected files:
   contributing-docs/01_roles_in_airflow_project.rst
   COMMITTERS.rst
   Removed duplicate link entries to maintain consistency
   Related Issue
   Fixes #60682


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix:committers-link-60682 [airflow]

Posted by "Ajay9704 (via GitHub)" <gi...@apache.org>.
Ajay9704 commented on PR #60684:
URL: https://github.com/apache/airflow/pull/60684#issuecomment-3762927707

   @shahar1 
   Implemented all according to feedback:
   Preserved GitHub team link in COMMITTERS.rst for new committer validation
    Relocated internal links to appropriate section in COMMITTERS.rst  
    Removed confusing "(visible to existing committers)" comment
    Clean separation between public and internal documentation
    
   please let me know if anything else is needed


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix:committers-link-60682 [airflow]

Posted by "shahar1 (via GitHub)" <gi...@apache.org>.
shahar1 commented on code in PR #60684:
URL: https://github.com/apache/airflow/pull/60684#discussion_r2700738558


##########
contributing-docs/01_roles_in_airflow_project.rst:
##########
@@ -54,7 +54,6 @@ The official list of committers can be found `here <https://airflow.apache.org/d
 Additionally, committers are listed in a few other places (some of these may only be visible to existing committers):
 
 * https://whimsy.apache.org/roster/committee/airflow
-* https://github.com/orgs/apache/teams/airflow-committers/members

Review Comment:
   As the comment above states, both links are visible only to existing committers - so if you're non-committer and try to access them you may receive an error.
   
   However, as this specific page is intended to new contributors and could create confusion - I agree that these lines should be relocated AS-IS to the `COMMITTERS.rst`, as part of section 4 in "New Committer Onboarding Steps" (and then the "some of these..." comment could be safely removed as well).
   
   Make sure to also include the second link that you removed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Relocate internal links from contributing docs to COMMITTERS.rst [airflow]

Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #60684:
URL: https://github.com/apache/airflow/pull/60684#issuecomment-3762970110

   Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional contributions.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix:committers-link-60682 [airflow]

Posted by "shahar1 (via GitHub)" <gi...@apache.org>.
shahar1 commented on code in PR #60684:
URL: https://github.com/apache/airflow/pull/60684#discussion_r2700809635


##########
contributing-docs/01_roles_in_airflow_project.rst:
##########
@@ -54,7 +54,6 @@ The official list of committers can be found `here <https://airflow.apache.org/d
 Additionally, committers are listed in a few other places (some of these may only be visible to existing committers):
 
 * https://whimsy.apache.org/roster/committee/airflow
-* https://github.com/orgs/apache/teams/airflow-committers/members

Review Comment:
   Please double check, there is still 
   ```
   Additionally, committers are listed in a few other places:
   
   * https://whimsy.apache.org/roster/committee/airflow
   ```
   
   which could be removed.



##########
contributing-docs/01_roles_in_airflow_project.rst:
##########
@@ -54,7 +54,6 @@ The official list of committers can be found `here <https://airflow.apache.org/d
 Additionally, committers are listed in a few other places (some of these may only be visible to existing committers):
 
 * https://whimsy.apache.org/roster/committee/airflow
-* https://github.com/orgs/apache/teams/airflow-committers/members

Review Comment:
   Please double check, there is still 
   ```
   Additionally, committers are listed in a few other places:
   
   * https://whimsy.apache.org/roster/committee/airflow
   ```
   
   which could be removed from this page.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix:committers-link-60682 [airflow]

Posted by "Ajay9704 (via GitHub)" <gi...@apache.org>.
Ajay9704 commented on code in PR #60684:
URL: https://github.com/apache/airflow/pull/60684#discussion_r2700792369


##########
COMMITTERS.rst:
##########
@@ -216,7 +216,7 @@ To be able to merge PRs, committers have to integrate their GitHub ID with Apach
 2.  Merge your Apache and GitHub accounts using `GitBox (Apache Account Linking utility) <https://gitbox.apache.org/setup/>`__. This also asks you to link your
     GitHub ID to your Apache account. You should see 5 green checks in GitBox.
 3.  Wait at least 30  minutes for an email inviting you to Apache GitHub Organization and accept invitation.
-4.  After accepting the GitHub Invitation verify that you are a member of the `Airflow committers team on GitHub <https://github.com/orgs/apache/teams/airflow-committers>`__.

Review Comment:
   Moved internal committer links to this section as requested. Kept original GitHub team link for new committer validation.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Relocate internal links from contributing docs to COMMITTERS.rst [airflow]

Posted by "shahar1 (via GitHub)" <gi...@apache.org>.
shahar1 merged PR #60684:
URL: https://github.com/apache/airflow/pull/60684


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix:committers-link-60682 [airflow]

Posted by "Ajay9704 (via GitHub)" <gi...@apache.org>.
Ajay9704 commented on code in PR #60684:
URL: https://github.com/apache/airflow/pull/60684#discussion_r2700792514


##########
contributing-docs/01_roles_in_airflow_project.rst:
##########
@@ -54,7 +54,6 @@ The official list of committers can be found `here <https://airflow.apache.org/d
 Additionally, committers are listed in a few other places (some of these may only be visible to existing committers):
 
 * https://whimsy.apache.org/roster/committee/airflow
-* https://github.com/orgs/apache/teams/airflow-committers/members

Review Comment:
   Removed internal links and confusing comment as suggested. Only public-facing documentation remains.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Relocate internal links from contributing docs to COMMITTERS.rst [airflow]

Posted by "Ajay9704 (via GitHub)" <gi...@apache.org>.
Ajay9704 commented on PR #60684:
URL: https://github.com/apache/airflow/pull/60684#issuecomment-3762982058

   > Splendid work! Thank you both @Ajay9704 and @Srabasti
   
   Thank you! And thanks again for all the guidance throughout the process 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix:committers-link-60682 [airflow]

Posted by "shahar1 (via GitHub)" <gi...@apache.org>.
shahar1 commented on code in PR #60684:
URL: https://github.com/apache/airflow/pull/60684#discussion_r2700732531


##########
COMMITTERS.rst:
##########
@@ -216,7 +216,7 @@ To be able to merge PRs, committers have to integrate their GitHub ID with Apach
 2.  Merge your Apache and GitHub accounts using `GitBox (Apache Account Linking utility) <https://gitbox.apache.org/setup/>`__. This also asks you to link your
     GitHub ID to your Apache account. You should see 5 green checks in GitBox.
 3.  Wait at least 30  minutes for an email inviting you to Apache GitHub Organization and accept invitation.
-4.  After accepting the GitHub Invitation verify that you are a member of the `Airflow committers team on GitHub <https://github.com/orgs/apache/teams/airflow-committers>`__.

Review Comment:
   This shouldn't be changed - it's an internal page shown only to committers, so new committers could officialy validate their registration to the GitHub's org.



##########
contributing-docs/01_roles_in_airflow_project.rst:
##########
@@ -54,7 +54,6 @@ The official list of committers can be found `here <https://airflow.apache.org/d
 Additionally, committers are listed in a few other places (some of these may only be visible to existing committers):
 
 * https://whimsy.apache.org/roster/committee/airflow
-* https://github.com/orgs/apache/teams/airflow-committers/members

Review Comment:
   As the comment above states, both links are visible only to existing committers - so if you're non-committer and try to access them you may receive an error.
   However, as this specific page is intended to new contributors and could create confusion - I agree that these lines should be relocated to the `COMMITTERS.rst`, as part of section 4 in "New Committer Onboarding Steps" (and then the "some of these..." comment could be safely removed as well).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Relocate internal links from contributing docs to COMMITTERS.rst [airflow]

Posted by "shahar1 (via GitHub)" <gi...@apache.org>.
shahar1 commented on PR #60684:
URL: https://github.com/apache/airflow/pull/60684#issuecomment-3762949751

   > @shahar1 Implemented all according to feedback: Preserved GitHub team link in COMMITTERS.rst for new committer validation Relocated internal links to appropriate section in COMMITTERS.rst Removed confusing "(visible to existing committers)" comment Clean separation between public and internal documentation
   > 
   > please let me know if anything else is needed
   
   Almost there, please see my last comment


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Relocate internal links from contributing docs to COMMITTERS.rst [airflow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #60684:
URL: https://github.com/apache/airflow/pull/60684#issuecomment-3762971745

   ### Backport successfully created: v3-1-test
   
   <table>
                   <tr>
                       <th>Status</th>
                       <th>Branch</th>
                       <th>Result</th>
                   </tr>
                   <tr>
                       <td>✅</td>
                       <td>v3-1-test</td>
                       <td><a href="https://github.com/apache/airflow/pull/60691"><img src="https://img.shields.io/badge/PR-60691-blue" alt="PR Link"></a></td>
                   </tr>
               </table>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org