You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by ahgittin <gi...@git.apache.org> on 2015/03/13 10:14:29 UTC
[GitHub] incubator-brooklyn pull request: misc small fixes - 20150313
GitHub user ahgittin opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/549
misc small fixes - 20150313
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ahgittin/incubator-brooklyn misc-20150313
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/549.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #549
----
commit b578f121942e3081cafb8197c492080fac7046ea
Author: Alex Heneveld <al...@cloudsoftcorp.com>
Date: 2015-03-02T12:03:29Z
suppress unnecessary broken persistence integration test for deprecated persister
commit b955f7f9a49bd1d8306bd68886f7ff26f662e032
Author: Alex Heneveld <al...@cloudsoftcorp.com>
Date: 2015-03-13T09:11:40Z
better logging when can't instantiate on rebind
commit 8542c515e9ed8572ea82b48a9d491ccd8619dc04
Author: Alex Heneveld <al...@cloudsoftcorp.com>
Date: 2015-03-13T09:12:02Z
fix bug where some persistence calls (eg from rest api) use non-instantiable catalog item (DO not DTO)
commit 36edce288301cf974ad22b386acf4c9f56f270cd
Author: Alex Heneveld <al...@cloudsoftcorp.com>
Date: 2015-03-13T09:12:29Z
update links in archetype file
commit b92050cc7ba7001c456ffdc77fce7151501de922
Author: Alex Heneveld <al...@cloudsoftcorp.com>
Date: 2015-02-04T12:33:14Z
tidy of mongo yaml
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: misc small fixes - 20150313
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/549#discussion_r26497139
--- Diff: core/src/test/java/brooklyn/entity/rebind/persister/BrooklynMementoPersisterToMultiFileTest.java ---
@@ -58,7 +59,10 @@ public void tearDown() throws Exception {
mementoDir = Os.deleteRecursively(mementoDir).asNullOrThrowing();
}
- // to have this picked up in the IDE
-// @Test public void noop() {}
-
+ @Test(groups="Integration")
+ public void testLoadAndCheckpointRawMemento() throws Exception {
+ // test here is deliberately no-op;
+ // checkpoint routines not supported for this (deprecated) persister
--- End diff --
I prefer to do `throw new org.testng.SkipException("checkpoint routines not supported for this (deprecated) persister")`, but no strong feelings.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: misc small fixes - 20150313
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/549
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: misc small fixes - 20150313
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/549#discussion_r26497263
--- Diff: usage/archetypes/quickstart/src/brooklyn-sample/README.md ---
@@ -65,9 +65,9 @@ deployment depending on what the application needs.
For more information consider:
-* Visiting the open-source Brooklyn home page at http://brooklyncentral.github.com
-* Forking the Brooklyn project at http://github.com/brooklyncentral/brooklyn
-* Emailing brooklyn-users@googlegroups.com
+* Visiting the Apache Brooklyn home page at http://brooklyn.io/
--- End diff --
I think we should use `htts://brooklyn.incubator.apache.org` (rather than this re-direct, even though it's shorter).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: misc small fixes - 20150313
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/549#issuecomment-81754083
Looks good; only trivial comments. Merging now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---