You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Lars Francke <as...@lars-francke.de> on 2014/07/30 01:10:47 UTC
Review Request 24076: HIVE-7107: Clean up HiveDrivers and fix an issue
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24076/
-----------------------------------------------------------
Review request for hive.
Bugs: HIVE-7107
https://issues.apache.org/jira/browse/HIVE-7107
Repository: hive-git
Description
-------
The HiveServer1 driver does not adhere to the JDBC standard of returning null when it can't handle a connection URL.
I realize that HS1 is scheduled to be removed but I submitted this before 0.13.1 was released and maybe 0.13.2 will be released still. Also I think there's a chance that some distributions will keep HS1 in for a bit longer and this patch fixes an issue with it.
Diffs
-----
itests/hive-unit/src/test/java/org/apache/hadoop/hive/jdbc/TestJdbcDriver.java e2d9b42
jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveDriver.java 68c0788
jdbc/src/java/org/apache/hive/jdbc/HiveDriver.java 6e248d6
Diff: https://reviews.apache.org/r/24076/diff/
Testing
-------
Thanks,
Lars Francke
Re: Review Request 24076: HIVE-7107: Clean up HiveDrivers and fix an
issue
Posted by Thejas Nair <th...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24076/#review54446
-----------------------------------------------------------
Ship it!
Ship It!
- Thejas Nair
On Sept. 24, 2014, 12:06 p.m., Lars Francke wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24076/
> -----------------------------------------------------------
>
> (Updated Sept. 24, 2014, 12:06 p.m.)
>
>
> Review request for hive.
>
>
> Bugs: HIVE-7107
> https://issues.apache.org/jira/browse/HIVE-7107
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> The HiveServer1 driver does not adhere to the JDBC standard of returning null when it can't handle a connection URL.
>
> I realize that HS1 is scheduled to be removed but I submitted this before 0.13.1 was released and maybe 0.13.2 will be released still. Also I think there's a chance that some distributions will keep HS1 in for a bit longer and this patch fixes an issue with it.
>
>
> Diffs
> -----
>
> itests/hive-unit/src/test/java/org/apache/hadoop/hive/jdbc/TestJdbcDriver.java fa8c43b
> jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveDriver.java 68c0788
>
> Diff: https://reviews.apache.org/r/24076/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Lars Francke
>
>
Re: Review Request 24076: HIVE-7107: Clean up HiveDrivers and fix an
issue
Posted by Lars Francke <as...@lars-francke.de>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24076/
-----------------------------------------------------------
(Updated Sept. 24, 2014, 12:06 p.m.)
Review request for hive.
Bugs: HIVE-7107
https://issues.apache.org/jira/browse/HIVE-7107
Repository: hive-git
Description
-------
The HiveServer1 driver does not adhere to the JDBC standard of returning null when it can't handle a connection URL.
I realize that HS1 is scheduled to be removed but I submitted this before 0.13.1 was released and maybe 0.13.2 will be released still. Also I think there's a chance that some distributions will keep HS1 in for a bit longer and this patch fixes an issue with it.
Diffs (updated)
-----
itests/hive-unit/src/test/java/org/apache/hadoop/hive/jdbc/TestJdbcDriver.java fa8c43b
jdbc/src/java/org/apache/hadoop/hive/jdbc/HiveDriver.java 68c0788
Diff: https://reviews.apache.org/r/24076/diff/
Testing
-------
Thanks,
Lars Francke